Give each method a much clearer path and make sure they aren't
tangled together.

This should also fix a bug with external-ui-mode where if no
secrets were required, or both secrets were saved, that external
UI mode would exit early without writing a keyfile to stdout.
This caused a traceback in GNOME Shell 3.12.

https://bugzilla.gnome.org/show_bug.cgi?id=728681

Based off NM-openvpn commit 440671733a3e38c63a9b5882482c4cc710c71a39

Fixes warnings when importing connections.

Florian Müllner authored Feb 06, 2014 and Thomas Haller committed Feb 07, 2014

Passing --pid-file option and its argument in a single string isn't
understood by vpnc's option parser - both have to be passed as separate
argv members.

https://bugzilla.gnome.org/show_bug.cgi?id=723804



Signed-off-by: Thomas Haller <thaller@redhat.com>

nm_vpnc_start_vpnc_binary() uses priv->pid_file, so clearly it should
be set before calling that function.

It sometimes makes people think the service is hung when all it
prints out is "starting...".

Like the original stdout-based communication, always return any secrets
which were found.  If the secret doesn't need to be requeted from the
user, ensure "ShouldAsk" is FALSE.

This fixes a problem with GNOME Shell where both secrets were
stored by the user agent.  Since agents delete any saved secrets before
saving new secrets, this would delete the "IPSec secret" item, but since
that item was not included in the returned secrets, it wouldn't be
re-saved, and would be lost.

Make sure gettext knows the translations are in UTF-8, or else they'll
get garbled if the user's domain isn't UTF-8.

https://bugzilla.gnome.org/show_bug.cgi?id=702153

Robby Workman authored Jul 08, 2013 and Dan Williams committed Aug 12, 2013

The vpnc binary seems to hardcode /var/run/vpnc/ as its pid dir,
which is created if vpnc is started using its included script
in $sysconfdir/vpnc/ - however, if it's started by NM-vpnc,
syslog shows "can't open pidfile /var/run/vpnc/pid for writing"

Fix that by using $localstatedir/run/NetworkManager/ as piddir.

Much thanks and credit should go to Dan Williams for walking
this novice through most of this patch :-)

https://bugzilla.gnome.org/show_bug.cgi?id=703821



Reported-by: Claudio Cavalera <claudio.cavalera@gmail.com>
Signed-off-by: Robby Workman <rworkman@slackware.com>

https://bugzilla.gnome.org/show_bug.cgi?id=694307

https://bugzilla.gnome.org/show_bug.cgi?id=697740

Include the full path to the auth-dialog and properties library in the
.name file, like we already do for the main helper program.

https://bugzilla.gnome.org/show_bug.cgi?id=694768

Only call g_type_init() on older glibs.

Add a missing #include (that presumably used to get accidentally
pulled in by something else).

Use -DGDK_VERSION_MIN_REQUIRED to avoid deprecation warnings on
GtkTable.

http://tools.ietf.org/html/rfc4301#section-1.1

The argument is 'klass', not 'obj'.