- Nov 30, 2016
-
-
Francesco Giudici authored
-
Francesco Giudici authored
Change the autonegotiate CheckButton with a link negotiation ComboBox allowing the "Ignore", "Automatic" and "Manual" values. In this way it is possible to remove the "Default" value from the Duplex and Speed boxes. They will be enabled to enforce the specified values only when "Manual" is selected. Move the link negotiation section on bottom.
-
Francesco Giudici authored
NetworkManager 802-3 link properties have been implemented in: https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=e0c50a970378daf8f066c293c613276d322cc056 'auto-negotiate' default value has been also changed to "false", as together with 'speed' = 0 and duplex unset (NULL) instructs NetworkManager to skip link configuration. Before the implementation, the 'auto-negotiate', 'speed' and 'duplex' 802-3 properties were ignored, without regards of the value they were set. The duplex property in particular was silently set to "full" by c-e for each connection modified. This triggered NetworkManager to force a static link configuration with duplex mode and unspecified speed (thanks to poma for reporting this). Now, properties are checked and enforced in NetworkManager: https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=b029e9256963b3adfde35d1e5adad50b838fdb1d Allowed combinations are: auto-negotiate on, speed 0, duplex NULL auto-negotiate off, speed 0, duplex NULL (default, ignore link config) auto-negotiate off, speed != 0, duplex !=NULL Align nm-connection-editor to deal with NULL 'duplex' and use it as default.
-
Francesco Giudici authored
Fixes: db6813ef
-
- Nov 25, 2016
-
-
NetworkManager 802-3 link properties have been implemented in: https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=e0c50a97037 'auto-negotiate' default value has been also changed to "false", as together with 'speed' = 0 and duplex unset (NULL) instructs NetworkManager to skip link configuration. Before the implementation, the 'auto-negotiate', 'speed' and 'duplex' 802-3 properties were ignored, without regards of the value they were set. The duplex property in particular was silently set to "full" by c-e for each connection modified. This triggers NetworkManager to force a static link configuration with duplex mode and unspecified speed. [fgiudici@redhat.com: rewritten the commit message]
-
- Nov 24, 2016
-
-
- Nov 22, 2016
-
-
Thomas Haller authored
We shouldn't use g_log() for regular error messages. They garble the output and should be used only for internal errors and notifications (or preferably not at all).
-
Thomas Haller authored
Previously, we would only support nm-connection-editor --create --type vpn:openvpn Now, support nm-connection-editor --create --type openvpn directly.
-
Thomas Haller authored
Fixes hanging application when pressing "Cancel" with nm-connection-editor --create
-
Thomas Haller authored
Transfering ownership through multiple layers of function calls is complicated, because every layer must ensure that it either unrefs the connection or passes it to another function that takes ownership. Just don't do that. Whoever wants to keep a reference on the connection, should take it. Also, note that the destination of the connection is eventually nm_connection_editor_new(). But nm_connection_editor_new() doesn't take over the reference, it keeps the connection by taking an additional reference. I think we just leaked the connection there. Also, make the connection argument optional where it is not needed. That is necessary, because note how vpn_connection_new() behaves differently whether we pass in a connection or not.
-
Thomas Haller authored
-
Thomas Haller authored
-
Thomas Haller authored
-
Thomas Haller authored
-
Thomas Haller authored
-
Thomas Haller authored
-
Thomas Haller authored
Allows you to grep for places that implement the function and which call it.
-
- Nov 20, 2016
-
-
Piotr Drąg authored
-
- Nov 18, 2016
-
-
Beniamino Galvani authored
Setting d->ap to NULL in _active_ap_set_weakref() causes the ActiveAPData to be destroyed in _active_ap_set() and the access to d->applet to be invalid. ==31046== Invalid read of size 8 ==31046== at 0x4227C0: _active_ap_set_weakref (applet-device-wifi.c:125) ==31046== by 0x94F4F7E: weak_refs_notify (gobject.c:2636) ==31046== by 0x7468E53: dispose (nm-object.c:1243) ==31046== by 0x94F6095: g_object_unref (gobject.c:3146) ==31046== by 0x995607A: g_ptr_array_foreach (garray.c:1502) ==31046== by 0x995610F: ptr_array_free (garray.c:1088) ==31046== by 0x745C0BD: clean_up_aps (nm-device-wifi.c:537) ==31046== Address 0x1e1ab090 is 0 bytes inside a block of size 32 free'd ==31046== at 0x4C2CD5A: free (vg_replace_malloc.c:530) ==31046== by 0x9986F2D: g_free (gmem.c:189) ==31046== by 0x999E40F: g_slice_free1 (gslice.c:1136) ==31046== by 0x421734: _active_ap_set (applet-device-wifi.c:146) ==31046== by 0x4227BF: _active_ap_set_weakref (applet-device-wifi.c:123) ==31046== by 0x94F4F7E: weak_refs_notify (gobject.c:2636) ==31046== by 0x7468E53: dispose (nm-object.c:1243)
-
- Nov 17, 2016
-
-
- Nov 15, 2016
-
-
Dan Williams authored
-
-
- Nov 13, 2016
-
-
Piotr Drąg authored
-
- Nov 11, 2016
-
-
Beniamino Galvani authored
The MTU property in the wired setting has no effect for PPPoE connections, as the MTU for the PPP interface is controlled by the ppp.mtu properties. Disable the MTU spin button if the connection is a PPPoE one since it's confusing for users. https://bugzilla.redhat.com/show_bug.cgi?id=1385198
-
-
Lubomir Rintel authored
It currently can only import VPN connections.
-
Lubomir Rintel authored
Split the file and the actual import logic, so that it can be invoked with a file name known in advance. Also move it into connection-helpers -- it well might in future be extended to handle other connection types. There's really nothing VPN-specific about a file picker.
-
Lubomir Rintel authored
The page can use an already existing connection instead of creating a new one. This would be useful for importing the connections. Currently we let the new page functions handle the imports (for VPN connections), but that's not a very good idea -- when we're able to import non-VPN connections we might not even know the connection type in advance. The new page functions are still able to construct the connections themselves according to details passed and even interact with the user. That might be worthwhile streamlining at some point.
-
- Nov 07, 2016
-
-
Beniamino Galvani authored
If the plugin returns an empty detail list, we would access past the array in: i_add_detail = (++add_details)[0]; Fixes: 9ab2f79b
-
- Oct 25, 2016
-
-
- Oct 23, 2016
-
-
Jordi Mas authored
-
- Oct 22, 2016
-
-
- Oct 19, 2016
-
-
Thomas Haller authored
Previously, `nm-connection-editor --create` without explicit --type argument would directly create an ethernet connection. Now, open instead the list of connection types, as if the user clicks "Add" in the main menu. It also changes behavior for `nm-connection-editor --show`, which previously behaved like `nm-connection-editor --show --type 802-3-ethernet`. Now it behaves like `nm-connection-editor` without arguments.
-
-
- Oct 15, 2016
-
-
- Oct 14, 2016
-
-
Piotr Drąg authored
-
Piotr Drąg authored
-
-
Beniamino Galvani authored
Move some common functions for retrieving tree model values to utils/util.c
-
Beniamino Galvani authored
The route metric can assume a value between 0 and 2^32, or -1 to indicate that the default value for the device should be used. In the connection editor we previously saved a missing route metric as zero and incorrectly displayed the -1 (default) value as 4294967295. Instead, leave the field empty for default metric. This is similar to the nmcli convention. https://bugzilla.gnome.org/show_bug.cgi?id=769015
-