Mikhail Efremov authored Aug 25, 2016 and Beniamino Galvani committed Oct 31, 2016

Function nm_setting_duplicate() can't copy object's data.
As a result a value of the "Ignore CA certificate" checkbox was
always lost. So don't copy settings, just use g_object_ref() again
and remove the 8021x setting from the temporary object to prevent
the clearing of secrets.

https://mail.gnome.org/archives/networkmanager-list/2016-August/msg00109.html

Fixes: c21d56dd
(cherry picked from commit 2c844acc)

When @tmp_connection is destroyed it clears all its secrets: remove
the 802.1x setting before unreferencing the connection since the
setting is used by another connection.

Fixes: 3722a190

https://bugzilla.gnome.org/show_bug.cgi?id=769661
(cherry picked from commit 4eecd640)

See https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=b33aacbc91864f20f4733919af1a4cf8f725ca94

(cherry picked from commit 30957072)
(cherry picked from commit 97229212)

Previously, a failure to nm_vpn_editor_plugin_get_editor() was not considered fatal for the
VPN page, and thus it whould show a dialog without VPN tab. Load the editor early and fail.

(cherry picked from commit a8bbd94e)

(cherry picked from commit 801742a7)

(cherry picked from commit a35d4662)

Previously, when selecting the "Create" button with the keyboard (tab key),
pressing ENTER would still invoke the "Cancel" action.

We either want that ENTER invokes the "Create" action, or that ENTER
invokes the currently selected button (be it "Create" or "Cancel").

This patch changes the UI to do the latter.

https://bugzilla.redhat.com/show_bug.cgi?id=1339565
(cherry picked from commit e37e9bc1)

Future versions of gettext will fail if this header is missing.

Fixes: bd20efeb
(cherry picked from commit 324f1735)

Handler's arguments were swapped. Since we also need to update the
current icon when the theme changes, introduce a dedicated handler.

Fixes: 40f052d3

https://bugzilla.gnome.org/show_bug.cgi?id=767574
(cherry picked from commit f0f11106)

Fixes the following:

g_hash_table_iter_next: assertion 'ri->version == ri->hash_table->version' failed

(cherry picked from commit a6b086b4)

'@' must be prepended to format string in order to get a GVariant.

Fixes: 3722a190

https://bugzilla.gnome.org/show_bug.cgi?id=765089
(cherry picked from commit 91d83b70)

When the request for secrets fails we don't enable the "Connect"
button, but the "Cancel" one should become enabled.

(cherry picked from commit 4e9d6800)

When secrets for a connection become available we update all the
WirelessSecurity items, triggering multiple calls to
stuff_changed_cb() (since it is registered as a callback for changed
events). But only the currently selected security item should cause a
change in the activation of the "Connect" button.

https://bugzilla.gnome.org/show_bug.cgi?id=597839
(cherry picked from commit 093657df)

Mathieu Trudel-Lapierre authored May 20, 2016 and Dan Williams committed May 20, 2016

Otherwise one would see WWAN use the last icon applied in the applet
since indicators cannot use pixmaps for the main indicator icon.

(cherry picked from commit 73b9a582)