Skip to content
  • António Fernandes's avatar
    directory-async: Make callback matching more understandable · 7d470a4d
    António Fernandes authored and Peter Eisenmann's avatar Peter Eisenmann committed
    This function used to be unnecessarily long and complex, so it has been
    simplified by commit e3052ab1
    
    However, now it's too cryptic/obfuscated. This is partly dues to the
    clash between boolean logic (`0` being FALSE) and the requirements of
    g_list_find_custom() (`0` being a positive match). And partly because
    of nested ternary operator, dereferencing a union, and unfortunate
    naming (`callback` having double meaning).
    
    To make the code easily readable and auditable by humans, let's break
    up the comparisons and use explicit return value literals.
    7d470a4d