Marco Trevisan authored Jul 26, 2018 and Marco Trevisan committed Jul 26, 2018

When a file view was loaded with a pending selection, and not all the files were
seen yet, the private pending_selection list was properly free'd, but the pointer
was not cleared, causing a crash when `nautilus_files_view_set_selection` was
called again, as it was trying to deeply copy a list pointed by this invalid
reference.

So, removing the unneeded `pending_selection` temporary pointer from the main
function scope, as it only confuses, while use it (with an autolist) when we
need to pass the previous `priv->pending_selection` (stealing its ownership)
to set_selection again.

Eventually use a g_clear_pointer to free the list and nullify its priv reference

Fixes #295


(cherry picked from commit ae3382a2)

António Fernandes authored May 06, 2018 and Marco Trevisan committed Jul 17, 2018

The standalone "~" key ("asciitilde") works as a convenient shortcut
to type home-relative paths into the location entry.

However, some keyboard layouts don't have an standalone "~" key but
rather a "dead tilde" key. This makes the existing shortcut unavaliable
for some keyboard layouts.

This is surprising for most people, because they have a tilde key and
the Keyboard Shortcuts window advertises a shortcut for the tilde key.

So, add the dead tilde key as an alternative shortcut.

Note: Searching for tilded characters or the tilde character itself
is still possible by revealing the search entry is explicitly.

Fixes #372


(cherry picked from commit ab16292e)

Wong Heung Sang authored Jun 03, 2018 and Marco Trevisan committed Jul 17, 2018

In nautilus_get_mounted_mount_for_root
g_volume_monitor_get is called
without cleanup

We need cleanup or auto cleanup
for GVolumeMonitor

g_autoptr is added for auto cleanup

Closes #471


(cherry picked from commit 44601d99)

Wong Heung Sang authored May 07, 2018 and Carlos Soriano Sánchez committed Jun 05, 2018

File opened in recent tab now is read-only
when it is writable.

Replace nautilus_file_info_get_uri ()
with nautilus_file_info_get_activation_uri ()
fix the problem.

#378

Currently, when looping over icon sizes, each icon is copied to
$MESON_BUILD_ROOT/@appid@.png, meaning that the file is overwritten on
every iteration. This commit fixes that by copying to a subdirectory
under the build root and installing from there.

Fixes GNOME/nautilus#364


(cherry picked from commit 5633b13f)

Accessible name-changed events should not be emitted during the
initial load of the icon container. They should only be emitted when
a user-triggered action such as renaming the file causes the change.

This event is being emitted when the editable_text property is being
set. During the initial load the value is null, so check for that
condition and only emit the event when the original value is non-null.


(cherry picked from commit 0c80a845)

Accessible children-changed events should not be emitted during the
initial load of the icon container. They should only be emitted when
a user-triggered action (creation of file, copying an item) causes
an item to be added.

User-triggered actions result in nautilus_canvas_container_layout_now
being called, so set a flag there so that we can distinguish the two
types of additions in the accessible icon-added callback.


(cherry picked from commit a4c27ad2)

Ernestas Kulik authored Mar 15, 2018 and Carlos Soriano Sánchez committed Apr 09, 2018

Creating and destroying the controller each time we want to rename
something results in not being able to pop down the popover, which leads
to an inconsistent look.

The “containing-directory” in the file name widget controller parent
class needed to be made non-construct-only, as otherwise it would be
impossible to reuse the same controller.

Fixes #260

find_library expects the library name without the 'lib' prefix,
otherwise it will be looking for "liblibm"


(cherry picked from commit 1358dc6b)

When displaying an error dialog box, a string that stores the error details, is not being freed. So use g_autofree instead.


(cherry picked from commit c6cd3699)

We disable trashing/deleting the Desktop directory. But we allow
trashing/deleting other XDG user dirs (Documents, Music,...).

If a person doesn't want to use an "icons on desktop" implementation,
this person may want to remove this folder from their Home directory.

To allow it, don't disable trashing/deleting the Desktop directory.


(cherry picked from commit 2787773c)

Recently we have been seeing that gsettings doesn't work inside the
Flatpak build of Nautilus.

In GNOME/nautilus@3f6cd2fe
we gave full host access to Nautilus, so I expected that no more
--filesystem permission would be necessary.

For some reason... we still need to put that. Although it looks like a
bug somewhere.

For now, let's just explicitly allow access the desrt folder.


(cherry picked from commit 8ac9c873)

Update nautilus-view-icon-controller.c: add NULL initialization to ptrs

See merge request !165

g_autoptr (GQueue) files_queue = NULL;
g_autoptr (GQueue) item_models = NULL;

Signed-off-by: Josue David Hernandez <josue.d.hernandez.gutierrez@intel.com>