Skip to content
  1. May 06, 2023
  2. Mar 04, 2023
  3. Sep 06, 2022
  4. Aug 22, 2022
  5. Aug 19, 2022
  6. Aug 09, 2022
  7. Aug 02, 2022
  8. Jul 28, 2022
  9. Jul 07, 2022
  10. Jul 06, 2022
  11. Jul 05, 2022
  12. Apr 18, 2022
  13. Apr 17, 2022
  14. Apr 07, 2022
  15. Mar 10, 2022
  16. Nov 05, 2021
  17. May 01, 2021
  18. Feb 24, 2021
  19. Jan 15, 2021
  20. Dec 22, 2020
    • Eduardo Lima (Etrunko)'s avatar
      proxy: Fix error handling · dc0a2b06
      Eduardo Lima (Etrunko) authored
      
      
      Error returned by the task must be freed by the caller of the function.
      This avoids a double-free scenario, as reported by valgrind:
      
      Invalid free() / delete / delete[] / realloc()
         at 0x483A9F5: free (vg_replace_malloc.c:538)
         by 0x5A4C45C: g_free (in /usr/lib64/libglib-2.0.so.0.6600.3)
         by 0x5A6673F: g_slice_free1 (in /usr/lib64/libglib-2.0.so.0.6600.3)
         by 0x5A2CC09: g_clear_error (in /usr/lib64/libglib-2.0.so.0.6600.3)
         by 0x56F43B7: rest_call_async_set_error (ovirt-proxy.c:245)
         by 0x56F451A: call_async_cb (ovirt-proxy.c:265)
         by 0x571AFC3: ??? (in /usr/lib64/librest-0.7.so.0.0.0)
         by 0x5789593: ??? (in /usr/lib64/libsoup-2.4.so.1.11.0)
         by 0x5789B82: ??? (in /usr/lib64/libsoup-2.4.so.1.11.0)
         by 0x5789CD5: ??? (in /usr/lib64/libsoup-2.4.so.1.11.0)
         by 0x5A468AA: ??? (in /usr/lib64/libglib-2.0.so.0.6600.3)
         by 0x5A477EE: g_main_context_dispatch (in /usr/lib64/libglib-2.0.so.0.6600.3)
       Address 0x17d731b0 is 0 bytes inside a block of size 16 free'd
         at 0x483A9F5: free (vg_replace_malloc.c:538)
         by 0x5A4C45C: g_free (in /usr/lib64/libglib-2.0.so.0.6600.3)
         by 0x5A6673F: g_slice_free1 (in /usr/lib64/libglib-2.0.so.0.6600.3)
         by 0x5A2CC09: g_clear_error (in /usr/lib64/libglib-2.0.so.0.6600.3)
         by 0x43115A: ovirt_foreign_menu_iso_name_changed (remote-viewer-iso-list-dialog.c:358)
         by 0x587A349: ??? (in /usr/lib64/libgio-2.0.so.0.6600.3)
         by 0x587A58A: ??? (in /usr/lib64/libgio-2.0.so.0.6600.3)
         by 0x4302F7: iso_name_set_cb (ovirt-foreign-menu.c:423)
         by 0x587A349: ??? (in /usr/lib64/libgio-2.0.so.0.6600.3)
         by 0x587A58A: ??? (in /usr/lib64/libgio-2.0.so.0.6600.3)
         by 0x56F43AF: rest_call_async_set_error (ovirt-proxy.c:244)
         by 0x56F451A: call_async_cb (ovirt-proxy.c:265)
       Block was alloc'd at
         at 0x4839809: malloc (vg_replace_malloc.c:307)
         by 0x5A4F908: g_malloc (in /usr/lib64/libglib-2.0.so.0.6600.3)
         by 0x5A671C1: g_slice_alloc (in /usr/lib64/libglib-2.0.so.0.6600.3)
         by 0x5A33286: g_error_new_valist (in /usr/lib64/libglib-2.0.so.0.6600.3)
         by 0x5A3348E: g_set_error (in /usr/lib64/libglib-2.0.so.0.6600.3)
         by 0x56FB4D5: ovirt_utils_gerror_from_xml_fault (ovirt-utils.c:368)
         by 0x56F4356: rest_call_async_set_error (ovirt-proxy.c:242)
         by 0x56F451A: call_async_cb (ovirt-proxy.c:265)
         by 0x571AFC3: ??? (in /usr/lib64/librest-0.7.so.0.0.0)
         by 0x5789593: ??? (in /usr/lib64/libsoup-2.4.so.1.11.0)
         by 0x5789B82: ??? (in /usr/lib64/libsoup-2.4.so.1.11.0)
         by 0x5789CD5: ??? (in /usr/lib64/libsoup-2.4.so.1.11.0)
      
      Signed-off-by: default avatarEduardo Lima (Etrunko) <etrunko@redhat.com>
      dc0a2b06
  21. Oct 26, 2020
  22. Sep 15, 2020
  23. Sep 06, 2020
  24. Jul 13, 2020
  25. Jun 25, 2020
  26. Jun 23, 2020
  27. Apr 01, 2020
  28. Mar 07, 2020
  29. Jan 27, 2020
  30. Jan 21, 2020
  31. Jan 20, 2020