This code is heavily dependent on X11 API.

Asking for a keyboard device's position doesn't even make sense
anyway.

It's not needed with modern gtk+ .

This isn't needed and in fact causes runtime warnings.

XkbGetKeyboard() might fail but we might still be able to work with a
XkbGetKeyboardByName() later in gkbd_keyboard_drawing_set_keyboard()
so don't abort the initialization if it fails.

We need to tell gtk+ we handled the key event otherwise gtk+ keynav
key events will move focus to the close button and it looks like the
dialog stopped working.

Signed-off-by: Trần Ngọc Quân <vnwildman@gmail.com>

Future versions of gettext will fail if this header is missing.

Philip Withnall authored May 02, 2014 and Philip Withnall committed Jan 22, 2016

It is deprecated. Instead, AC_CONFIG_MACRO_DIR[S] should be used.

https://bugzilla.gnome.org/show_bug.cgi?id=729392

Antonio Ospite authored Jan 22, 2016 and Michael Catanzaro committed Jan 22, 2016

When drawing the keyboard without having set the groups and levels there
is a segmentation fault:

  Program received signal SIGSEGV, Segmentation fault.
  0x00007fffe49ae8c9 in draw_key_label (is_pressed=<optimized out>, xkb_height=<optimized out>, xkb_width=<optimized out>, xkb_origin_y=<optimized out>,
      xkb_origin_x=<optimized out>, angle=0, keycode=<optimized out>, drawing=0xa540e0, context=0xca6080) at gkbd-keyboard-drawing.c:1017
  1017                    if (drawing->groupLevels[glp] == NULL)

Fix that.

The widget now is able to draw a keyboard without the keys labels, which
can be useful when testing just the keyboard geometry.

https://bugzilla.gnome.org/show_bug.cgi?id=760988

Antonio Ospite authored Aug 11, 2014 and Michael Catanzaro committed Jan 22, 2016

https://bugzilla.gnome.org/show_bug.cgi?id=734619

Antonio Ospite authored Aug 11, 2014 and Michael Catanzaro committed Jan 21, 2016

When track_modifiers is true and a modifier key gets pressed, do not
free and reallocate the data and, in particular, do not reallocate
drawing->keys zeroing it; this would result in the modifier keys pressed
states to be forgotten and the modifier keys not to be shown as pressed
when in fact they are (the keyboard symbols reflect the shift level
correctly).

Fix the current situation, allowing the modifier keys pressed state to
be drawn correctly.

https://bugzilla.gnome.org/show_bug.cgi?id=734621

Antonio Ospite authored Aug 02, 2014 and Michael Catanzaro committed Jan 21, 2016

Some keys like the function key "FN" are described in geometry files but
they have no keycode associated to them. You can find such keys in the
thinkpad and in the hhk geometry files.

Allow drawing the shape of these keys with invalid keycodes, and just
skip looking for the labels as the label is derived from the keycode.

https://bugzilla.gnome.org/show_bug.cgi?id=734618