Skip to content
  1. Mar 11, 2019
  2. Jan 14, 2019
    • Ondrej Holy's avatar
      admin: Prevent access if any authentication agent isn't available · d437df38
      Ondrej Holy authored
      The backend currently allows to access and modify files without prompting
      for password if any polkit authentication agent isn't available. This seems
      isn't usually problem, because polkit agents are integral parts of
      graphical environments / linux distributions. The agents can't be simply
      disabled without root permissions and are automatically respawned. However,
      this might be a problem in some non-standard cases.
      
      This affects only users which belong to wheel group (i.e. those who are
      already allowed to use sudo). It doesn't allow privilege escalation for
      users, who don't belong to that group.
      
      Let's return permission denied error also when the subject can't be
      authorized by any polkit agent to prevent this behavior.
      
      Closes: https://gitlab.gnome.org/GNOME/gvfs/issues/355
      d437df38
  3. Jul 26, 2018
    • Ondrej Holy's avatar
      dav: Increase max number of connections to prevent lockups · 4a0f41d5
      Ondrej Holy authored
      Currently, the default value of max-conns-per-host libsoup property is
      used, which causes dav backend lockups if two files are	opened.	I don't
      see any	easy solution how to prevent lockups, but we can definitely
      reduce the chance of them by increasing max-conns properties. Much bigger
      values are used by browsers nowadays. Hope that 32 is big enough for
      regular use cases and small enough to not flood a server and not block
      too much file descriptors...
      
      Closes: #6
      4a0f41d5
    • Ondrej Holy's avatar
      smb: Do not claim that mountable can be unmounted · 9299ed26
      Ondrej Holy authored
      G_FILE_ATTRIBUTE_MOUNTABLE_CAN_UNMOUNT is set to TRUE, but unmount_mountable()
      is not implemented. Set the attribute always to FALSE in order to prevent
      errors from g_file_unmount_mountable_with_operation().
      
      Nautilus should seamleassly use	g_mount_unmount_with_operation() if the
      attribute is set to FALSE.
      
      Closes: #15
      9299ed26
    • Ondrej Holy's avatar
      afp: Do not claim that mountable can be unmounted · 957d9821
      Ondrej Holy authored
      G_FILE_ATTRIBUTE_MOUNTABLE_CAN_UNMOUNT is set to TRUE, but unmount_mountable()
      is not implemented. Set the attribute always to FALSE in order to prevent
      errors from g_file_unmount_mountable_with_operation().
      
      Nautilus should seamleassly use g_mount_unmount_with_operation() if the
      attribute is set to FALSE.
      
      #15
      957d9821
  4. May 28, 2018
  5. May 14, 2018
  6. May 07, 2018
  7. Apr 13, 2018
    • Ondrej Holy's avatar
      udisks2: Remove optical disc volumes/mounts if drive disappears · 56ef3c56
      Ondrej Holy authored
      If an optical drive is hard-unplugged without ejecting a media first (or
      the corresponding UDisksDrive object simply disappears from D-Bus for
      example due to the udisksd termination) and an audio disk or an empty
      media is inside, corresponding volumes/mounts are not properly removed.
      Consequently, the number of the volumes/mounts increase when plugging
      and unplugging such drive. This happens because those kinds of volumes/
      mounts are handled by their drives in the monitor. Unfortunately, the
      drive is removed before processing them and the mounts/volumes without
      the drives are ignored consequently.
      
      Let's do not rely on the drives and handle those volumes/mounts over
      corresponding UDisksBlock objects, same as it is done for other kinds of
      volumes.
      
      https://bugzilla.gnome.org/show_bug.cgi?id=719423
      56ef3c56
    • Ondrej Holy's avatar
      daemon: Prevent deadlock and invalid read when closing channels · 1b591b50
      Ondrej Holy authored
      Commit e147e48f added missing mutex guards for job_sources, which may
      unfortunately lead to deadlock because g_vfs_channel_force_close
      synchronously calls g_vfs_job_source_closed which is also guarded by
      the same mutex.
      
      The deadlock reveals another bug which was in that code. The code
      iterates over job_sources list, but g_vfs_job_source_closed removes
      current element of the list, which leads to invalid reads and
      potentially to segfaults also.
      
      This patch tries to fix the both mentioned issues.
      
      https://bugzilla.gnome.org/show_bug.cgi?id=794957
      1b591b50
    • Ondrej Holy's avatar
      metadata: Prevent usage of NULL if GUdevDevice is not found · e4933073
      Ondrej Holy authored
      Code to determine tree name from device has been recently ported from
      udev to gudev by commit c2d85644. Unfortunately, the gudev code floods
      logs by the following messages if device is not found (it can happen
      e.g. for tmpfs):
      g_udev_device_has_property: assertion 'G_UDEV_IS_DEVICE (device)' failed
      
      Udev code silently returned if NULL device was used, however, corresponding
      gudev code prints the mentioned messages. Let's prevent usage of NULL
      device in order to prevent those messages.
      
      https://bugzilla.gnome.org/show_bug.cgi?id=795191
      e4933073
  8. Apr 10, 2018
  9. Apr 09, 2018
  10. Mar 21, 2018
  11. Mar 15, 2018
  12. Mar 13, 2018
  13. Mar 12, 2018
  14. Mar 11, 2018
  15. Mar 10, 2018
  16. Mar 07, 2018
  17. Mar 06, 2018
  18. Mar 05, 2018
  19. Mar 03, 2018
  20. Mar 01, 2018
  21. Feb 28, 2018