- Nov 17, 2017
-
-
Carlos Garnacho authored
These end up emitting item-drag-end/window-drag-end pretty much without checks. Given the MetaDnd object may end up emitting ::drag-leave as a result of the plugin ending its grab, this would result on spurious emission of those events and subsequent warnings. For extra paranoia, the _inDrag variable has been split into _inItemDrag/_inWindowDrag so we can't cross the streams. https://bugzilla.gnome.org/show_bug.cgi?id=784545
-
- Oct 25, 2017
-
-
- Oct 21, 2017
-
-
Tong Hui authored
-
- Aug 07, 2017
-
-
Matej Urbančič authored
-
- Aug 03, 2017
-
-
Carlos Garnacho authored
Ring leader/label SVG elements for the second ring are named *Ring2*. We need to add one here for elements >1, this is consistent with strips. https://bugzilla.gnome.org/show_bug.cgi?id=785358
-
- Jul 19, 2017
-
-
Florian Müllner authored
Update NEWS.
-
- Jul 17, 2017
-
-
Carlos Garnacho authored
It does not make sense to map those actions to non-buttons. Set the actions insensitive in the combobox to disallow this from the UI. https://bugzilla.gnome.org/show_bug.cgi?id=782033
-
Carlos Garnacho authored
Customization of keycombo actions for strips/rings was lost in the porting to new incarnation of Wacom support. The UI here is slightly different, instead of requiring the user to rotate/swipe in each direction to map each keycombo, the UI will navigate the user through edition of both options, first one, then the other. https://bugzilla.gnome.org/show_bug.cgi?id=782033
-
- Jul 14, 2017
-
-
Carlos Garnacho authored
If the padOsd is given a nonexistent ring/strip, things would fail badly later when trying to paint a 0x0 StLabel. Just avoid creating more ring/strip labels than those known by libwacom. This is unlikely to happen, but seems better to protect against it. https://bugzilla.gnome.org/show_bug.cgi?id=782033
-
-
- Jul 13, 2017
-
-
Florian Müllner authored
Don't rely on an implicit undefined value of unset parameters to shut up some warnings. https://bugzilla.gnome.org/show_bug.cgi?id=781471
-
Florian Müllner authored
PopupMenu needs special-treatment of certain types of menu items, which it determines via children's _delegate property. However as the calendar drop-down is very unmenu-ish, we use regular actors rather than PopupMenuItems and the missing _delegate property triggers a warning. Just add it as the bare minimum to make PopupMenu happy. https://bugzilla.gnome.org/show_bug.cgi?id=781471
-
Florian Müllner authored
Avoid a warning when assigning from an undefined property by making sure to pass a proper null value instead. https://bugzilla.gnome.org/show_bug.cgi?id=781471
-
Florian Müllner authored
Don't call a parent method before chaining-up _init() to avoid a warning about access to an undefined property. https://bugzilla.gnome.org/show_bug.cgi?id=781471
-
Florian Müllner authored
The destroy effect currently relies on a monkey-patched property added from the map effect. However on X11 it is possible that we did no map animation for a window that is destroyed when the shell was restarted or had taken over from another WM. Just use the real MetaWindow property to avoid a warning in that case. https://bugzilla.gnome.org/show_bug.cgi?id=781471
-
Florian Müllner authored
It's possible for updateRegions() to be called before monitors have been properly initialized. Instead of throwing an error in that case, just skip the strut computation (that doesn't make sense anyway without a monitor). https://bugzilla.gnome.org/show_bug.cgi?id=781471
-
Florian Müllner authored
findMonitorForActor() may be called before the layoutManager gets to initialize monitors, so make sure the monitor index is in range to avoid a warning. https://bugzilla.gnome.org/show_bug.cgi?id=781471
-
Florian Müllner authored
Don't try to access a non-existent engine - it probably makes sense to use Map() instead of a plain object to track engines in the future, but for now just add an additional check to shut up a warning. https://bugzilla.gnome.org/show_bug.cgi?id=781471
-
Florian Müllner authored
We only use lastItem() to reset the history index to the end, so nobody noticed the utter nonsense in the return value until gjs started to warn about it. As we don't actually use the value anywhere, we could just remove it, but the function name implies that an item is returned, so fix it to behave as advertised. https://bugzilla.gnome.org/show_bug.cgi?id=781471
-
Florian Müllner authored
We need to track the open-status of indicator menus, but don't want to hook up signals more than once, so we check for the handler ID we store on the object. As the property is only defined once we did set up the signal connection, this check now logs a warning. We can avoid it by checking for the existence of the property rather than a particular value. https://bugzilla.gnome.org/show_bug.cgi?id=781471
-
Florian Müllner authored
To avoid recreating the app menu unnecessarily, the panel checks whether the menu's current actionGroup already matches the target one. However as the menu's actionGroup property is currently private, the test always fails, whoops. https://bugzilla.gnome.org/show_bug.cgi?id=781471
-
Florian Müllner authored
We currently use "array[index]" to test whether an array has an element at index before using it. However nowadays gjs warns about accessing non-existent array elements, so the test itself already produces a warning. Avoid this by checking the array length before using an index to access an element. https://bugzilla.gnome.org/show_bug.cgi?id=781471
-
Florian Müllner authored
Make sure we pass a proper false value instead of undefined to avoid warnings. https://bugzilla.gnome.org/show_bug.cgi?id=781471
-
Florian Müllner authored
While we've always considered it good style to initialize JS properties, some code that relies on uninitialized properties having an implicit value of 'undefined' has slipped in over time. The updated SpiderMonkey version used by gjs now warns when accessing those properties, so we should make sure that they are properly initialized to avoid log spam, even though all warnings addressed here occur in conditionals that produce the correct result with 'undefined'. https://bugzilla.gnome.org/show_bug.cgi?id=781471
-
Florian Müllner authored
Since commit 2c070d38, we add a ClickAction to the visible AltSwitcher button to track long-presses. As a result, we now have two components that will grab and ungrab the pointer for the button, so to make sure we don't end up with a stuck grab, we need to release the second's component grab when the first activates. Currently we only drop the StButton grab on long-press, we also need to cancel any initiated long-press on click. https://bugzilla.gnome.org/show_bug.cgi?id=781738
-
- Jul 10, 2017
-
-
Jeremy Bicha authored
-
- Jul 05, 2017
-
-
Florian Müllner authored
The gtk-dialog-* names are old and non-standard, and haven't been provided by the default icon theme for quite a while ... https://bugzilla.gnome.org/show_bug.cgi?id=784245
-
Florian Müllner authored
Even though the API documentation doesn't say so, the underlying Cogl texture of a ClutterTexture may be unset, so check for that case to avoid a runtime warning. https://bugzilla.gnome.org/show_bug.cgi?id=784353
-
Florian Müllner authored
While the string returned by formatTime() should follow the locale's text direction as a whole, the actual time part is always expected to put hours on the left and minutes to the right. It is possible to enforce that by inserting a left-to-right mark, but so far this is only done by the Hebrew translation. So in order to not require all other RTL translations to be fixed individually, just insert the mark into the returned string ourselves like gnome-desktop's WallClock code does[0]. [0] https://git.gnome.org/browse/gnome-desktop/tree/libgnome-desktop/gnome-wall-clock.c?h=gnome-3-24#n267 https://bugzilla.gnome.org/show_bug.cgi?id=784130
-
- Jun 02, 2017
-
-
Gjs-Message: JS WARNING: [resource:///org/gnome/shell/portalHelper/main.js 360]: reference to undefined property top.uri is caused by the URI variable actually being called "url". https://bugzilla.gnome.org/show_bug.cgi?id=783286
-
When using an SSH tunnel (through a SOCKS proxy) to funnel all the outgoing traffic, we need the captive portal to not go through that proxy, otherwise we can't go through the proxy because we're not connected to the Internet and we can't go through the portal because we're not connected through the proxy. This fixes a blank captive portal window and no error reporting in that particular configuration. https://bugzilla.gnome.org/show_bug.cgi?id=769692
-
- May 20, 2017
-
-
- May 19, 2017
-
-
- May 18, 2017
-
-
- May 11, 2017
-
-
Florian Müllner authored
Update NEWS.
-
Florian Müllner authored
-
Florian Müllner authored
GJS now warns about excess parameters, so wrap the queue_relayout() into an anonymous function instead of using it directly as signal handler.