- Mar 16, 2024
-
-
Carlos Garnacho authored
-
- Mar 14, 2024
-
-
Philip Withnall authored
It’s been deprecated in GLib 2.68 in favour of `g_memdup2()`, which uses correct argument types so as not to silently cause an overflow during an implicit integer size conversion. The existing code was safe and correct: this commit just fixes the deprecation warning. Signed-off-by: Philip Withnall <pwithnall@gnome.org>
-
Philip Withnall authored
`g_spawn_check_exit_status()` operates on a *wait status* rather than an *exit status*. A wait status is what’s returned by `waitpid()`, and it’s a platform-specific combination of bits indicating whether the program exited gracefully, or crashed/signaled, and what value it returned from `main()` (if any). An exit status is the value returned from `main()` (so, zero for a successfully-exiting application). `g_spawn_check_exit_status()` has been deprecated since GLib 2.70 because of its confusing naming. `g_subprocess_get_exit_status()` returns an exit status (so is named correctly), but we don’t actually have to use it because `GSubprocess` already provides an API which combines `g_subprocess_wait_async()` and `g_spawn_check_wait_status()`: `g_subprocess_wait_check_async()`. So just use that instead. It’s been available since GLib 2.40. Signed-off-by: Philip Withnall <pwithnall@gnome.org>
-
Philip Withnall authored
`g_time_zone_new()` was deprecated in GLib 2.68 because its error handling behaviour was poorly defined. `g_time_zone_new_identifier()` is equivalent but with better-defined error handling. Use that. Since the timezone identifier in the `datetime` plugin notification is coming from a system component, I assume it’s going to exist, hence the use of `g_warning()` for error handling rather than anything more involved. Signed-off-by: Philip Withnall <pwithnall@gnome.org>
-
Philip Withnall authored
Use `GDateTime` instead of `GTimeVal`. This requires bumping the GLib dependency to 2.70 so we can use some `GFileInfo` convenience functions (the same changes would be possible, but more complex, without bumping the dependency). Debian Stable is currently shipping GLib 2.74, so 2.70 should be widely available. This makes the housekeeping code Y2038-safe. Signed-off-by: Philip Withnall <pwithnall@gnome.org>
-
Philip Withnall authored
It’s needed for `g_warning_once()`, as used in the media-keys plugin since January 2023. Debian Stable currently ships GLib 2.74, so 2.64 should be very widely available by now. This fixes the following compiler warnings: ``` ../../source/gnome-settings-daemon/plugins/media-keys/gsd-media-keys-manager.c: In function ‘do_config_power_button_action’: ../../source/gnome-settings-daemon/plugins/media-keys/gsd-media-keys-manager.c:2047:13: error: Not available before 2.64 [-Werror] 2047 | g_warning_once ("Virtual machines only honor the 'nothing' power-button-action, and will shutdown otherwise"); | ^ ~~~~~~~~~~~~~~~~~~~~~~~ ../../source/gnome-settings-daemon/plugins/media-keys/gsd-media-keys-manager.c:2067:13: error: Not available before 2.60 [-Werror] 2067 | G_GNUC_FALLTHROUGH; | ^ ~~~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors ``` Signed-off-by: Philip Withnall <pwithnall@gnome.org>
-
Philip Withnall authored
These were deprecated in Meson 0.56 in favour of replacements which allow differentiating between the current project and the parent project when being used as a subproject. Signed-off-by: Philip Withnall <pwithnall@gnome.org>
-
Philip Withnall authored
Using `dep.get_pkgconfig_variable()` has been deprecated since Meson 0.56, but gnome-settings-daemon depends on 0.57. Signed-off-by: Philip Withnall <pwithnall@gnome.org>
-
- Mar 12, 2024
-
-
Pablo Correa Gomez authored
This is a small simplification, and allows to build against elogind without patches
-
- Mar 04, 2024
-
-
Carlos Garnacho authored
-
- Mar 03, 2024
-
-
- Mar 01, 2024
-
-
- Feb 28, 2024
-
-
for show-status-shapes Fixes: #778
-
-
- Feb 25, 2024
-
-
- Feb 24, 2024
-
-
- Feb 19, 2024
-
-
Ray Strode authored
Since landing the p11-kit port we stopped treating removed cards as login cards, and thus neglected to send removal events. This commit fixes that.
-
-
-
- Feb 13, 2024
-
-
Carlos Garnacho authored
-
- Feb 10, 2024
-
-
- Jan 14, 2024
-
-
GTK will use it to decide whether switches should include shapes to indicate their ON/OFF state in addition to color. gnome-control-center#2675
-
Carlos Garnacho authored
Start the dconf service after starting D-Bus, and ignore the SIGTERM indirectly received when terminating the dedicated D-Bus service. Fixes tests/CI with recent python3-dbusmock present in F39.
-
- Jan 13, 2024
-
-
Carlos Garnacho authored
After the update to F39, we can use gcr4 to build smartcard support.
-
Carlos Garnacho authored
-
- Jan 08, 2024
-
-
Ray Strode authored
-
Currently, GNOME settings daemon displays a notification warning the user before the sleeping the device. This is generally a very useful feature. However, with the adoption of new platforms in GNOME like phones and tablets, this can be a problem. In such devices, the desired behavior is to sleep as soon as possible and by default. Therefore, having a notification pop-up (which can potentially trigger some other haptic feedback like a LED) just because the device is doing what it is supposed to do (go to sleep) can be problematic. Discussion in a previous MR indicated that using the system's chassis type was a preferred option for deciding this behaviour. This commit builds upon the work by Pablo Correa Gomez in !285 to provide the same outcome using the chassis type value. Closes #656
-
- Jan 06, 2024
-
-
- Dec 22, 2023
-
-
Ray Strode authored
It's useful to wait a bit before killing an assigned service when the associated system service goes away. This avoids having to tear down the user service if the system service is just getting restarted. This commit adds a 10 second countdown before slaying the user service when it's system service counterpart goes down.
-
Ray Strode authored
In order to provide a login screen over gnome-remote-desktop, their needs to be both system and session instance of gnome-remote-desktop. The latter should get run if the former is running, and not otherwise. This commit adds a mechanism for doing this by introducing the concept of "assigned services" (versus the already existing configurable services). Assigned services don't start based on GSettings configuration, but instead just start if an associated system service is running.
-
Ray Strode authored
We're going to have "assigned" services soon that are delegated from systemd system services. In order to avoid ambiguity, this commit prepares for that, by renaming the existing `services` variable to `configurable_services`
-
Ray Strode authored
This is just refactoring clean up in prep for future changes.
-
Ray Strode authored
A future commit is going to introduce a different type of service, and that commit will need to be able to start and stop services too. This commit prepares for that by making the APIs for managing services take service names instead of ServiceInfo instances.
-
Ray Strode authored
-
The bug pertains to searching for rules with a label. When the USB protection component starts, it checks whether a "allow all" rule is present and in case no such rule is found, it adds "allow all" with a custom label. When searching for the rule, we could add our label but it does not matter for the functionality where the rule comes from. Especially because we neither change nor delete the rule.
-
- Nov 20, 2023
-
-
Bastien Nocera authored
In function ‘do_lid_closed_action’, inlined from ‘logind_proxy_changed_cb’ at plugins/power/gsd-power-manager.c:1579:17: plugins/power/gsd-power-manager.c:1538:20: warning: ‘is_inhibited’ may be used uninitialized [-Wmaybe-uninitialized] 1538 | if (is_inhibited) { | ^ plugins/power/gsd-power-manager.c: In function ‘logind_proxy_changed_cb’: plugins/power/gsd-power-manager.c:1533:26: note: ‘is_inhibited’ was declared here 1533 | gboolean is_inhibited; | ^~~~~~~~~~~~ plugins/power/gsd-power-manager.c: In function ‘idle_configure’: plugins/power/gsd-power-manager.c:1977:12: warning: ‘is_inhibited’ may be used uninitialized [-Wmaybe-uninitialized] 1977 | if (!is_action_inhibited (manager, action_type)) { | ^ plugins/power/gsd-power-manager.c:1354:18: note: ‘is_inhibited’ was declared here 1354 | gboolean is_inhibited; | ^~~~~~~~~~~~
-
Bastien Nocera authored
[1/2] Compiling C object plugins/power/gsd-power.p/gsd-power-manager.c.o plugins/power/gsd-power-manager.c:1872:1: warning: conflicting types for ‘idle_is_session_inhibited’ due to enum/integer mismatch; have ‘gboolean(GsdPowerManager *, GsmInhibitorFlag, gboolean *)’ {aka ‘int(struct _GsdPowerManager *, GsmInhibitorFlag, int *)’} [-Wenum-int-mismatch] 1872 | idle_is_session_inhibited (GsdPowerManager *manager, | ^~~~~~~~~~~~~~~~~~~~~~~~~ plugins/power/gsd-power-manager.c:237:18: note: previous declaration of ‘idle_is_session_inhibited’ with type ‘gboolean(GsdPowerManager *, guint, gboolean *)’ {aka ‘int(struct _GsdPowerManager *, unsigned int, int *)’} 237 | static gboolean idle_is_session_inhibited (GsdPowerManager *manager, guint mask, gboolean *is_inhibited); | ^~~~~~~~~~~~~~~~~~~~~~~~~
-
- Nov 12, 2023
-
-