- Oct 10, 2016
-
-
- Oct 08, 2016
-
-
Bastien Nocera authored
We get called for every removed GDK device, so check whether it's of interest early, instead after throwing a bunch of warnings. gsd-wacom[1884]: g_signal_handlers_disconnect_matched: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed gsd-wacom[1884]: gsd_wacom_device_get_device_type: assertion 'GSD_IS_WACOM_DEVICE (device)' failed gsd-wacom[1884]: gsd_wacom_device_get_settings: assertion 'GSD_IS_WACOM_DEVICE (device)' failed gsd-wacom[1884]: invalid (NULL) pointer instance https://bugzilla.gnome.org/show_bug.cgi?id=772581
-
Bastien Nocera authored
We have 2 checks for the same thing within a couple of lines. Merge those. https://bugzilla.gnome.org/show_bug.cgi?id=772581
-
- Aug 22, 2016
-
-
Several small leaks exist were found and fixed in the wacom plugin after running valgrind.
-
Most of the wacom plugin code protects X11 calls with gdk_error_trap_push/pop and prints a warning if something fails. There were two calls that were not protected, however, and one use of g_error instead of g_warning that would cause the g-s-d process to die if e.g. the tablet disappears while g-s-d is trying to work on it. https://bugzilla.gnome.org/show_bug.cgi?id=765996
-
- Mar 26, 2016
-
-
Dingzhong Chen (FeralMeow) authored
-
- Mar 18, 2016
-
-
Debarshi Ray authored
-
- Jan 05, 2016
-
-
Bastien Nocera authored
This fixes problems when the system has a platform rfkill device for Bluetooth and the Bluetooth adapter's rfkill support somehow got blocked. https://bugzilla.gnome.org/show_bug.cgi?id=741675
-
Bastien Nocera authored
Add helper to re-send an enablement event after it's been sent once to make sure that unblocking a Bluetooth platform rfkill will also unblock the Bluetooth adapter that might appear.
-
Bastien Nocera authored
-
Bastien Nocera authored
-
Bastien Nocera authored
-
Bastien Nocera authored
-
- Nov 13, 2015
-
-
Carlos Garnacho authored
-
- Nov 03, 2015
-
-
Carlos Garnacho authored
Otherwise the mapping may come out wrong if during the initialization paths it first applies keep-aspect, and later maps to a single monitor. https://bugzilla.gnome.org/show_bug.cgi?id=753680
-
- Nov 02, 2015
-
-
Carlos Garnacho authored
When devices are plugged, we may end up emitting GsdDeviceManager::device-added at a time when not all GdkDevices have been attached to the GsdDevice, this makes these devices occasionally not being applied the right keep-aspect/area settings. Add a GsdDeviceManager::device-changed signal, emitted for the GsdDevice for those situations, so the late-added devices are ensured to be updated. https://bugzilla.gnome.org/show_bug.cgi?id=753589
-
Carlos Garnacho authored
With the introduction of GsDeviceMapper (commit 0810de0f), left-handed mode became responsibility of this object, which was applied by applying an extra rotation to the device coordinate matrix. Later, the device coordinate matrix handling was lifted to mutter, although the rotation setting was kept in the g-s-d side of the settings split, so GsdDeviceMapper would listen to the wrong settings, and left-handed mode became no mans land. Put the application of this setting back into GsdWacomManager, again translated to the "Wacom Rotation" device property. Nonetheless, all settings should move eventually to mutter domain, and this turned again into modifications to the coordinate matrix. https://bugzilla.gnome.org/show_bug.cgi?id=749767
-
Carlos Garnacho authored
The device array returned must be freed.
-
- Oct 22, 2015
-
-
Sébastien Bacher authored
Disconnect the signal from plugin_settings when unloading the plugin so it's not called after the plugin has been freed. https://bugzilla.gnome.org/show_bug.cgi?id=756958
-
- Sep 23, 2015
-
-
The GSettings callback wasn't calling Xft when the cursor size configuration changed. https://bugzilla.gnome.org/show_bug.cgi?id=755431
-
- Sep 04, 2015
-
-
- Sep 03, 2015
-
-
- Aug 03, 2015
-
-
Carlos Garnacho authored
According to GSettings docs, one must read after connecting to changed:: in order to ensure the handler will trigger in the future. https://bugzilla.gnome.org/show_bug.cgi?id=753170
-
Carlos Garnacho authored
According to GSettings docs, one must read after connecting to changed:: in order to ensure the handler will trigger in the future. https://bugzilla.gnome.org/show_bug.cgi?id=753170
-
Carlos Garnacho authored
According to GSettings docs, one must read after connecting to changed:: in order to ensure the handler will trigger in the future. https://bugzilla.gnome.org/show_bug.cgi?id=753170
-
- Jul 28, 2015
-
-
- Jul 21, 2015
- Jul 02, 2015
-
-
Rui Matos authored
No functional changes, this just makes it explicit that these functions only work on devices driven by the X synaptics driver. https://bugzilla.gnome.org/show_bug.cgi?id=749818
-
Rui Matos authored
As a side effect we can now run this on wayland sessions too. https://bugzilla.gnome.org/show_bug.cgi?id=749818
-
Rui Matos authored
Using GsdDeviceManager allows our device type presence checks work both on libinput using X sessions and on Wayland sessions. At the same time we still need to support systems using the synaptics X driver so let's make that an explicit separate check. https://bugzilla.gnome.org/show_bug.cgi?id=749818
-
- Jun 04, 2015
-
-
Bastien Nocera authored
From coverity: gnome-settings-daemon-3.14.4/plugins/power/gpm-common.c:321:52: warning: Access to field 'message' results in a dereference of a null pointer (loaded from variable 'error') https://bugzilla.gnome.org/show_bug.cgi?id=749882
-
Bastien Nocera authored
From coverity: gnome-settings-daemon-3.14.4/plugins/wacom/gsd-wacom-led-helper.c:130: double_free: Calling "g_free" frees pointer "status" which has already been freed. https://bugzilla.gnome.org/show_bug.cgi?id=749882
-
Bastien Nocera authored
We can't free "", buffer needs to be set by the command-line options, but we never check that it got set. From coverity: gnome-settings-daemon-3.14.4/plugins/wacom/gsd-wacom-oled-helper.c:415: incorrect_free: "g_free" frees incorrect pointer "buffer". https://bugzilla.gnome.org/show_bug.cgi?id=749882
-
- Jun 02, 2015
-
-
Carlos Garnacho authored
We used to attempt to reconstruct the ['','',''] default, although this failed on NULL outputs as we tried to feed NULLs into "as" variants/settings. Fix this by just resetting the key when the device gets a NULL output, we can also make the other path clearer as we can't get NULLs in edid[] as we previously might. Based on a patch by Alexandre Rostovtsev <tetromino@gentoo.org> https://bugzilla.gnome.org/show_bug.cgi?id=749844
-
- May 21, 2015
-
-
- May 20, 2015
-
-
Marek Kašík authored
Blacklist 'cups-waiting-for-job-completed' job state reason which is rather an internal flag for CUPS. https://bugzilla.redhat.com/show_bug.cgi?id=1207154
-
- May 19, 2015
-
-
Rui Matos authored
If atoi() returns a negative value this will be interpreted as an error but the GError wouldn't be set which would crash us when printing an error message. See https://bugzilla.redhat.com/show_bug.cgi?id=1222007 https://bugzilla.gnome.org/show_bug.cgi?id=749440
-
- May 12, 2015
-
-
Rui Matos authored
-
Rui Matos authored
Doing so causes pkexec to fail[0] if the current user's SHELL doesn't exist in /etc/shells which happens for the gdm user in some distributions. Since we don't need this environment variable in the helper we can work around that by just unsetting it. [0] http://cgit.freedesktop.org/polkit/commit/?id=5a388b6ebb095de6dc7f315b651a84fc31d268d7 https://bugzilla.gnome.org/show_bug.cgi?id=748804
-
Rui Matos authored
We'll need to change the environment that we pass on to the helper and this will make it easier. https://bugzilla.gnome.org/show_bug.cgi?id=748804
-