Skip to content
  1. May 01, 2024
  2. Apr 29, 2024
  3. Apr 24, 2024
  4. Apr 23, 2024
    • Will Thompson's avatar
      copy-worker: Run later, but before gnome-keyring-daemon · 966cd032
      Will Thompson authored
      In gnome-build-meta#821 we saw that running so early, with
      DefaultDependencies=no, causes issues when GVFS (via GFile) tries to use
      D-Bus.
      
      !249 configured GIO to use only the local VFS,
      but still, there is no need to run quite so early: the key thing is to
      copy the user's keyring before the keyring daemon.
      
      Adjust the unit to attach to default.target (not basic.target),
      reinstate default dependencies, and explicitly run Before
      gnome-keyring-daemon.service.
      
      See !249 for further discussion.
      
      Part-of: <!250>
      966cd032
  5. Apr 22, 2024
  6. Apr 19, 2024
  7. Apr 18, 2024
  8. Apr 17, 2024
    • Adam Williamson's avatar
      Fully suppress header onwards buttons if page has its own · b70eaebd
      Adam Williamson authored
      This code was added in 69914dde
      
       but is not currently used. It is
      intended to be used in future by pages which manage their own
      'onwards' button. It seems incomplete - it only changes the
      state of one of the three possible header buttons, and only its
      visibility, not its sensitivity. It seems safer to ensure all
      three possible header buttons are not visible and not sensitive.
      We can conveniently do this by sending `set_navigation_button`
      a widget which is none of the three buttons.
      
      Signed-off-by: default avatarAdam Williamson <awilliam@redhat.com>
      b70eaebd
    • Adam Williamson's avatar
      Be more consistent about setting state of 'onwards' buttons (#199) · c8d8d695
      Adam Williamson authored
      Make `update_navigation_buttons`'s behaviour more consistent and
      clearer by always explicitly setting both the visibility and
      sensitivity of all three possible buttons (forward, accept, and
      skip).
      
      In the current code, the logic is:
      
      * If the page is complete, set the next widget sensitive and
      visible; set the other two buttons not visible, but do not change
      their sensitivity
      * Otherwise, if the page is skippable, set the skip button visible
      and the other two buttons not visible, do not change any button's
      sensitivity
      * Otherwise, set the next widget visible but not sensitive; set
      the other two buttons not visible, but do not change their
      sensitivity
      
      This seems pretty inconsistent, and causes a clear bug, #199.
      @lnicola proposes !246 to fix #199
      
      . It changes the second
      behaviour in the list to:
      
      * Otherwise, if the page is skippable, set the skip button
      visible and the other two buttons not visible, and set the next
      widget as not sensitive
      
      which addresses the immediate bug, but overall, I still feel like
      the logic here is pretty inconsistent. To me it feels clearer and
      overall safer to always touch both the visibility and sensitivity
      of all three buttons, in a way that is (hopefully) consistent
      with their intended state:
      
      * If the page is complete, set the next widget visible and
      sensitive; set both other buttons not visible and not sensitive
      * Otherwise, if the page is skippable, set the skip button
      visible and sensitive; set both other buttons not visible and
      not sensitive
      * Otherwise, set the next widget visible but not sensitive; set
      both other buttons not visible and not sensitive
      
      Signed-off-by: default avatarAdam Williamson <awilliam@redhat.com>
      c8d8d695
  9. Apr 12, 2024
  10. Apr 09, 2024
  11. Mar 29, 2024
  12. Mar 27, 2024
  13. Mar 20, 2024
  14. Mar 19, 2024
  15. Mar 18, 2024
  16. Mar 16, 2024
  17. Mar 13, 2024
  18. Mar 12, 2024
  19. Mar 11, 2024
  20. Mar 08, 2024
  21. Mar 06, 2024