Mohammed Sadiq authored Jun 16, 2017 and Bastien Nocera committed Aug 22, 2017

https://bugzilla.gnome.org/show_bug.cgi?id=783849

Jason Crain authored Jul 24, 2017 and Rui Matos committed Jul 25, 2017

Debian's gnome-control-center can crash when show-all-sources is
enabled.  When parse_end_element in gnome-xkb-info.c encounters
duplicate layouts, it will free the memory for the first layout while it
is still in a hash table.

https://bugzilla.gnome.org/show_bug.cgi?id=785320

The pixbuf to be written as a placeholder thumbnail was never
initialised to be empty, so might contain random data from the stack.
Use gdk_pixbuf_fill() to solve this problem.

Use of uninitialised value of size 8
   at 0x9A8ED44: crc32_little (crc32.c:287)
   by 0x9A8ED44: crc32_z (crc32.c:220)
   by 0x8A617FB: png_calculate_crc (png.c:153)
   by 0x8A7FACF: png_write_complete_chunk (pngwutil.c:187)
   by 0x8A801B1: png_compress_IDAT (pngwutil.c:1047)
   by 0x8A81F8E: png_write_filtered_row (pngwutil.c:2743)
   by 0x8A81F8E: png_write_find_filter (pngwutil.c:2713)
   by 0x8A7CF21: png_write_row (pngwrite.c:888)
   by 0x8A7D20E: png_write_rows (pngwrite.c:582)
   by 0x8263A08: real_save_png (io-png.c:1139)
   by 0x8263B0A: gdk_pixbuf__png_image_save (io-png.c:1166)
   by 0x8250FF8: gdk_pixbuf_real_save (gdk-pixbuf-io.c:2180)
   by 0x8251820: gdk_pixbuf_savev (gdk-pixbuf-io.c:2479)
   by 0x8251534: gdk_pixbuf_save (gdk-pixbuf-io.c:2418)
   by 0x5342324: save_thumbnail (gnome-desktop-thumbnail.c:1224)
   by 0x53424DD: gnome_desktop_thumbnail_factory_create_failed_thumbnail (gnome-desktop-thumbnail.c:1313)
   by 0x4E89B6A: eog_thumbnail_load (eog-thumbnail.c:518)
   by 0x4E6BA39: eog_job_thumbnail_run (eog-jobs.c:1270)
   by 0x4E69796: eog_job_run (eog-jobs.c:271)
   by 0x4E689A2: eog_job_process (eog-job-scheduler.c:153)
   by 0x4E688AA: eog_job_scheduler (eog-job-scheduler.c:128)
   by 0x97E4004: g_thread_proxy (gthread.c:784)
   by 0x9CAA36C: start_thread (in /usr/lib64/libpthread-2.25.so)
   by 0x9FD2E9E: clone (in /usr/lib64/libc-2.25.so)
Uninitialised value was created by a stack allocation
   at 0x8262D5E: real_save_png (io-png.c:871)

https://bugzilla.gnome.org/show_bug.cgi?id=784915

As scaling down by huge factors is now fixed in gdk-pixbuf. Require the
newer gdk-pixbuf as well, to avoid running into a pre-fix version.

https://bugzilla.gnome.org/show_bug.cgi?id=775991

Peng Wu authored Dec 19, 2016 and Rui Matos committed Jan 19, 2017

https://bugzilla.redhat.com/show_bug.cgi?id=1405946

https://bugzilla.gnome.org/show_bug.cgi?id=772674

If a preview exists for a particular file, in particular a preview icon
for videos and images on external devices, prefer those to running a
script.

https://bugzilla.gnome.org/show_bug.cgi?id=738503

https://bugzilla.gnome.org/show_bug.cgi?id=768064

Instead of special-casing gdk-pixbuf-supported image formats, use an
external thumbnailer. This will give us the ability to:
- cancel running thumbnail operations
- avoid memory leaks, buffer overflows, double-frees, etc. in the
  image loaders having an impact on the application
- limit resource usage when thumbnailing

https://bugzilla.gnome.org/show_bug.cgi?id=768064

Hyungwon Hwang authored Sep 01, 2016 and Bastien Nocera committed Sep 05, 2016

gnome_pnp_ids_get_pnp_id() should always return a dynamically allocated
string as its API.

https://bugzilla.gnome.org/show_bug.cgi?id=770686

Future versions of gettext will fail if this header is missing.

The function doesn't return anything, so there's no return value to
document.

This will allow building gnome-desktop in environments where libudev
isn't available (such as flatpak's Sdk) until we have a thumbnailing API
living in the platform API (likely GLib or GTK+).

Those dependencies are now lower down the stack in mutter. We call out
to mutter over D-Bus so as to avoid direct dependencies on X11 or
Wayland.

hwdb has its own database which it compiles to binary, so that:
1) initialisation is practically free
See https://git.gnome.org/browse/gnome-settings-daemon/commit/gnome-settings-daemon/gnome-settings-manager.c?id=d8c158e74caea048dea5a38232bd87c1c7a78a70
2) lookups are also quick, as they use a binary DB
3) we don't have to maintain our own copy of the database
4) allows model lookup rather than simply vendor lookup, when the
   database contains that information

The only problem being that non-Linux OSes will need reimplement this
section of the code. This will be on top of the usual downstream patches
they ship for a number of components.

https://bugzilla.gnome.org/show_bug.cgi?id=590059