Felipe Borges authored Apr 25, 2022 and Georges Basile Stavracas Neto committed Apr 26, 2022

While searching in the Shell, users might input the keywords "Hot
Corner" and "Workspaces".

Fixes #1784

Michael Catanzaro authored Apr 26, 2022 and Georges Basile Stavracas Neto committed Apr 26, 2022

You're welcome, internet.

Mainline is open for business again

Marco Trevisan authored Jan 31, 2022 and Georges Basile Stavracas Neto committed Apr 24, 2022

Weak references are added when logical monitors are created, however we
don't remove them when destroying the display.

This means that if a monitor survives to the display finalization
(because may be referenced elsewhere) it will make g-c-c to crash
during its finalization, as that will trigger the weak reference
callback that will try to access to the already-finalized display.

Hu Jialun authored Mar 28, 2022 and Georges Basile Stavracas Neto committed Apr 24, 2022

getlogin() can fail for several reasons as detailed in the man page, and
the current behaviour is a segmentation fault when it fails with NULL,
such as due to an unset loginuid.

* Check return value for error and act accordingly.
* Change to getpwuid(getuid())->pw_name, which is less likely to error.

Jeremy Bicha authored Apr 20, 2022 and Georges Basile Stavracas Neto committed Apr 24, 2022

Previously, we were only checking if the gnome-remote-desktop
user service was running but that service is always running
as of
gnome-remote-desktop@7f4ef31f

We need to check the gsettings key too.

Closes: #1775

Felipe Borges authored Apr 21, 2022 and Georges Basile Stavracas Neto committed Apr 24, 2022

Fixes #1777

Felipe Borges authored Apr 22, 2022 and Georges Basile Stavracas Neto committed Apr 22, 2022

Instead of using a plain "flat" button positioned at the window corner,
let's use GtkWindowControls to wrap the close button and get the
default window control styling and alignment.

Fixes #1737

See c5d0437c (comment 1433556)

Make sure to keep a reference to the GoaObject of the account around so
that the GBinding that synchronises each switch widget and the account
properties don't get finalized on startup.

 #0  0x00007ffff73c6a20 in g_binding_finalize () at /lib64/libgobject-2.0.so.0
 #1  0x00007ffff73d3d22 in g_object_unref () at /lib64/libgobject-2.0.so.0
 #2  0x00007ffff73c68e8 in weak_unbind () at /lib64/libgobject-2.0.so.0
 #3  0x00007ffff73cf117 in weak_refs_notify () at /lib64/libgobject-2.0.so.0
 #4  0x00007ffff72acd6c in g_data_set_internal () at /lib64/libglib-2.0.so.0
 #5  0x00007ffff73d0195 in g_object_real_dispose.lto_priv () at /lib64/libgobject-2.0.so.0
 #6  0x00007ffff73d3c44 in g_object_unref () at /lib64/libgobject-2.0.so.0
 #7  0x00007ffff72b6793 in g_hash_table_remove_all_nodes.part () at /lib64/libglib-2.0.so.0
 #8  0x00007ffff72ba723 in g_hash_table_unref () at /lib64/libglib-2.0.so.0
 #9  0x00007ffff753403d in g_dbus_object_proxy_finalize () at /lib64/libgio-2.0.so.0
 #10 0x00007ffff73d3d22 in g_object_unref () at /lib64/libgobject-2.0.so.0
 #11 0x0000000000402d08 in glib_autoptr_clear_GoaObject (_ptr=0x5d59f0) at /usr/include/goa-1.0/goa/goa-generated.h:3265
 #12 glib_autoptr_cleanup_GoaObject (_ptr=<synthetic pointer>) at /usr/include/goa-1.0/goa/goa-generated.h:3265
 #13 on_application_activate_show_account_cb (application=0x49f2f0, argv=<optimized out>) at ../../../../Projects/jhbuild/gnome-control-center/panels/online-accounts/gnome-control-center-goa-helper.c:360

Closes: #1721

Óscar Fernández Díaz authored Mar 17, 2022 and Felipe Borges committed Apr 19, 2022

Some UI strings were not marked as translatable when the panel was ported to GTK4.