- Feb 08, 2017
-
-
Felipe Borges authored
Set a minimum content height of 490px for the panel when the allocated height is smaller than 490px. 490 is an estimated value for the panels to properly fit on netbook screens. See https://wiki.gnome.org/Design/SystemSettings#Notes https://bugzilla.gnome.org/show_bug.cgi?id=767600
-
Felipe Borges authored
This patch purges all the former TreeView machinery and makes the Printers panel have the printers listed in a scrolled window, as designed at https://wiki.gnome.org/Design/SystemSettings/Printers https://bugzilla.gnome.org/show_bug.cgi?id=767600
-
Felipe Borges authored
This dialog handles the editing of printer properties such as name, location, automatic discovery of driver, manual selection of printer driver, and manual selection of ppd file. https://bugzilla.gnome.org/show_bug.cgi?id=767600
-
Felipe Borges authored
This commit introduces the following regressions: - no possibility of renaming properties such as printer names, location, or changing model/driver. This issue is going to be solved nextly by the introduction of the PpDetailsDialog. https://bugzilla.gnome.org/show_bug.cgi?id=767600
-
The last login button should be insensitive for other accounts if the panel is not unlocked. https://bugzilla.gnome.org/show_bug.cgi?id=767065
-
- Feb 07, 2017
-
-
Felipe Borges authored
The "Add Printer" dialog should be smart enough to know whether an item listed in the dialog is a samba server or just a printer. If it is a samba server, it should go for the authentication page instead of emitting a GTK_RESPONSE_*. https://bugzilla.gnome.org/show_bug.cgi?id=778277
-
Felipe Borges authored
In order to keep the dialog size in the same aspect ratio of the mockups as https://wiki.gnome.org/Design/SystemSettings/Printers The "height-request" property should never go higher than 490px. 490 is an estimated value for the panels to properly fit on netbook screens. See https://wiki.gnome.org/Design/SystemSettings#Notes https://bugzilla.gnome.org/show_bug.cgi?id=778266
-
Felipe Borges authored
The mockups at https://wiki.gnome.org/Design/SystemSettings/Printers show just the word "Add" for the button which opens the "Add Printer" dialog. https://bugzilla.gnome.org/show_bug.cgi?id=778268
-
- Feb 05, 2017
-
-
Piotr Drąg authored
-
- Feb 04, 2017
-
-
- Feb 03, 2017
-
-
- Feb 01, 2017
-
-
Felipe Borges authored
Introduce a "go-back" button allowing to get back to the list of printers when the user is exposed to the authentication form in the "Add New Printer" dialog. This is a redesign based on the newest mockups available at https://wiki.gnome.org/Design/SystemSettings/Printers#Guidelines https://bugzilla.gnome.org/show_bug.cgi?id=760783
-
-
- Jan 31, 2017
-
-
Georges Basile Stavracas Neto authored
As described in the proposed mockups [1], the Keyboard panel should have a Reset All button above the list of shortcuts that allows the user to quickly reset all the shortcuts to their default keybinding. The current implementation, however, lacks this button. Fix that by adding a "Reset All" button, and implementing the reset all action. A message dialog is shown in order to confirm the action, and custom shortcuts are not reset (unless the conflict with the default keybinding of another standard shortcut). [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/keyboard/keyboard-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=777840
-
Georges Basile Stavracas Neto authored
The current Keyboard panel allows only the shortcut list to scroll. Since we want to add more widgets above the list, and we want them to scroll out of sight per the latest mockups [1], making only the shortcut list scrollable poses a problem. Fix that by making the entire panel scrollable. [1] https://github.com/gnome-design-team/gnome-mockups/blob/master/system-settings/keyboard/keyboard-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=777840
-
- Jan 30, 2017
-
-
Georges Basile Stavracas Neto authored
The current shortcut editor state is managed by setting and comparing the page name directly, making the code look more complicated than it should. Fix this by introducing the concept of pages, and using this to set and get the current shortcut editor dialog state. https://bugzilla.gnome.org/show_bug.cgi?id=777845
-
Georges Basile Stavracas Neto authored
After introducing the reset button to match the mockups [1], the shortcut editor dialog had some issues exposed. This is visible e.g. when the user tries to edit a custom shortcut's name and the shortcut is disabled. This happens because we assume there is always a shortcut set. When we open the dialog to edit a custom shortcut, however, nothing is actually set, and we end up saving the disabled shortcut when editing the shortcut's name or command. Fix that by initializing the shortcut's accelerators when editing a shortcut, and correcting the logic to validate the shortcut. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/keyboard/keyboard-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=777845
-
Georges Basile Stavracas Neto authored
Per the mockups [1], when editing a custom shortcut, there is a reset button right after the current shortcut. When there is no shortcut set, it shows a "Set Shortcut" button instead. The current UI to edit a shortcut, however, diverges from the proposed one since we use an "Edit" button instead. Fix that by swapping the Edit button with a reset button, and adapt the code to not depend on the edit button anymore. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/keyboard/keyboard-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=777845
-
Georges Basile Stavracas Neto authored
Per the mockups [1], this should be "Set Shortcut…". [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/keyboard/keyboard-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=777844
-
Kjartan Maraas authored
-
Kjartan Maraas authored
-
- Jan 28, 2017
-
-
- Jan 27, 2017
-
-
Piotr Drąg authored
They need to be exactly one line above a string to show up in .po files.
-
Georges Basile Stavracas Neto authored
When adding a custom shortcut, the header mode was set to be only "Cancel". Per mockups, the "Add" button should also be visible but insensitive. Fix that by correctly setting the header mode on creation mode. https://bugzilla.gnome.org/show_bug.cgi?id=777824
-
Georges Basile Stavracas Neto authored
When creating a new shortcut, we currently assume the entries are sensitive and just show the dialog. This, however, may not be, for example after previously canceling the editing of a custom shortcut, leading to a state where the name and command entries are insensitive. Fix that by always making sure the entries are sensitive when setting the dialog to creation mode. https://bugzilla.gnome.org/show_bug.cgi?id=777824
-
Georges Basile Stavracas Neto authored
When canceling the editing of a custom shortcut, the "Edit" button keeps pressed, causing inconsistencies when editing future custom events. To reproduce that: - Open a custom shortcut and click "Edit" - Start typing the new shortcut; the "Cancel" button will appear - *Before* completing the new shortcut, click "Cancel"; the dialog will hide - Open a custom shortcut again; the "Edit" button is still toggled Fix that by properly untoggling the Edit button when cancelling the editing. https://bugzilla.gnome.org/show_bug.cgi?id=777824
-
-
- Jan 24, 2017
-
-
- Jan 22, 2017
-
-
Jordi Mas authored
-
- Jan 21, 2017
-
-
Piotr Drąg authored
-
- Jan 20, 2017
-
-
- Jan 19, 2017
-
-
Lubomir Rintel authored
It looks a bit weird to define it and still use the numeric literal.
-
Lubomir Rintel authored
The empty string is not too useful as an SSID, an attempt to create a hotspot fails: (gnome-control-center:19371): network-cc-panel-WARNING **: Failed to add new connection: (2) A 'wireless' setting with a valid SSID is required if no AP path was given.
-
-
- Jan 18, 2017
-
-
-
Piotr Drąg authored
Many languages may need to translate a button differently than a window title.
-
Felipe Borges authored
This dialog is no longer necessary since the authentication form is now handled in the PpNewPrinterDialog itself. https://bugzilla.gnome.org/show_bug.cgi?id=760783
-
Felipe Borges authored
PpSamba no longer needs to hold a reference to the dialog window. https://bugzilla.gnome.org/show_bug.cgi?id=760783
-