any input source, so this commit is a fix to handle this.

#324

reporting things in the wrong order.

#324

This was the Fedora version that supported GNOME 3.28. The CI fails to build on
newer versions of Fedora.

Since the gsettings is for the repeat-interval but the
GUI is for Speed, we need to reverse the mapped direction.

We have to turn off the fill indicator (has_origin) for Speed
since it fills the right side instead of the left. We turn
off the indicator for Delay to match.

Closes: #311
(cherry picked from commit ae75ebca)

Due to an API bug in GNOME Online Accounts, the asynchronous
goa_provider_get_all method doesn't accept a GCancellable argument.
This makes it difficult to cancel an ongoing call when the CcGoaPanel
gets destroyed.

Prior to commit c26f8ae0, this was hacked around by taking a
reference on the panel for the duration of the call. Instead of
cancelling a pending call on destruction, it would keep the panel alive
until the call was over. However, that was lost during commit
c26f8ae0.

One thing to bear in mind is that GtkWidgets, CcGoaPanel is one, can
be destroyed by a gtk_widget_destroy call, which is subtly different
than a simple sequence of g_object_unref calls. When gtk_widget_destroy
is used, it invokes the GObject::dispose virtual method of the widget.
It is expected this will cause anything holding a reference to this
widget to drop their references, leading to GObject::finalize being
called. However, there is no guarantee that this will happen in the
same iteration of the GMainLoop. Therefore, it is possible that when
the goa_provider_get_all call finishes, the CcGoaPanel might be in a
disposed, but not yet finalized state.

When a GObject is in a disposed-but-not-finalized state, only a very
limited number of operations can be performed on it. Its reference
count can be altered, the memory used by the instance struct can be
accessed, but none of the member GObjects can be assumed to be valid.
eg., it's definitely illegal to add new rows to the member GtkListBox.
Hence a boolean flag is used to mark the destroyed state of the panel.

This second part is a small improvement over the earlier hack.

#208

Fixes #24

Georges Basile Stavracas Neto authored Mar 06, 2018 and Ondrej Holy committed May 31, 2018

So that we can run Settings more than once in GNOME Builder.
Without the -f flag, ln errs out after these symlinks are
created, and Builder refuses to run after that.

Closes: #107

The disconnect was for the wrong object (connection rather than client).
Fix this by simply moving to use g_signal_connect_object which obsoletes
the explicit disconnect calls.

When the connection is modified then the title might be changed. Call
the UI update function to ensure that widgets are updated.

The test to check whether the Bluetooth (simple section) contains
elements was testing for NetObjectSimple. However, ethernet connections
are a subclass and check would count these. This causes issue when the
code is run after net object removal.

The fix is to check for the exact object type rather than also allowing
subclasses.

When a device is removed the callback handler could still be called
because it was connected using g_signal_connect rather than
g_signal_connect_object. This fixes crashes in the UI after a device has
been removed again.

(cherry picked from commit e91266a8)

The "removed" callback from NMObject is never called when the object is
simply finalised because the UI drops the reference. Explicitly call the
handler so that UI elements are removed.

(cherry picked from commit ec50cbcd)

Jeremy Bicha authored Apr 24, 2018 and Georges Basile Stavracas Neto committed May 29, 2018

This reverts commit 94aeba51.

We actually do want to see the last panel opened


(cherry picked from commit f1092895)

We should ignore G_IO_ERROR_CANCELLED errors and avoid displaying useless
warnings. Also use g_clear_object instead of g_object_unref.

Fixes: #87

dialog_got_proxy_cb and dialog_got_proxy_props_cb may be called after the
instance of CcNightLightDialog has been disposed. Make sure 'self' pointer is
not dereferenced if not valid.

Fixes: #86

Ondrej Holy authored Apr 25, 2018 and Georges Basile Stavracas Neto committed May 12, 2018

A variable of label widget, used for a hint when wrong enterprise
user/password is used, is not properly initialized and thus criticals
are shown instead of the hint when user/password is wrong. Let's bind
the variable properly.


(cherry picked from commit f4b1fb66)

Benjamin Berg authored Apr 25, 2018 and Georges Basile Stavracas Neto committed May 02, 2018

When selecting the panel on startup based on the "last-panel" settings,
we need to make sure that the panel exists.

Note that this is a special case which does not use the internal
set_active_panel_from_id API. Using it is currently not possible because
the API does not report back the error and we would end up not selecting
any panel.


(cherry picked from commit f547d912)

Rasmus Thomsen authored Mar 15, 2018 and Ondrej Holy committed Apr 24, 2018

Closes: #69

Iñigo Martínez authored Apr 14, 2018 and Georges Basile Stavracas Neto committed Apr 17, 2018

meson defines `USER_DIR_MODE` with a raw octal value to be used as
the default permissions when creating the user's configuration
directory.

However, meson does not support raw octal values[0], so the define
misses the initial `0` value. Due to this, the directory is created
with wrong permissions.

This has been changed to use the octal value as a string in meson,
so the definition has the proper value.

Fixes #49

[0] https://github.com/mesonbuild/meson/issues/2047


(cherry picked from commit 37a6b940)

Fix a user-after-free while testing the connectivity to a cups
server. This is similar to the fix in commit 1d72a0b3.

This is an addition to the changes introduced in commit 2ff5cfd6
which allowed the connection testing to be cancellable.

Fixes #51
Fixes https://bugzilla.gnome.org/794632