I don't really have a capacity for this already...

Ondrej Holy authored May 05, 2020 and Felipe Borges committed May 05, 2020

The add user button is shown only if the panel is unlocked, but
tooltips are also set for the case when the panel is not unlocked.
Let's move the tooltip text in the UI file directly and remove
the obsolete codes.

Ondrej Holy authored May 05, 2020 and Felipe Borges committed May 05, 2020

The add user button is not shown currently if no users are found
even if the panel is unlocked. Let's show the button to allow
user creation in this case.

Fixes: GNOME/gnome-control-center#988

Ondrej Holy authored May 05, 2020 and Felipe Borges committed May 05, 2020

The permissions toolbar is not shown currently if no users are found
which prevents creation of new user accounts. Let's show the toolbar
also in this case.

GNOME/gnome-control-center#988

Changes made by !359 caused that the username
hint ("This will be used to name your home folder and can’t be changed.")
is not shown immediately after opening the "Add User" dialog. This change
was unwanted. Let's show the hint immediately after opening the dialog as
it was before.

Ondrej Holy authored Jan 13, 2020 and Felipe Borges committed Jan 13, 2020

gtk_widget_translate_coordinates() doesn't have to always set the
dest_x argument. Let's initialize the argument before use to prevent
usage of uninitialized value, which also prevents "Conditional jump
or move depends on uninitialised value(s)" messages from valgrind.

On Fedora 31, the "Current Password: " prompt is printed by passwd,
when I enter my current password wrongly. It is not clear to me why
and I don't know how to debug the PAM stack, but it causes that the
checkmark for the old password field is not reliable and what is worse
it causes the dialog hangs when it is submitted. Let's add check for
the "urrent" keyword to fix this issue.

Fixes: #766

Ondrej Holy authored Nov 08, 2019 and Robert Ancell committed Nov 11, 2019

Currently, the password_entry_timeout() callback can be called even after
the dialog disposal, which leads to segfaults. This is because the
corresponding source ids can be cleared in some cases without removing
the sources. Let's prevent direct calls of password_entry_timeout()
without destroying the source ids in order to fix this issue.

Fixes: #760

Ondrej Holy authored Jan 25, 2019 and Georges Basile Stavracas Neto committed Aug 26, 2019

Username policies differ across the distributions. See the discussion on:
!359

It is not possible to hard-code some rules here without the need for
downstream modifications. Let's check the validity of usernames dynamically
over "usermod" to prevent this.

Just be careful that this is based on undocumented usermod behavior, which
may change in the future.

Ondrej Holy authored Jun 07, 2019 and Georges Basile Stavracas Neto committed Jun 07, 2019

If "Esc" is pressed, the callbacks to handle the `focus-out` signal are
called after the `cc_password_dialog_dispose` function. This leads to
segfaults, because the `user` variable is already cleared. Let's simply
do not continue if `user == NULL` to fix those crashes.

Closes: #563

Ondrej Holy authored May 03, 2019 and Felipe Borges committed May 16, 2019

Currently, it is not possible to unset a custom avatar, respective it
is not possible to set the default one. Let's present the default
avatar in the avatar popover as suggested in the mockup:
https://wiki.gnome.org/Design/OS/AvatarChooser

Fixes: #62

Ondrej Holy authored May 03, 2019 and Felipe Borges committed May 16, 2019

The `round_image()` function has the `icon_size` parameter, which is not
used by that function, because the size is determined from a pixbuf size.
Let's remove that redundant `icon_size` parameter.

GNOME/gnome-control-center!387 ported info panel to use UDisks2 instead
of GUnixMounts and thus the helpers from gsd-disk-space-helper.[h|c] are
no more needed.

Ondrej Holy authored Feb 07, 2018 and Georges Basile Stavracas Neto committed Mar 02, 2019

accountsservice has 1 MB limit for avatars, however, users panels
refuses to show avatars bigger than 64 KB for some historical reasons.
But you can still successfully set avatars up to the accountsservice
limit. Let's remove this custom limit and other redundant check and
rely just on accountsservice limits and errors from GDK.

https://bugzilla.gnome.org/show_bug.cgi?id=792243

Ondrej Holy authored Feb 07, 2018 and Georges Basile Stavracas Neto committed Mar 02, 2019

Default set of avatars uses 512x512 currently. However, custom avatars
from file, or webcam are always scaled down to 96x96. Let's increase this
also to 512x512. This change should be safe, because theoretical maximal
file size is 1 MB, which is equal to accountsservice limit.

https://bugzilla.gnome.org/show_bug.cgi?id=792243

Changes from !373 causes crashes when "Add User" dialog is canceled.
Check return value and generate user avatar only if valid user is
returned to fix the crashes.

Ondrej Holy authored Dec 13, 2018 and Georges Basile Stavracas Neto committed Jan 05, 2019

gnome-user-accounts-panel.desktop has some differences in "Categories" in
comparison to other desktop files provided by gnome-control-center for no
obvious reason.

Add "GNOME" and "GTK" categories, which are used in all other desktop files.

Remove "System" and use just "Settings" main category. This among others
prevents the following output from desktop-file-validate:

/usr/share/applications/gnome-user-accounts-panel.desktop: hint: value
"System;Settings;X-GNOME-Settings-Panel;X-GNOME-DetailsSettings;" for key
"Categories" in group "Desktop Entry" contains more than one main
category; application might appear more than once in the application menu

All other desktop files uses just the "Settings" main category.

But maybe this is totally useless patch, because it seems that GNOME Shell
do not care about the most of categories and GNOME Classic do not show those
desktop files in menus at all.

Ondrej Holy authored Aug 30, 2018 and Robert Ancell committed Sep 10, 2018

Always use pwquality_strerror()	in case	of error in order to prevent
memory leaks and to improve error messages.

GNOME/gnome-control-center#171

Ondrej Holy authored Aug 30, 2018 and Robert Ancell committed Sep 10, 2018

Users panel crashes with g_error() if some of libpwquality calls fails,
e.g. when pwquality.conf is broken. The default values should be used
instead of crash. Let's use g_warning() instead of g_error() in that
case.

GNOME/gnome-control-center#171

Ondrej Holy authored Aug 30, 2018 and Robert Ancell committed Sep 10, 2018

um_password_dialog_set_user() is called from on_permission_changed()
respective show_user(), which more or less means on every change in
the panel. It it pretty enough to call this before opening the password
dialog, which is already done over change_password() callback. Let's
remove the redundant call which may lead to unwanted failures among
others.

GNOME/gnome-control-center#171

Ondrej Holy authored Aug 15, 2018 and Robert Ancell committed Aug 15, 2018

"warning: passing argument 1 of ‘gtk_widget_destroy’ from incompatible
pointer type" is printed from g_clear_pointer, because it is more
type-safe now. See glib#1425 for
more info. Add the necessary casts to suppress the warnings.

The Password dialog uses "Verify New Password" and Add User dialog
"Confirm". Let's use "Confirm New Password" as it is on mockups to
be consistent in terminology.

Use "The passwords do not match." phrase in the Add User dialog and
Password dialog consistently.

If a password is generated and prefilled in the corresponding entries,
the verify entry remains insensitive. Let's fix the sensitivity...

#38

If <tab> is pressed and password is not yet validated (ie. the verify
entry is not sensitive), focus skips the verify entry, even if the
password is strong enough. Let's validate the password when <tab> is
pressed (ie. before focus change) to prevent this <tab> breakage...

#38

This reverts commit 7b3746af.

This is needed to make obvious that password is not yet strong
enough.

Closes: #38

Ondrej Holy authored Apr 25, 2018 and Georges Basile Stavracas Neto committed May 12, 2018

A variable of label widget, used for a hint when wrong enterprise
user/password is used, is not properly initialized and thus criticals
are shown instead of the hint when user/password is wrong. Let's bind
the variable properly.

#20

#20

cheese_camera_device_monitor_new freezes the whole panel when opening
for a couple of seconds if external camera is connected. This is not
acceptable. Probably it is bug in kernel. Let's use GAsyncInitable if
available.

Bump the cheese dependency accordingly.

https://bugzilla.gnome.org/show_bug.cgi?id=783789

With the carousel, the custom user image cell renderer is no more needed.

Legacy face images should not be shown in avatar chooser, so let's filter
all symlinks to the legacy files out.

Closes: #5

Commit ffe5aac8 introduced new set of face images and removed the old
ones. Consequently, generic avatar is shown for people after update.
Add back legacy images, so people won't lose their current images on
update. Add them into the subfolder and create symlinks for them,
so it can be simply filtered out from the chooser widget, because just
the new images should be shown.

#5

We want to add back legacy images, so let's rename the new ones to not
be in a conflict. This unfortunately can cause another breakage for
people which uses development versions, but we can't do much about it.

#5

GFile is needed for face widgets anyway, so let's use GFileEnumerator
for dir listing instead of POSIX API.

#5

In a specific cases, current user doesn't have to be returned from
accountsservice, or can be skipped by act_user_is_system_account check.
System users should not be shown. This is expected for root account,
but should not happen with regular user accounts. It needs to be fixed
in accountsservice if you see this happening with regular user accounts.
We have to be just sure that Users panel doesn't crash in such cases
and show all non-system user accounts returned from accountsservice.
Empty page is shown currently only if act_user_manager_list_users
returns nothing, but it has to be also shown if only system accounts
are returned. To fix this issue, do not try to show current user, but
show first user account in carousel instead if there is any. First user
account is current user in normal case.

The patch also fixes problems that current user account is sometimes
selected instead of currently selected user account. This is because
of preselection of first item in um_carousel_add, which causes unwanted
signal emissions...

https://bugzilla.gnome.org/show_bug.cgi?id=773673

It is possible to use weak passwords in dialogs currently, which is
not intentional and leads to problems in case of changing password of
current user. This regression was introduced by Bug 780002, which added
new strength level for weak passwords. Let's reflect the new level also
when setting sensitivity...

https://bugzilla.gnome.org/show_bug.cgi?id=788122

Ondrej Holy authored Apr 05, 2017 and Felipe Borges committed May 03, 2017

Use red-yellow- green colors for strength indicator levels.

https://bugzilla.gnome.org/show_bug.cgi?id=780002

Ondrej Holy authored Apr 05, 2017 and Felipe Borges committed May 03, 2017

Don't say "Good password!" for all acceptable password (e.g. weak passwords).
Say explicitely that password needs to be longer for short passwords.

https://bugzilla.gnome.org/show_bug.cgi?id=780002

Ondrej Holy authored Apr 05, 2017 and Felipe Borges committed May 03, 2017

Add first level for short, or weak passwords to be obvious that
the strength indicator signalize something.

https://bugzilla.gnome.org/show_bug.cgi?id=780002