Abdullahi Usman authored Jul 18, 2017 and Georges Basile Stavracas Neto committed Aug 18, 2017

Month view used to calculate the event's start date and end date from
the physical layout of the month and compare it with the event's
original start date and end date to see if there is a change and then
update as necessary by either slanted start or end, when either is/are
not equal to the one in the original start and end dates.

However, the way in which the start date and end date in RTL language are
calculated must be different since the layering of the days in the weeks
are opposite.  Month view uses precalculated days number to mirror the
last week, which already chop off the days_delay number from cell_idx value.
In RTL, this cause issues such that the days are calculated wrongly and a
slanted start or end is visible.  Because the date is not the same as the
original events date, month view thinks that the view needs an update and
so tries to update the view wrongly.

We can fix this by using the cell_idx value to calculate the days and then
substracting the days_delay value after that.

https://bugzilla.gnome.org/show_bug.cgi?id=777426

Abdullahi Usman authored Jul 10, 2017 and Georges Basile Stavracas Neto committed Jul 10, 2017

The week view can display mutilple events that can partly or fully span
same time ranges.

But week view fails to make correct assumption about the width of events when
two or more events span some time ranges in which these events also span some
time ranges with other events, and whereby the number of these other events
that they span time ranges with does not coincide with the number of the events
that the other event also span.  Week view ended up calculating cells that
appears horizontally jointed up.  Also int16_compare() does not dereference the
pointer from g_ptr_array_sort() correctly and that makes it sort events
incorrectly and hence making events appears vertically jointed up.

If an event have other events in which they span some time, we calcuate its width
by taking into consideration of all the events that the other event may span
time with.  The event that has the higher number of time spans is considered.
We also save and retrieve our positions using UINT_TO_POINTER and POINTER_TO_UINT()
respectively, and then dereference the pointer from g_ptr_array_sort() correctly.

https://bugzilla.gnome.org/show_bug.cgi?id=777416

Milan Crha authored May 25, 2017 and Georges Basile Stavracas Neto committed Jun 08, 2017

https://bugzilla.gnome.org/show_bug.cgi?id=782475

Abdullahi Usman authored May 24, 2017 and Georges Basile Stavracas Neto committed Jun 08, 2017

The overflow layout sit at the bottom of a cell to display "Other X events"
when there is no room to accomodate more.

The issue is that the overflow layout does not have margin property like
other views(layouts) in the cell, so instead it appears either too far from or
too close to the border depending on the text it accomodates.

We can fix this by setting the margin property.

https://bugzilla.gnome.com/show_bug.cgi?id=771581

Mohammed Sadiq authored May 23, 2017 and Georges Basile Stavracas Neto committed Jun 08, 2017

https://bugzilla.gnome.org/show_bug.cgi?id=782972

When setting an event, we might modify the event in such a way that
the edit dialog can be broken if it doesn't update.

Fix that by unconditionally updating the event dialog when setting
an event.

Abdullahi Usman authored May 19, 2017 and Georges Basile Stavracas Neto committed Jun 08, 2017

The overflow layout used to display "Other X events" text when
there is no enough space to accomodate more events.

This used to get mixed-up/overlapped with the date label because the
overflow label uses whole cell width as width.

We can fix this by substracting date label width from overflow label
width to accomodate the date label.

https://bugzilla.gnome.com/show_bug.cgi?id=7771581

https://bugzilla.gnome.org/show_bug.cgi?id=771581

Abdullahi Usman authored May 12, 2017 and Georges Basile Stavracas Neto committed Jun 08, 2017

The overflow layout sit at the bottom of a cell to display "Other X events"
when there is no room to accomodate more.

The issue is that the overflow layout does not have margin property like
other views(layouts) in the cell, so instead it appears either too far from or
too close to the border depending on the text it accomodates.

We can fix this by setting the margin property.

https://bugzilla.gnome.com/show_bug.cgi?id=7771581

In a Flatpak'd world, we cannot rely on the fact that
gnome-control-center binary will be installed at the
app's sandbox. But since it's a core app, we can rely
on the fact that it's available outside the sandbox.

To make it work, use DBus rather than raw spawn to
open control center.

Instead of keeping an active timeout source spamming the
console, just connect to the right signal and wait for the
week view to be visible again.

Emmanuele Bassi authored May 19, 2017 and Georges Basile Stavracas Neto committed Jun 08, 2017

Evolution-data-server recently bumped its dependency on libical from 1.0
to 2.0. Since we build e-d-s from Git in the Flatpak builder manifest,
we need to update the version of libical we build as well.

Milan Crha authored May 25, 2017 and Georges Basile Stavracas Neto committed May 27, 2017

https://bugzilla.gnome.org/show_bug.cgi?id=782475

Instead of having each view manage it's own timeout (or
even worse, making GcalWindow manage it), use the newly
introduced GcalClock API to do that.

This clock will be used in the future by other classes
to update stuff.

GcalClock is an internal clock for GNOME Calendar that
sends a few utility signals, such as :day-changed and
:minute-changed.

It also watches for suspend/resume events to properly
send the signal right after the resume.

Mohammed Sadiq authored May 12, 2017 and Georges Basile Stavracas Neto committed May 15, 2017

https://bugzilla.gnome.org/show_bug.cgi?id=782566

Mohammed Sadiq authored May 12, 2017 and Georges Basile Stavracas Neto committed May 15, 2017

https://bugzilla.gnome.org/show_bug.cgi?id=782561

Orkun Tezer authored May 06, 2017 and Georges Basile Stavracas Neto committed May 09, 2017

Dnd at week header crashes with segmentation fault

The problem, calculation of dnd_date returns NULL when week_start is
in previous month.

Fix that by using g_date_time_add_days() function

https://bugzilla.gnome.org/show_bug.cgi?id=781955

Mohammed Sadiq authored May 06, 2017 and Georges Basile Stavracas Neto committed May 08, 2017

This was causing segfault in week-view

https://bugzilla.gnome.org/show_bug.cgi?id=782269

When we escape first, then truncate, we might end up truncating at
the middle of a special character sequence, breaking the markup.

Fix that by escaping after truncating.

Mohammed Sadiq authored May 06, 2017 and Georges Basile Stavracas Neto committed May 06, 2017

https://bugzilla.gnome.org/show_bug.cgi?id=782192

Kevin Lopez authored May 04, 2017 and Georges Basile Stavracas Neto committed May 04, 2017

Result drop down should disappear when any click is performed outside
that drop down.

https://bugzilla.gnome.org/show_bug.cgi?id=747962

Orkun Tezer authored May 03, 2017 and Georges Basile Stavracas Neto committed May 03, 2017

The Problem: When user remove 4rt fullday event, header only shows two
events and not shows 3rd fullday event

Because, we check and set visibility of event that user wants to remove
from calendar, before remove event from event list which causes 3rd
event unvisible.

Fix that with check and set visibility of event after remove event
from event list, then visibilties and overflow corretly calculated

https://bugzilla.gnome.org/show_bug.cgi?id=777423

Since we use autoptr on those, we may end up falling in to
the early return and mistakenly unreferencing the not
initialized new date.