diff options
| author | Matthias Clasen <mclasen@redhat.com> | 2015-09-23 22:55:28 (GMT) |
|---|---|---|
| committer | Matthias Clasen <mclasen@redhat.com> | 2015-09-23 22:55:28 (GMT) |
| commit | 2d7817887a9f0624f73492d04b2a992545f0beb9 (patch) | |
| tree | 8acf191e22724416474195a9468061d4e862d0aa | |
| parent | aef2d0c56dd6d363e51b1c37dc0095054f18098c (diff) | |
| download | glib-2d7817887a9f0624f73492d04b2a992545f0beb9.zip glib-2d7817887a9f0624f73492d04b2a992545f0beb9.tar.xz | |
Revert "list store: Fix a parameter check"
This reverts commit d28639507db2029b8f184a5d93e9d8c28acc1955.
This wasn't meant to go in.
https://bugzilla.gnome.org/show_bug.cgi?id=755496
| -rw-r--r-- | glib/gsequence.c | 18 |
1 files changed, 7 insertions, 11 deletions
diff --git a/glib/gsequence.c b/glib/gsequence.c index 75c1f76..76e24e7 100644 --- a/glib/gsequence.c +++ b/glib/gsequence.c @@ -139,8 +139,7 @@ static GSequenceNode *node_find_closest (GSequenceNode *haystack, GSequenceNode *needle, GSequenceNode *end, GSequenceIterCompareFunc cmp, - gpointer user_data, - gboolean return_match); + gpointer user_data); static gint node_get_length (GSequenceNode *node); static void node_free (GSequenceNode *node, GSequence *seq); @@ -1080,7 +1079,7 @@ g_sequence_search_iter (GSequence *seq, dummy = g_sequence_append (tmp_seq, data); node = node_find_closest (seq->end_node, dummy, - seq->end_node, iter_cmp, cmp_data, TRUE); + seq->end_node, iter_cmp, cmp_data); g_sequence_free (tmp_seq); @@ -1734,8 +1733,7 @@ node_find_closest (GSequenceNode *haystack, GSequenceNode *needle, GSequenceNode *end, GSequenceIterCompareFunc iter_cmp, - gpointer cmp_data, - gboolean return_match) + gpointer cmp_data) { GSequenceNode *best; gint c; @@ -1765,12 +1763,10 @@ node_find_closest (GSequenceNode *haystack, } while (haystack != NULL); - /* If the best node is smaller than the data, then move one step - * to the right to make sure the best one is strictly bigger than the data. - * We do return the last exact match or the node after it, depending on - * the return_match argument. + /* If the best node is smaller or equal to the data, then move one step + * to the right to make sure the best one is strictly bigger than the data */ - if (best != end && (c < 0 || (c == 0 && !return_match))) + if (best != end && c <= 0) best = node_get_next (best); return best; @@ -1992,7 +1988,7 @@ node_insert_sorted (GSequenceNode *node, { GSequenceNode *closest; - closest = node_find_closest (node, new, end, iter_cmp, cmp_data, FALSE); + closest = node_find_closest (node, new, end, iter_cmp, cmp_data); node_unlink (new); |
