- Apr 17, 2024
-
-
Jacob Boerema authored
We are using `gimp_image_set_file` to set the filename, which requires an extension, not doing so caused an error. So let's add .xcf to all compose filenames.
-
Jacob Boerema authored
When decomposing, the plug-in sets the filename without changing the extension. However, gimp_image_set_file requires the filename to be an .xcf file. To fix this we simplified `generate_filename` to always add an .xcf extension. While doing this we also fixed a critical that happened when no filename was set (new image), by testing `gimp_image_get_file` for being NULL first. When no filename was set it also didn't use the type when config_as_layers was set, this is also fixed.
-
Alx Sa authored
Resolves #11334 GBR, GIH, and PAT have internal save functions which are not meant to be run directly. However, they were showing up in the Search dialogue as valid options. This patch adds an additional check for "-internal" to prevent users from accidentally running them, as they only give a warning.
-
-
Jehan authored
The whole action name prefixing will definitely need to be straightened up in our codebase at some point (differenciating the global actions and the local ones).
-
-
-
-
-
-
-
Jacob Boerema authored
For certain min/max values of the LabelSpin widget, in combination with zero digits, it proves impossible to change the initial value. The reason for this is that the step size may become less than 1.0. In which case, stepping doesn't work because the number of digits is set to zero. Let's check for this situation and when digits is zero set the step to 1.0 and make sure that page is at least the same value. While testing this I also noticed another issue: when initializing the upper value was set to 0.0 and the lower to 1.0 which leads to a critical because lower > upper. We fix this by switching the initial upper and lower values.
-
- Apr 16, 2024
-
-
Jordi Mas authored
-
Jacob Boerema authored
There was no user feedback when our twain plug-in couldn't find the (32-bit) TWAIN driver, making for a poor user experience. Especially since nowadays the availability of the twain driver is less likely, let's add an error message for the user, so they will know what's going on.
-
Jehan authored
We now have a proper icon thanks to Denis Rangelov!
-
Jehan authored
The previous commit worked for all the compiled executables, but for Python plug-ins (and likely all other GObject-Introspected bindings), we need to generate a temporary typelib linking to the in-build-directory libgimp* libraries. This is similar to what the script `package/macports_build_app.sh` does for packaging in gimp-macos-build repository.
-
Jehan authored
The DYLD_LIBRARY_PATH trick was working fine on CI, but not on local builds for Lukas. Apparently there are security measures disabling the environment variable. Instead let's temporarily add then remove libgimp libraries folders from rpath. See: Infrastructure/gimp-macos-build!292 (comment 2075291)
-
-
Bruno Lopes authored
This stage was introduced in 076e4d68 and it fulfilled well its purpose. But the side effects were: more (sometimes slow) uploading and downloading of packages and artifacts. Even if we have caching, this is far from ideal. Now, the so-called "packaging" jobs were moved inside in the "build" jobs. The advantages are: just one pacman install (ideally cached from deps job); direct packaging without waiting for upload/download; and less confusion, since "packaging" naming was implying that the .zips are somewhat official, which isn't totally true, and sometimes overlaps the dist/deploy concept. --- Also, the flatpak job now uses config.h instead of triggering a GIMP build. In other words, I'm reverting part of my work in some old commits.
-
Jehan authored
Fix 2 "discards ‘const’ qualifier from pointer target type" warnings.
-
Jehan authored
Unlike the previous 2 commits, this was not making an error but was the reason why our code was keeping the last closed GimpImage alive a bit longer than it should. In particular, the status bar code was keeping a hard reference to the image until the focus changed, hence preventing the object to get finalized longer than necessary. Now it will also be a weak reference, so the image is immediately freed when the view is closed.
-
Jehan authored
Similar to the previous commit, but this time for the GimpAlignOptions.
-
Jehan authored
Using weak pointers to make sure that the previously pointed image is still a valid GimpImage.
-
Bruno Lopes authored
Now, the CI will auto cancel jobs after a new commit is pushed and retry when the runners fails. The first case is frequent, the last is rare but happened.
-
Copy the NULL when creating GBytes from a string.
-
Alx Sa authored
Since the GeglColor port, gimp_drawable_get_pixel () returns a GeglColor rather than a GimpRGB structure. We needed to update the supporting code in ColorXHTML to handle the change.
-
- Apr 15, 2024
-
-
-
-
Jacob Boerema authored
As a follow up to the previous commit, I noticed that the pdb functions gimp-edit-cut and gimp-edit-named-cut also incorrectly used gimp_pdb_item_is_group. This can be seen by calling Filters/Blur/Tileable blur when a group layer is selected. The error message was incorrect. We replace the call here also to `! gimp_pdb_item_is_not_group`.
-
Jacob Boerema authored
Calling gimp_selection_float from a Python plug-in could make it crash with an error like Calling error for procedure 'gimp-selection-float': Item x cannot be used because it is not a group item. This is caused by an incorrect check for group layers. gimp_pdb_item_is_group returns an error when the condition is False, while we only want an error when a group layer is selected (True). Thus we need to use gimp_pdb_item_is_not_group, which returns an error when the item is a group, which is what we want. These function names are a little confusing, we might need to think about better naming sometime. I added C/Python tests for this function, so that we can test whether this works correctly.
-
Jehan authored
This is now back in sync with how it used to be up to GIMP 2.10. Basically our API version should always be <major>.0 in the shared libraries naming, as well as in pkg-config and docs. Otherwise we would break library compatibility with every minor version bump.
-
Jehan authored
Library binaries are not under a hidden .libs/ directory anymore.
-
Alx Sa authored
Per Elad Shahar, this should be v.b instead of v.r.
- Apr 14, 2024
-
-
Alx Sa authored
Code that checked if an image was NULL was run *after* the variable was used in a function, gimp_image_resize_to_layers (). This patch moves the NULL check before the function call is made. Additionally, we now verify there are at least two axis before trying to access indexes in the naxis array.
-
Bruno Lopes authored
-
Bruno Lopes authored
-