Skip to content
  1. Mar 16, 2024
  2. Aug 08, 2022
  3. Aug 06, 2022
    • Will Thompson's avatar
      nominatim: Validate response as UTF-8 · 1743789f
      Will Thompson authored
      Previously, the bytes read from the server's response were assumed to be
      valid UTF-8.  Particularly since we are copying it anyway, validate it
      at the same time.
      
      (In practice this is probably a non-issue because it just ends up
      getting passed to json_parser_load_from_data() which validates its input
      as UTF-8 anyway.)
      1743789f
    • Will Thompson's avatar
      nominatim: Correctly read response data from soup3 · 72285d20
      Will Thompson authored
      Previously, the soup3 branch would call g_bytes_unref_to_data() on the
      response data, with a NULL out parameter for the size, and then proceed
      to use the data pointer as a NULL-terminated string. This is wrong for
      two reasons:
      
      - g_bytes_unref_to_data()'s size parameter may not be NULL
      - The response data is not NULL-terminated
      
      Instead, do what the soup2 branch does: use g_strndup() to get a
      NULL-terminated string.
      
      No automatic test, but the async branch at least can be tested by
      running the test binary with an argument:
      
          _build/geocode-glib/tests/geocode-glib aoeuaoeuaoeu
      
      Note that you must change the search term each time, since the result is
      cached.
      
      Fixes: #30
      72285d20
  4. Jul 04, 2022
  5. Jul 02, 2022
  6. Jul 01, 2022
  7. Jun 30, 2022
  8. May 11, 2022
  9. Sep 21, 2021
  10. Sep 17, 2021