Skip to content
  1. Mar 01, 2019
  2. Jul 30, 2018
  3. Jul 25, 2018
  4. Jul 19, 2018
  5. Jul 18, 2018
    • Milan Crha's avatar
    • Milan Crha's avatar
      ESourceRegistry's thread main_context can leak · ed614938
      Milan Crha authored
      The problem was that EWebDAVDiscover (used to find out CalDAV calendars/memo
      lists/task lists and CardDAV books) wanted to receive a proxy ESource, for
      which it requires either ESourceRegistry or ESourceRegistryServer. As
      the EWebDAVDiscover API didn't have any such argument it always created its
      own ESourceRegistry instance, which had been dropped shortly afterwards. This
      drop also meant that the internal GDBus object scheduled its own events on
      the ESourceRegistry's thread main_context (to unsubscribe D-Bus signals), but
      this main_context didn't have enough time to flush the queue, which resulted
      in a leak of the main_context, because the events in it referenced it (similar
      to circular reference). The fix was to flush the queue before closing
      the thread and to reorganize the ESourceRegistry's dispose() function, thus
      the flush is done on filled main_context.
      
      While I've been in it, some structures unnecessarily long held a GCancellable
      object, which also means a file descriptor, thus I fixed that as well.
      
      As the last, but not least, I added a new API for the EWebDAVDiscover to
      be able to provide also a function to reference an ESource, thus there is
      no need to create the ESourceRegistry instance, thus it is quicker and more
      effective now.
      
      Reported downstream at:
      https://bugzilla.redhat.com/show_bug.cgi?id=1600489
      ed614938
  6. Jul 16, 2018
  7. Jul 10, 2018
  8. Jul 04, 2018
  9. Jul 03, 2018
  10. Jul 02, 2018
  11. Jun 27, 2018
  12. Jun 21, 2018
  13. Jun 19, 2018
  14. Jun 18, 2018
  15. Jun 14, 2018
  16. Jun 13, 2018
  17. Jun 07, 2018
  18. Jun 04, 2018
  19. Jun 01, 2018
  20. May 31, 2018
  21. May 30, 2018
  22. May 29, 2018
  23. May 21, 2018
  24. May 18, 2018
  25. May 17, 2018
  26. May 16, 2018
  27. May 15, 2018