Skip to content
  1. Mar 27, 2024
  2. Mar 26, 2024
    • Michael Catanzaro's avatar
      sync-service: fix error paths in new retrievable code · 624d91af
      Michael Catanzaro authored
      I forgot to return early on the error paths. Oops. This restores the
      original behavior. Fixes !1462
      624d91af
    • Michael Catanzaro's avatar
      Fix comment added in previous commit · 8d57c7a3
      Michael Catanzaro authored
      I described the ownership incorrectly.
      8d57c7a3
    • Michael Catanzaro's avatar
      Fix crash on exit when tab sync enabled · 3bd5b4d7
      Michael Catanzaro authored and Marge Bot's avatar Marge Bot committed
      In f9e74d51 I added an assertion that
      causes Epiphany to crash on exit if the EphyShell global object has been
      leaked. This assertion is being triggered whenever Firefox Sync tab
      synchronization is enabled. It happens due to a circular reference.
      Break it.
      
      This bug has existed since the Firefox Sync support was added. The
      assertion proves its value once again.
      
      A better solution might be to make the EphyTabsCatalog a separate object
      instead of an interface implemented by EphyEmbedShell. I might or might
      not explore that in a follow-up commit, because EphyOpenTabsManager
      shouldn't have to know about implementation details of the
      EphyTabsCatalog.
      
      Part-of: <!1463>
      3bd5b4d7
  3. Mar 25, 2024
    • Michael Catanzaro's avatar
      sync-service: switch to SecretRetrievable API · 0ca88881
      Michael Catanzaro authored
      secret_password_search_finish() returns a list of SecretRetrievable
      objects. We incorrectly assume it returns a list of SecretItems.
      SecretItem seems to be the only public implementation of
      SecretRetrievable, but clearly it's not the only implementation.
      
      We get to the same end result -- a SecretValue object -- either way, but
      SecretRetrievable has an async interface, so the code is a bit more
      complicated now. It's surely for the better.
      
      Fixes #1361 (probably) (hopefully :)
      
      Part-of: <!1462>
      0ca88881
    • Michael Catanzaro's avatar
      Add Not Now option to save password? popover · 1fdabb08
      Michael Catanzaro authored and Marge Bot's avatar Marge Bot committed
      We lost this option in the transition from info bars to the
      popover-based UI. If you don't want to make any decision on whether or
      not to save the password, then your only option is to click outside the
      popover, which causes the password save request to stick around
      indefinitely.
      
      Permission requests have the same problem, but I think I'm OK with that
      as they occur less-frequently, and it's easy to change permissions later
      if desired, and it's usually easy to decide whether to allow or deny a
      permission request. But for passwords, you want to click "Not Now"
      frequently, e.g. whenever creating an account for a new service (since
      passwords are associated with form elements, and you surely want to save
      the password for the login page, not the account creation page). Since
      this is a relatively frequent workflow, we should make it easier.
      
      Fixes #2291
      
      Part-of: <!1461>
      1fdabb08
    • Michael Catanzaro's avatar
      Don't delay internal Epiphany pages on adblocker initialization · 78a30bac
      Michael Catanzaro authored and Marge Bot's avatar Marge Bot committed
      When launching Epiphany for the first time, with no adblock filters
      previously downloaded, it takes several seconds to display the overview
      page. There's no good reason for this delay. We should only wait for the
      adblocker on normal web pages, not internal pages.
      
      Fixes #2267
      
      Part-of: <!1460>
      78a30bac
  4. Mar 24, 2024
  5. Mar 23, 2024
  6. Mar 22, 2024
    • Michael Catanzaro's avatar
      Properly store window size in GSettings · 1e753834
      Michael Catanzaro authored and Marge Bot's avatar Marge Bot committed
      The window size is stored in two places:
      
       * The session state, for every saved window
       * GSettings, as a fallback
      
      It has to be stored in GSettings because the user might not save any
      session state at all, or might close the final tab causing there to be
      no windows stored in the session state file.
      
      The existing code reads the window size from GSettings properly, but at
      some point long ago the code to write the window size got broken. This
      was reported more than 5 years ago but I didn't investigate it until
      now....
      
      Fixes #525
      
      Part-of: <!1459>
      1e753834
    • Michael Catanzaro's avatar
      window: clean up dispose/finalize a bit · 1e881ca4
      Michael Catanzaro authored
      Part-of: <!1458>
      1e881ca4
  7. Mar 21, 2024
  8. Mar 20, 2024
  9. Mar 19, 2024
    • Philippe Normand's avatar
      Canary: Environment variable tweaks · d9244f5e
      Philippe Normand authored
      Disable the internal WebKit audio mixer because in some cases it triggers audio
      glitches. The GStreamer va plugin no longer need to be upranked because the
      WebKit SDK ships GStreamer 1.24 which already promoted this plugin for auto-plugging.
      
      Part-of: <!1456>
      d9244f5e
  10. Mar 18, 2024
  11. Mar 17, 2024
  12. Mar 16, 2024
  13. Mar 15, 2024
  14. Mar 14, 2024
  15. Mar 13, 2024
  16. Mar 11, 2024
  17. Mar 10, 2024
  18. Mar 08, 2024