Danial Behzadi authored May 04, 2024 and Administrator committed May 04, 2024

(cherry picked from commit af55c949)

Jamie Gravendeel authored May 02, 2024 and Marge Bot committed May 03, 2024

Part-of: <!1476>

Hugo Carvalho authored May 02, 2024 and Administrator committed May 02, 2024

(cherry picked from commit d49215e9)

When glib-networking is not installed, the response body will be empty.
We need to handle this case. We'd need to do so regardless, because the
response is untrusted input. Servers can send empty responses.

Fixes #2320

Michael Catanzaro authored Apr 30, 2024 and Marge Bot committed May 02, 2024

Part-of: <!1473>

Michael Catanzaro authored Apr 30, 2024 and Marge Bot committed May 02, 2024

This is a regression from 24a80bb5.
Oops!

Part-of: <!1473>

Michael Catanzaro authored Apr 30, 2024 and Marge Bot committed May 02, 2024

The web app manifest is untrusted input. We can't just assume success
when parsing it.

Part-of: <!1473>

Jamie Gravendeel authored May 01, 2024 and Michael Catanzaro committed May 01, 2024

Part-of: <!1475>

Part-of: <!1472>

Michael Catanzaro authored Apr 26, 2024 and Marge Bot committed Apr 27, 2024

This is a regression from 78a30bac. It's
actually expected that a web view may not have a URL yet when it's being
opened from JavaScript. We have to guard against this condition.

Part-of: <!1469>

Michael Catanzaro authored Apr 26, 2024 and Marge Bot committed Apr 27, 2024

It's possible for JavaScript to open a tab with an empty URL or a data
or blob URL. It's not possible to restore such a tab from session state
because WebKitGTK reloads the entire page (unlike WebKit on macOS). So
don't save them at all.

Part-of: <!1470>

Michael Catanzaro authored Apr 26, 2024 and Marge Bot committed Apr 27, 2024

Part-of: <!1470>

Michael Catanzaro authored Apr 26, 2024 and Marge Bot committed Apr 27, 2024

We had a comment explaining what is going on here, but it's where the
function is called rather than where it's implemented, which isn't a
great place for it. So I wasted my time writing a new version of the
comment. Move and update it.

Part-of: <!1470>

Michael Catanzaro authored Apr 26, 2024 and Marge Bot committed Apr 27, 2024

JavaScript can open blob URLs as the main resource, just like data URLs
or even empty URLs. These cannot be saved into the session state, but
they are not a bug and shouldn't trip our session state checker.

Part-of: <!1470>

Michael Catanzaro authored Apr 26, 2024 and Marge Bot committed Apr 27, 2024

This doesn't change anything, just makes the code a bit simpler.

Part-of: <!1470>

Efstathios Iosifidis authored Apr 27, 2024 and Administrator committed Apr 27, 2024

(cherry picked from commit efc79af8)

This reverts commit f23c52de.

We're verified!

The set_parent used to happen in the main window's `show` handler but at
that point the main window isn't mapped yet under Wayland (as there's no
buffer attached):

  [3694190.560]  -> xdg_toplevel@46.set_parent(nil)
  [3694198.318]  -> xdg_toplevel@53.set_parent(xdg_toplevel@46)
  [3694251.530]  -> wl_surface@48.attach(wl_buffer@60, 0, 0)

Conformant wayland compositors should ignore the `set_parent` in that
case. Citing the xdg-shell's set_parent() documentation:

  > Only mapped surfaces can have child surfaces. Setting a parent which
  > is not mapped is equivalent to setting a null parent. If a surface
  > …

Thus the default browser dialog would appear below the main window (but
still grabbing all input hence making epiphany look "frozen").

Moving the gtk_window_present() into idle fixes this.

Closes: World/Phosh/phoc#367

Miloš Popović authored Apr 06, 2024 and Administrator committed Apr 06, 2024

(cherry picked from commit bb5f5d8d)

Miloš Popović authored Apr 06, 2024 and Administrator committed Apr 06, 2024

(cherry picked from commit 606252bd)

kramo authored Mar 30, 2024 and Marge Bot committed Mar 30, 2024

Part-of: <!1466>

Juliano de Souza Camargo authored Mar 27, 2024 and Administrator committed Mar 27, 2024

(cherry picked from commit cf5f6eeb)

Fixes: #2178
Part-of: <!1443>

Michael Catanzaro authored Mar 27, 2024 and Marge Bot committed Mar 27, 2024

I messed up the previous fix in !1463. The EphyTabsCatalog is no longer
supposed to be owned, to avoid a circular ref. But we still unref it.
Oops.

Part-of: <!1465>

I forgot to return early on the error paths. Oops. This restores the
original behavior. Fixes !1462

I described the ownership incorrectly.

Michael Catanzaro authored Mar 25, 2024 and Marge Bot committed Mar 26, 2024

In f9e74d51 I added an assertion that
causes Epiphany to crash on exit if the EphyShell global object has been
leaked. This assertion is being triggered whenever Firefox Sync tab
synchronization is enabled. It happens due to a circular reference.
Break it.

This bug has existed since the Firefox Sync support was added. The
assertion proves its value once again.

A better solution might be to make the EphyTabsCatalog a separate object
instead of an interface implemented by EphyEmbedShell. I might or might
not explore that in a follow-up commit, because EphyOpenTabsManager
shouldn't have to know about implementation details of the
EphyTabsCatalog.

Part-of: <!1463>