Michael Catanzaro authored May 16, 2024 and Marge Bot committed May 17, 2024

Critical warnings should only be used to indicate programmer error. By
default, they are "soft assertions" that allow program execution to
continue even though we know the process is no longer operating
correctly because a bug has occurred. This is a bad default. Let's crash
instead, to make it easier to debug the problem, encourage bug reports,
and downgrade any code execution issues into denial of service.

Part-of: <!1377>

Part-of: <!1484>

Notably, this means we have to use the PrefsAppearancePage object in its
callbacks, so now we need a cancellable.

Part-of: <!1484>

We don't need two different ways to do the same thing.

Part-of: <!1484>

Fixes #2301, hopefully. We are failing to launch these files when their
MIME types are detected as application/x-zerosize. That's unhelpful. We
already know what MIME type we should use, so no need to detect it from
the file contents.

Part-of: <!1484>

ephy_file_launch_handler() has been able to handle portals for a long
time.

Part-of: <!1484>

We can use ephy-flatpak-utils to launch URIs via portal instead, which
is more explicit.

Part-of: <!1484>

Michael Catanzaro authored May 15, 2024 and Marge Bot committed May 16, 2024

The code that checks for duplicate notification attempts to remove the
newly-created notification from the container by mistake. It hasn't been
added to the widget hierarchy yet. Maybe the code here was trying to
remove the original notification, but it's probably best to just discard
the new one.

Fixes #2344

Part-of: <!1487>

Michael Catanzaro authored May 09, 2024 and Marge Bot committed May 16, 2024

Part-of: <!1481>

Michael Catanzaro authored May 09, 2024 and Marge Bot committed May 16, 2024

The current code just doesn't work correctly if the command has only one
modifier. E.g. Ctrl+Period gets converted to just <Ctrl> instead of
<Ctrl>period. The problem is (a) if i == 1 and the key is not a
modifier, we return NULL, and also (b) with that fixed, if i == 1 we
improperly skip the second half of the loop by always executing the
continue statement.

Part-of: <!1481>

pxrb authored May 07, 2024 and Marge Bot committed May 16, 2024

Fixes #2331

Part-of: <!1481>

Part-of: <!1486>

Leônidas Araújo authored May 15, 2024 and Administrator committed May 15, 2024

(cherry picked from commit ab0b7105)

Jordi Mas authored May 15, 2024 and Administrator committed May 15, 2024

(cherry picked from commit d9e79190)

Jan-Michael Brummer authored May 13, 2024 and Marge Bot committed May 13, 2024

Reader mode button couldn't be toggled due to recent clear button
change. Fix it.

Fixes: #2333
Part-of: <!1483>

Michael Catanzaro authored May 03, 2024 and Marge Bot committed May 13, 2024

We should mark GError error messages for translation unless it's obvious
from the code that they will not be displayed to users in the UI. In
general, we always want to translate errors that will be shown in the
UI. (But we do not translate command line warnings.)

Part-of: <!1478>

We pass the result of ephy_web_application_get_desktop_id_list() --
which may be NULL -- to
ephy_web_app_provider_complete_get_installed_apps(), which does not
accept NULL. Let's return an empty list instead of NULL.

https://bugzilla.redhat.com/show_bug.cgi?id=2278829

Part-of: <!1477>

Scrambled 777 authored May 12, 2024 and Administrator committed May 12, 2024

(cherry picked from commit ce71814b)

Christian Kirbach authored May 10, 2024 and Administrator committed May 10, 2024

(cherry picked from commit ff8fac3f)

kramo authored May 05, 2024 and Marge Bot committed May 06, 2024

Fixes #2325

Part-of: <!1479>

Aurimas Černius authored May 06, 2024 and Administrator committed May 06, 2024

(cherry picked from commit 7236f871)

Danial Behzadi authored May 04, 2024 and Administrator committed May 04, 2024

(cherry picked from commit af55c949)

Jamie Gravendeel authored May 02, 2024 and Marge Bot committed May 03, 2024

Part-of: <!1476>

Hugo Carvalho authored May 02, 2024 and Administrator committed May 02, 2024

(cherry picked from commit d49215e9)

When glib-networking is not installed, the response body will be empty.
We need to handle this case. We'd need to do so regardless, because the
response is untrusted input. Servers can send empty responses.

Fixes #2320

Michael Catanzaro authored Apr 30, 2024 and Marge Bot committed May 02, 2024

Part-of: <!1473>

Michael Catanzaro authored Apr 30, 2024 and Marge Bot committed May 02, 2024

This is a regression from 24a80bb5.
Oops!

Part-of: <!1473>

Michael Catanzaro authored Apr 30, 2024 and Marge Bot committed May 02, 2024

The web app manifest is untrusted input. We can't just assume success
when parsing it.

Part-of: <!1473>

Jamie Gravendeel authored May 01, 2024 and Michael Catanzaro committed May 01, 2024

Part-of: <!1475>

Part-of: <!1472>

Michael Catanzaro authored Apr 26, 2024 and Marge Bot committed Apr 27, 2024

This is a regression from 78a30bac. It's
actually expected that a web view may not have a URL yet when it's being
opened from JavaScript. We have to guard against this condition.

Part-of: <!1469>

Michael Catanzaro authored Apr 26, 2024 and Marge Bot committed Apr 27, 2024

It's possible for JavaScript to open a tab with an empty URL or a data
or blob URL. It's not possible to restore such a tab from session state
because WebKitGTK reloads the entire page (unlike WebKit on macOS). So
don't save them at all.

Part-of: <!1470>