Committed in the wrong branch !

This reverts commit 9aadd413.

Fixes bug 666442.

Alexandre Rostovtsev authored Sep 30, 2011 and David King committed Dec 18, 2011

Fix numerous vinagre_utils_* and vinagre_dirs_* implicit function
declarations by generating a header (vinagre/vinagre-vala.h) from the
vala source and including it in half the .c files in the source tree.

Add the vinagre-vala.h to dist_noinst_DATA to make sure it goes in the
release tarballs, and to BUILT_SOURCES to ensure that it is generated
before the C sources that #include it are compiled. Add
-I$(top_srcdir)/vinagre to CPPFLAGS so that vinagre-vala.h is picked up
in out-of-tree builds.

Unfortunately, automake does not support per-target VALAFLAGS. We cannot
simply add a "--header vinagre/vinagre-vala.h" option to AM_VALAFLAGS
or VALAFLAGS because if we ever use a .vala file in another target (such
as one of the vinagre plugins), vinagre-vala.h will get clobbered.

The only way to prevent valac from running multiple times and safely
support parallel make without adding a ticking time bomb that could
clobber vinagre-vala.h is to manually write a stamp target for the vala
sources used in libvinagre, and manually pass a --header argument to
valac in the rule for the stamp.

Pick "vinagre_vala.stamp" as the name for it to avoid potential
collisions with automake's vala stamp naming conventions, and make sure
to add the stamp to dist_noinst_DATA so that people who download the
source tarball are not forced to use vala to build vinagre.

Also, add an explicit rule for generating vinagre-vala.h for those who
do not have it and are building from git (otherwise, make will fail due
to the presense of vinagre-vala.h in dist_noinst_DATA).

Since vala sources are not in vinagre_vinagre_SOURCES any more, we have
to add them to dist_noinst_DATA so that they are added to release
tarballs.

The switch to yelp-tools for building the Mallard help uncovered a
couple of invalid translations, due to incorrect closing tags.

Version 0.24 or greater of pkg-config is required in order to avoid the
duplicate AC_SUBST macro calls for PKG_CHECK_MODULES substitutions.

Yaakov Selkowitz authored Dec 02, 2011 and David King committed Dec 18, 2011

Cygwin uses gio-unix, not gio-windows.

Cygwin has posix_openpt but not getpt, which is nonstandard. Either will
work in pty_open.c, but in vinagre-ssh.c, USE_PTY is determined by
HAVE_GRANTPT, which is true on Cygwin. Using grantpt as the determining
factor across the board prevents any chance of error.

Signed-off-by: Yaakov Selkowitz <yselkowitz@users.sourceforge.net>

Yaakov Selkowitz authored Dec 02, 2011 and David King committed Dec 18, 2011

Relying on linking the plugins dynamically into the executable is not
portable: it works only on ELF and even then only without -Wl,--as-needed.

Instead, the plugins must be statically linked into the main executable,
in which case there is no further reason for using libtool, so remove it.

Signed-off-by: Yaakov Selkowitz <yselkowitz@users.sourceforge.net>

Jens Georg noticed that the ‘Authenticate’ button used an image that was
very large, causing it to expand too much horizontally. The image was
incorrectly set to be Gtk.IconSize.DIALOG, which should have been
Gtk.IconSize.BUTTON.

Tristan Schmelcher authored Oct 18, 2011 and David King committed Oct 18, 2011

Optionally hold the slave PTY open in the parent. Needed to prevent EIO
from read() on the master if exec'ing a program that enumerates and
closes open fds before opening /dev/tty (ssh). Partially fixes bug
644432.

Alexandre Rostovtsev authored Sep 30, 2011 and David King committed Oct 01, 2011

Use gtk_widget_override_background_color() instead of deprecated
gtk_widget_modify_bg(). Fixes an implicit function declaration warning
when building with GTK_DISABLE_DEPRECATED, bug 660531.

Alexandre Rostovtsev authored Sep 30, 2011 and David King committed Oct 01, 2011

Fix implicit declaration of vinagre_vnc_connection_set_depth_profile()
in vinagre-tube-handler.c by including vinagre-vnc-connection.h. Fixes
bug 660531.

As suggested by Christian Persch in bug 625895.

Jasper Lievisse Adriaanse authored Sep 27, 2011 and David King committed Sep 27, 2011

Fixes bug 660274.

Frederic Peters authored Sep 21, 2011 and David King committed Sep 26, 2011

Fixes bug 659758.