Florian Weimer authored Jan 03, 2024 and Bastien Nocera committed Mar 14, 2024

Return FALSE instead of NULL, to match the gboolean return type

Fixes a C type error and compilation error with GCC 14 and Clang.

By disabling video site checks.

NOTICE: Future-deprecated features used:
 * 1.1.0: {'"boolean option" keyword argument "value" of type str'}

Remove TotemPlParserMetadata as a separate type. It will only be
exposes in C, not in bindings.

This fixes gjs warnings such as:
(gjs:2781): Gjs-WARNING **: 21:48:14.325: JS ERROR: Error: No introspection information found for TotemPlParserMetadata

Closes: #22

We'll want to use it earlier in the file.

As per the API documentation, and the code when it still used
g_simple_async_result_*, totem_pl_parser_parse_finish() should return a
TotemPlParserResult of TOTEM_PL_PARSER_RESULT_CANCELLED when parsing is
cancelled.

But the port to GTask changed that, as all the errors caught during
parsing would return -1 as the error code, which isn't a valid
TotemPlParserResult value.

As the only way for totem_pl_parser_parse_finish() to have a GError set
is for the call to be cancelled, catch that and correct the return
value.

Fixes: 45664037 ("plparse: Port from GSimpleAsyncResult to GTask")
Closes: #38

The function doesn't return TRUE/FALSE, but a TotemPlParserResult.

../../../../Projects/jhbuild/totem-pl-parser/plparse/totem-pl-parser-decode-date.c: In function ‘get_tzone’:
../../../../Projects/jhbuild/totem-pl-parser/plparse/totem-pl-parser-decode-date.c:322:25: warning: ‘g_time_zone_new’ is deprecated: Use 'g_time_zone_new_identifier' instead [-Wdeprecated-declarations]
  322 |                         return g_time_zone_new (tzone);
      |                         ^~~~~~
In file included from /usr/include/glib-2.0/glib/gdatetime.h:31,
                 from /usr/include/glib-2.0/glib/gbookmarkfile.h:26,
                 from /usr/include/glib-2.0/glib.h:37,
                 from ../../../../Projects/jhbuild/totem-pl-parser/plparse/totem-pl-parser-decode-date.h:20,
                 from ../../../../Projects/jhbuild/totem-pl-parser/plparse/totem-pl-parser-decode-date.c:24:
/usr/include/glib-2.0/glib/gtimezone.h:57:25: note: declared here
   57 | GTimeZone *             g_time_zone_new                                 (const gchar *identifier);
      |                         ^~~~~~~~~~~~~~~
../../../../Projects/jhbuild/totem-pl-parser/plparse/totem-pl-parser-decode-date.c:341:25: warning: ‘g_time_zone_new’ is deprecated: Use 'g_time_zone_new_identifier' instead [-Wdeprecated-declarations]
  341 |                         return g_time_zone_new (tzone);
      |                         ^~~~~~
In file included from /usr/include/glib-2.0/glib/gdatetime.h:31,
                 from /usr/include/glib-2.0/glib/gbookmarkfile.h:26,
                 from /usr/include/glib-2.0/glib.h:37,
                 from ../../../../Projects/jhbuild/totem-pl-parser/plparse/totem-pl-parser-decode-date.h:20,
                 from ../../../../Projects/jhbuild/totem-pl-parser/plparse/totem-pl-parser-decode-date.c:24:
/usr/include/glib-2.0/glib/gtimezone.h:57:25: note: declared here
   57 | GTimeZone *             g_time_zone_new                                 (const gchar *identifier);
      |                         ^~~~~~~~~~~~~~~

The "volatile" keyword was removed.

In file included from /usr/include/glib-2.0/glib/gthread.h:32,
                 from /usr/include/glib-2.0/glib/gasyncqueue.h:32,
                 from /usr/include/glib-2.0/glib.h:32,
                 from ../../../../Projects/jhbuild/totem-pl-parser/plparse/totem-pl-parser.c:128:
../../../../Projects/jhbuild/totem-pl-parser/plparse/totem-pl-parser.c: In function ‘totem_pl_parser_get_type’:
/usr/include/glib-2.0/glib/gatomic.h:113:5: warning: argument 2 of ‘__atomic_load’ discards ‘volatile’ qualifier [-Wincompatible-pointer-types]
  113 |     __atomic_load (gapg_temp_atomic, &gapg_temp_newval, __ATOMIC_SEQ_CST); \
      |     ^~~~~~~~~~~~~
/usr/include/glib-2.0/glib/gthread.h:260:7: note: in expansion of macro ‘g_atomic_pointer_get’
  260 |     (!g_atomic_pointer_get (location) &&                             \
      |       ^~~~~~~~~~~~~~~~~~~~
../../../../Projects/jhbuild/totem-pl-parser/plparse/totem-pl-parser.c:307:13: note: in expansion of macro ‘g_once_init_enter’
  307 |         if (g_once_init_enter (&g_define_type_id__volatile))
      |             ^~~~~~~~~~~~~~~~~
../../../../Projects/jhbuild/totem-pl-parser/plparse/totem-pl-parser.c: In function ‘totem_pl_parser_metadata_get_type’:
/usr/include/glib-2.0/glib/gatomic.h:113:5: warning: argument 2 of ‘__atomic_load’ discards ‘volatile’ qualifier [-Wincompatible-pointer-types]
  113 |     __atomic_load (gapg_temp_atomic, &gapg_temp_newval, __ATOMIC_SEQ_CST); \
      |     ^~~~~~~~~~~~~
/usr/include/glib-2.0/glib/gthread.h:260:7: note: in expansion of macro ‘g_atomic_pointer_get’
  260 |     (!g_atomic_pointer_get (location) &&                             \
      |       ^~~~~~~~~~~~~~~~~~~~
../../../../Projects/jhbuild/totem-pl-parser/plparse/totem-pl-parser.c:2784:13: note: in expansion of macro ‘g_once_init_enter’
 2784 |         if (g_once_init_enter (&g_define_type_id__volatile))
      |             ^~~~~~~~~~~~~~~~~

So we know the license

Seeing as the dist processing runs the tests too...

Refer: https://podcasts.apple.com/us/genre/podcasts/id26 for full list
of genres supported by <itunes:category> tag.

Considering "MG = Main Genre" and "SG = Sub Genre", iTunes genre can
be of the following 2 basic forms:

1. MG ( E.g. Business )
2. MG/SG ( E.g. Science/Astronomy )

The first such genre value is assigned to TOTEM_PL_PARSER_FIELD_GENRE
metadata field

Combinations of the above 2 forms are valid too:

1. MG,MG/SG etc ( E.g. Music,Leisure/Hobbies )
2. MG1/SG1,MG2/SG2 etc ( E.g. Business/Investing,Education/Self Improvement )

The full genre value is assigned to TOTEM_PL_PARSER_FIELD_GENRES
metadata field

Build failed on systems using -Os cflags with:
 - totem-pl-parser.c:1776:14: error: ‘ret’ may be used uninitialized in this function [-Werror=maybe-uninitialized]

Can be fetch from the git archives if needed.

crvi authored Mar 03, 2021 and Bastien Nocera committed Jun 25, 2021

Note that this changes the result of the
test_parsing_needle_carriage_return() ATOM test which now returns a
single entry.

We don't need to check whether links in RSS feeds are videosite links
unless the application requested that we do, by enabling recursive
parsing.

Closes: #25

Contact can be made through GitLab.