Balló György authored Sep 28, 2023 and Corey Berla committed Mar 08, 2024

We have to add the tick callback to the overlay widget instead of the main
widget, otherwise the position bar is not updated in fullscreen mode when the
gtksink is used. This happens because we move the overlay between the main and
fullscreen windows, and we did't get the events when the overlay is outside of
the main widget.

There's a bug where the call to InstallProvideFiles can end up in an
infinite loop because the callback is called prematurely which ends
up calling load_libreoffice.

Modify2 has been around for many years, removes an unnecessary call
to get xid (which is incorrectly called on Wayland).  It appears that
Modify2 doesn't end up in the infinite loop.

See: gnome-software@88e90c7e

Fixes: #60

We pass unescaped text to GtkLabel.set_markup.  For type, size,
and date formatted, this is probably fine, but it causes problems
with filenames.  If, for example, the filename has an "&" in it,
the filename field will be unavailable.

Yaakov Selkowitz authored Dec 20, 2023 and Corey Berla committed Dec 20, 2023

webkitgtk is not required to build libsushi and is only used by the HTML
viewer, so allow sushi to work even in its absence.

str.replace requires 0.58

The readme hasn't been updated in 11 years.  Update to reflect the
expected org.gnome.NautilusPreviewer2 interface, the sushi binary,
and the nightly flatpak.

The ParentHandle property represents the handle (set by ShowFile)
of the current parent of the sushi window.  This will be helpful
for consumers to make sure they are acting on the corret window
from emmissions from SelectionEvent.

I missed this in [1].  Without this change, the information
won't be reflected properly in the flatpak config.

[1] 1eaa5226

The amazon url / service is no longer available.  Musicbrainz is
already in use and appears to be tightly integrated with
coverartarchive.org, use that instead.

libsoup was bumped to 3.0 in f73bd949
but the code was never ported to the proper API's.

Fixes: #94

We are returning none for GstTagLists.  In the audio viewer this is
causing problems because GJS attempts to free an already freed
object.  Return full references.

Fixes: #66

vala support was removed from the GNOME runtime in [1]

[1] gnome-build-meta@6a9ed593

Fixes: #110

The keybinding signal for the text viewer doesn't work because it is
set to not be focusable.  This was originally set as part of a
workaround to block the right click menu in [1]. That commit was
then effectively reverted in [2] which was also reverted in [3].

[1] adea213e
[2] 47c7de68
[3] d5692982

The evince viewer doesn't have a context menu for copying text, so
let's add a keyboard shortcut at a minimum.

Related: #70

Nelson Ben authored Jun 01, 2023 and Corey Berla committed Jun 01, 2023

MainWindow is set to be shown centered on screen, but if
we show it before the contained Renderer is ready (i.e.
when it has gotten its final width and height) then
that new empty window will be centered for a moment but
just after that, the window gets resized to make room for
the contained Renderer final dimensions.

This window enlargement ruins the centering, because
the window x,y origin is still the same.

The Evince Renderer was not suffering this bug because
it subclasses GtkScrolledWindow which probably has a
different handling for that. But the Image Renderer which
just subclasses GtkDrawingArea was suffering this bug.

The fix is just to make sure we don't show the MainWindow
until the Renderer has signaled it's ready (i.e. it has
its definitive width and height).

Although we want to have MainWindow not visible initially,
we still had to call show_all() on it briefly so that
Renderers which use Sushi.MediaBin (like gst.js and audio.js)
don't show an extra window, that was probably the original
motivation for showing the window before 'ready' signal.

Closes #93

Nelson Ben authored Jun 01, 2023 and Corey Berla committed Jun 01, 2023

GDK returns different monitor width/height geometries
in x11 vs wayland when the scale factor is >1.  This is a bit
of a hack, but it fixes the issue we are having with the
current methodology.

Closes: #91

Regardless of if this was incorrectly set manually through dconf or
somehow else, we should properly handle this scenario.

The gsettings schema/setting is
org.gnome.desktop.wm.preferences button-layout

Fixes: #36