page_initialized() was freeing the error it was passed, but so was its
caller.

(cherry picked from commit 9fae902c)

We create the secret agent with 'auto-register' true. Hence
explicitly registering results in a race due to a bug in libnm.

The libnm bug was fixed by commit 86ffea8004980b9ab931d3f172e89fe192af6cd0 .

https://bugzilla.gnome.org/show_bug.cgi?id=727923



Signed-off-by: Thomas Haller <thaller@redhat.com>
(cherry picked from commit d540a4e5)

GTK+ 3.10 and lower capped labels with wrapping set, but without
max-width-chars set, from taking up the entire screen width.  GTK+
git master no longer does that, so some of our labels never wrap
and the dialogs look ugly.

GTK+ 3.10 hack:
https://git.gnome.org/browse/gtk+/commit/?h=gtk-3-10&id=2436627eb4644234a9e577538ec334d224e3d2be

(cherry picked from commit f35b9267)

First, don't autostart ModemManager since the applet is only using
ModemManager for information and not for controlling modems.  Leave
that to system services (like systemd or upstart).  Requesting
autostart can block for long periods of time in some situations,
like if the process hangs during startup or isn't actually present
on the disk.

Second, make ModemManager initialization asynchronous to avoid any
other initialization blockage.  The applet only uses MM for info
about devices NM already knows about, so it's not critical to
applet startup.

https://bugzilla.gnome.org/show_bug.cgi?id=729334
(cherry picked from commit 408b88cc)

Jiří Klimeš authored Apr 22, 2014 and Dan Williams committed Jun 09, 2014

https://bugzilla.redhat.com/show_bug.cgi?id=1089765
(cherry picked from commit 3b7c84a9)

Dan Winship authored Jan 03, 2014 and Dan Williams committed Jun 09, 2014

Having CEPolkitButtons be sometimes ellipsized and sometimes not
causes the window width to change under some localizations.

After some discussion, it was decided that having to deal with an
authentication dialog does not really constitute the kind of
"additional input" that ellipses are meant to indicate, so just remove
them.

https://bugzilla.gnome.org/show_bug.cgi?id=642688
(cherry picked from commit 0fd8afcf)

GTK+ 3.10 and lower capped labels with wrapping set, but without
max-width-chars set, from taking up the entire screen width.  GTK+
git master no longer does that, so some of our labels never wrap
and the dialogs look ugly.

Noticed by Michael Biebl

GTK+ 3.10 hack:
https://git.gnome.org/browse/gtk+/commit/?h=gtk-3-10&id=2436627eb4644234a9e577538ec334d224e3d2be

Backported from 7c5b4bd5

Iain Lane authored Dec 03, 2013 and Dan Williams committed Apr 25, 2014

Patch by Tiago Porangaba

https://bugzilla.gnome.org/show_bug.cgi?id=663774

Otherwise if something else holds a reference to info->mm_modem, we
could end up triggering signal handlers after we've disposed of
'info'.

Jiří Klimeš authored Apr 24, 2014 and Dan Williams committed Apr 25, 2014

https://bugzilla.redhat.com/show_bug.cgi?id=1090575

Since glib 2.39, GSettings verifies the path validity [0].
A valid path begins and ends with '/' and does not contain two
consecutive '/'. We were missing the trailing '/', leading to an assert
when trying to load the org.gnome.nm-applet.eap schema.

[0] https://git.gnome.org/browse/glib/commit/?id=6568843624e9f46a3c51cd8c1a6670896a48f1fb

Possible mis-merge of 8f49c2c7.  If the modem doesn't have a device
identifier or required unlock isn't a PIN, the second call to
unlock_dialog_new() would have no effect because unlock_dialog_new()
just returns if a dialog is already showing.  But if the PIN could
be in the keyring, the search would be started and the dialog would
be shown anyway, which is wrong.

Thomas Haller authored Sep 27, 2013 and Dan Williams committed Apr 03, 2014

The return value of gtk_editable_get_chars is owned by the caller, so
calling g_strdup leaks memory.

Signed-off-by: Thomas Haller <thaller@redhat.com>

Since the plugin API no longer exists.

(Also, fix the configure output to not print two "checking for"
messages.)

https://bugzilla.gnome.org/show_bug.cgi?id=720108

Since LIBDIR of nm-applet and the VPN plugins aren't necessarily the
same, use the paths as specified by the VPN plugins and only
reconstruct the path if it is not absolute or we fail to load the plugin

This reverts commit 3021ce12.

For EAP connections it usually does not make sense to validate the
certificate with the system CA store. User mostly either want to
provide the one exact certificate (ca-cert) or don't do any validation
at all.

Previously, nm-connection-editor set the property system-ca-certs=true
for new connections, but there was no field in the UI to unset this
setting. This effectively meant, that if the user did not provide a
valid ca-cert (or put the certificate in the system wide store) the
connection could not be established.

Change the behavior, so that new connections created by nm-c-e don't
have system-ca-certs set.

The system-ca-certs property cannot be configured from the UI and nm-c-e
will not touch it in existing connection. This makes sense, because referring
to the system store is not a common use case. On the other hand, users who
*really* want to use this option, can do so using e.g. nmcli. In that case,
nm-c-e will not tamper with the setting.

Connections that were created by older versions of nm-c-e might be
unable to connect. The system-ca-certs option can be unset with:

  $ nmcli connection modify id "$ID" 802-1x.system-ca-certs false

https://bugzilla.gnome.org/show_bug.cgi?id=702608



Signed-off-by: Thomas Haller <thaller@redhat.com>
(cherry picked from commit c798c40c)

and define a log domain so you can use G_MESSAGES_DEBUG=nm-applet to
enable them.

https://bugzilla.gnome.org/show_bug.cgi?id=709419

Change the shell interaction code so that we only create an
NMSecretAgent if the shell is not running, and we permanently destroy
it if the shell ever starts up.

Revert the change to not run nm-applet under GNOME 3 now, since it
should be safe to do so, and this solves the problem for users who
need the GSM PIN unlock dialog.

https://bugzilla.gnome.org/show_bug.cgi?id=709419

"response" signal is sufficient. It is issued for dialog closing too (Cancel,
Esc, Alt-F4, ...).

Trying to destroy dialog as a response to "close" signal caused:
GLib-GObject-CRITICAL **: g_object_ref: assertion `G_IS_OBJECT (object)' failed

https://bugzilla.redhat.com/show_bug.cgi?id=990906