Skip to content
  1. Mar 11, 2012
  2. Mar 07, 2012
  3. Mar 03, 2012
  4. Mar 02, 2012
  5. Feb 23, 2012
  6. Feb 19, 2012
    • Dodji Seketeli's avatar
      Fix test-core.cc · 109f599e
      Dodji Seketeli authored
      	* tests/test-core.cc (main): Use
      	debugger_utils::load_debugger_iface_with_confmgr to ensure the
      	configuration manager is loaded too.
      	* Makefile.am (runtestcore): Link this executable with
      	libdebuggerutils.la.
      109f599e
    • Dodji Seketeli's avatar
      Better default directory in core loading dialog · 17965075
      Dodji Seketeli authored
      	* src/persp/dbgperspective/nmv-load-core-dialog.cc
      	(Loadcoredialog::Priv::Priv): Set the current folder of the file
      	chooser dialogs to the current directory.
      17965075
    • Dodji Seketeli's avatar
      Add a --load-core command line switch · 524c465f
      Dodji Seketeli authored
      	* src/main.cc (gv_core_path): New global variable that holds the
      	path to the core file to load.
      	(static GOptionEntry entries<load-core>): New struct to describe
      	the new command line switch.
      	(parse_command_line): Fix a typo in a comment.  Handle cases where
      	the user forgets to provide the path to the binary that generated
      	the core file.
      	(load_debugger_perspective): Factorize out of ...
      	(process_gui_options): ... here.  Handle the new option.
      524c465f
    • Dodji Seketeli's avatar
      667723 - can't load core dump · e2f887c5
      Dodji Seketeli authored
      	* src/persp/dbgperspective/nmv-call-stack.h
      	(CallStack::update_stack): Take a parameter to select the top most
      	frame of the call stack.
      	* src/persp/dbgperspective/nmv-call-stack.cc
      	(CallStack::Priv::set_current_frame):  Split from ...
      	(CallStack::Priv::update_selected_frame): ... here.
      	(CallStack::Priv::{on_frames_listed, update_call_stack}): Take a
      	parameter to select the top most frame of the call stack.  Pass it
      	to the new set_current_frame.
      	(CallStack::Priv::finish_update_handling): Adjust.
      	(CallStack::update_stack): Take a parameter to select the top most
      	frame of the call stack.
      	* src/persp/dbgperspective/nmv-dbg-perspective.cc
      	(DBGPerspective::load_core_file): Don't just instruct the debugger
      	to list call frames.  No client code is listening to update.
      	Rather, delegate that job to the call stack widget.
      e2f887c5
    • Dodji Seketeli's avatar
      Add more logging to nmv-gdb-engine.cc · bc44795c
      Dodji Seketeli authored
      	* src/dbgengine/nmv-gdb-engine.cc
      	(GDBEngine::Priv::{launch_gdb_on_core_file, load_core_file}): Add
      	logging.
      bc44795c
    • Dodji Seketeli's avatar
      Style cleanup in nmv-call-stack.cc · b58c7aef
      Dodji Seketeli authored
      	* src/persp/dbgperspective/nmv-call-stack.cc: Cleanup function
          	definition style.
      b58c7aef
    • Romain Tartière's avatar
      641595 - Add configure option for default GDB path · c82866a0
      Romain Tartière authored
      	* configure.ac: Add --with-default-gdb=/path/to/default/gdb/binary
      	configure option.
      c82866a0
  7. Feb 18, 2012
    • Dodji Seketeli's avatar
      665498 - Assertion failure on program launch · 28dc0dbe
      Dodji Seketeli authored
      	* src/persp/dbgperspective/nmv-dbg-perspective.cc
      	(DBGPerspective::read_default_config):  Ensure that
      	m_priv->num_instr_to_disassemble is not zero.
      28dc0dbe
    • Dodji Seketeli's avatar
      Make test-var-path-expr.cc more portable · d20f309b
      Dodji Seketeli authored
      	* tests/test-var-path-expr.cc (on_variable_expr_path): Test the
      	presence of the string ".m_first_name" in the path expression,
      	instead of trying to look for something exact that would depend on
      	a particular implementation of libstdc++.
      d20f309b
    • Dodji Seketeli's avatar
      Fix comment typo in class IDebugger::Variable · 1f0a760b
      Dodji Seketeli authored
      	* src/dbgengine/nmv-i-debugger
      	(IDebugger::Variable::equals_by_value): Fix comment.
      1f0a760b
    • Dodji Seketeli's avatar
      Support 'new_children' property of GDB/MI changelist LIST · bfdfdc93
      Dodji Seketeli authored
      	* src/dbgengine/nmv-dbg-common.h (VarChange): New type.
      	(apply_debugger_variable_change): New public entry point.
      	(Output::ResultRecord::m_has_var_changes):
      	(Output::ResultRecord::m_new_num_children): New members
      	(Output::ResultRecord::clear): Clear new m_var_changes and
      	m_new_num_children.
      	(Output::ResultRecord::has_var_changes):New.
      	(Output::ResultRecord::var_changes): New.
      	(Output::ResultRecord::new_num_children): New.
      	* src/dbgengine/nmv-dbg-common.cc (VarChange::Priv): New
      	(VarChange::*): New.
      	(update_debugger_variable): New.
      	* src/dbgengine/nmv-gdbmi-parser.h (parse_var_changed_list): New.
      	* src/dbgengine/nmv-gdbmi-parser.cc
      	(grok_var_changed_list_components): Split out from
      	GDBMIParser::parse_var_changed_list.  Make it support
      	"new_children" property.
      	(GDBMIParser::parse_var_changed_list): Use new
      	grok_var_changed_list_components.
      	(operator<<): Added a few overloads of this to stream instances of
      	VariableSafePtr, Variable, VarChangePtr to ostream.
      	(dump_gdbmi): Added a few overloads of this for GDBMI types.
      	(GDBMIParser::parse_result_record<PREFIX_VARIABLES_CHANGED_LIST>):
      	Adjust to list<VarChangePtr> instead of
      	list<IDebugger::VariableSafePtr>.
      	* src/dbgengine/nmv-i-debugger.h (IDebugger::load_program): Add
      	two new overloads to simplify inferior load from client code.
      	* src/dbgengine/nmv-gdb-engine.h (GDBEngine::load_program): Add
      	two new overloads to simplify inferior load from client code.
      	* src/dbgengine/nmv-gdb-engine.cc (read_default_config): Add logs.
      	(on_conf_key_changed_signal): Likewise.  Don't queue
      	-enable-pretty-printing command if gdb is not running.  That will
      	make us lose the queued command once load_program is later called.
      	(OnListChangedVariableHandler::do_handle): Apply variable changes
      	to relevant variables and notify client code with the
      	sub-variables that got modified.
      	(GDBEngine::load_program): Two new overloads to simplify the
      	client code.  Add comments.  Cleanup.
      	* src/persp/dbgperspective/nmv-local-vars-inspector.cc
      	(update_a_local_variable, on_local_variables_listed_signal): Add
      	logs.
      	* src/persp/dbgperspective/nmv-variables-utils.cc (is_empty_row)
      	(get_row_name): New static functions.
      	(get_variable_columns, find_a_variable): Update logging.
      	(walk_path_from_row):  Add a recurse argument that indicates if we
      	are being called recursively or not.  Use that to determine row
      	where the walk stops at.  USe is_empty_row.  Add logging.
      	(find_a_variable_descendent): Add logging.  Support looking for a
      	variable member that is a new sibling.  That is, a variable member
      	not present in the graphical representation of its root variable,
      	even though that root variable is graphically represented.
      	(variables_match): Fix logic.
      	(update_a_variable, update_a_variable_real): Add comments and
      	logging.  Support new variable members.
      	* tests/test-gdbmi.cc (gv_output_record9): New output record as a
      	result of -var-update.
      	* tests/test-pretty-print.cc: New test case.
      	* tests/pretty-print.cc: New inferior for new test case.
      	* tests/Makefile.am: Update build system for adding new test case.
      bfdfdc93
    • Dodji Seketeli's avatar
      Add IDebugger::Variable::operator== · 934d9eb7
      Dodji Seketeli authored
      	* src/dbgengine/nmv-i-debugger.h
      	(IDebugger::Variable::operator==): Make this public and implement
      	it.
      	(IDebugger::Variable::equals): New function.
      934d9eb7
  8. Feb 05, 2012
    • Dodji Seketeli's avatar
      Support GDB/MI properties displayint, dynamic, has_more · 7df48d84
      Dodji Seketeli authored
      	* src/dbgengine/nmv-i-debugger.h
      	(IDebugger::{m_display_hint,m_is_dynamic,m_has_more_children}):
      	New members.
      	(Variable::Variable): Initialize the new members.
      	(Variable::{display_hint,is_dynamic,has_more_children}): New
      	accessors.
      	(Variable::expects_children): Renamed
      	Variable::has_expected_children into this.  Use the new
      	Variable::has_more_children accessor.
      	(Variable::needs_unfolding): Adjust.
      	* src/dbgengine/nmv-gdbmi-parser.cc (GDBMIParser::parse_variable):
      	Support "displayhinr", "dynamic", "has_more" properties.
      	* tests/test-vars.cc (on_variable_unfolded_signal): Adjust.
      7df48d84
    • Dodji Seketeli's avatar
      Drop redundant parameter from some variable utils · 44711bee
      Dodji Seketeli authored
      	* src/persp/dbgperspective/nmv-variables-utils.h
      	(append_a_variable, set_a_variable):  Drop redundant a_tree_store
      	and the const from a_tree_view.
      	(update_a_variable_node, update_unfolded_variable)
      	(update_a_variable, visualize_a_variable): Adjust.
      	* src/persp/dbgperspective/nmv-variables-utils.cc
      	(append_a_variable, set_a_variable): Drop redundant
      	a_tree_store parameter.  Get it from from the a_tree_view
      	parameter instead.  Drop the const from a_tree_view as a
      	consequence.  Adjust the rest of the function accordingly.
      	(update_a_variable_real, update_a_variable)
      	(update_a_variable_node, update_unfolded_variable)
      	(visualize_a_variable): Adjust.
      	* src/persp/dbgperspective/nmv-global-vars-inspector-dialog.cc
      	(append_a_global_variable): Adjust.
      	* src/persp/dbgperspective/nmv-local-vars-inspector.cc
      	(append_a_local_variable, append_a_function_argument)
      	(on_variable_unfolded_signal): Likewise.
      	* src/persp/dbgperspective/nmv-var-inspector.cc
      	(graphically_set_variable, on_variable_unfolded_signal): Likewise.
      44711bee
  9. Jan 11, 2012