Nautilus allowed line wrapping for filenames after a . or _
The code made an exception for version numbers, but it
was too rigid and broke things like Ubuntu's 12.04 version
numbering. This relaxes the exception so that the line isn't
wrapped for a . or _ immediately followed by any numbers.

https://launchpad.net/bugs/942539

https://bugzilla.gnome.org/show_bug.cgi?id=781875

This hides the autostart from Ubuntu's Startup Applications
app since we don't want users to easily disable this without
understanding why it's there.

https://bugzilla.gnome.org/show_bug.cgi?id=781874

This is not available in gtk+ 3.20

Popover transitions are not used for the rename popover.

https://bugzilla.gnome.org/show_bug.cgi?id=771614

When updating the cursor, the existence of an active window slot is
assumed when checking if it allows stopping. This can cause a crash if
the last view is closed while it is still loading.

https://bugzilla.gnome.org/show_bug.cgi?id=773499

It is possible to give focus to the list view with nothing selected. On
pressing Enter, Nautilus would try to activate a null list of items and
therefore segfault. Fix this by doing nothing if there is no selection.

https://bugzilla.gnome.org/show_bug.cgi?id=773150

Iain Lane authored Oct 07, 2016 and Carlos Soriano Sánchez committed Oct 07, 2016

Sometimes we were trying to lay down icons before size_allocate had been
run. When this has happened, gtk_widget_get_allocation returns 1×1 as
our size. This messes up the algorithm and causes icons to be
overlapping on the canvas.

This case happens when using Nautilus as the desktop in early-startup
(e.g. from its XDG autostart file). It can happen that we have read the
desktop files before the allocation has happened.

We fix this by noticing if we're called before size_allocate and then
deferring icon layout until later on, after size_allocate has happened.

This behaviour was introduced in commit
e0081be7, which sorts and freezes the
desktop in early-startup.

https://bugs.launchpad.net/ubuntu/+source/nautilus/+bug/1611955

https://bugzilla.gnome.org/show_bug.cgi?id=765601

Christian Stadelmann authored Aug 29, 2016 and Carlos Soriano Sánchez committed Sep 12, 2016

In nautilus' main window, the right side container (GtkOverlay: main_view) can
be resized to have a width of 0. This might render nautilus unusable for some
users. This change prevents shrinking main_view.

Fixes https://bugzilla.gnome.org/show_bug.cgi?id=767573

This causes to not being able to have installed libgd library.
It's better to have a warning than this issue, so for now just
revert it.

This reverts commit e34f598c.

In 26a3ab4c we put recursivity to the simple search engine in order
to fix the report of some users that weren't getting files inside
folder of home directory.

However this is wrong, since it takes too long and gnome-shell search
provider doesn't have a way to get partial results or close the search
when done, which makes Nautilus not reporting results until the search
is done, and in case the user stops the shell search, nautilus keeps
searching making the CPU consumption really high.

In fact, we always made recursivity for tracker but not for the simple
engine when performing the shell search.

The issue users were experiencing seems unrelated to this, and I
actually cannot reproduce, so let's return to the regular behaviour
we had.

https://bugzilla.gnome.org/show_bug.cgi?id=766174

Automatic resource registration appears to not work properly with the
static libgd variant, which causes warnings. That can be worked around
by linking against libgd dynamically.

https://bugzilla.gnome.org/show_bug.cgi?id=770121

The background of the window paned is not set to be transparent, which
may cause it to become opaque when changing themes. This commit sets its
background color in the style sheet.

https://bugzilla.gnome.org/show_bug.cgi?id=765687

The problem is that in the function canvas_container_set_workarea the screen width
and height are in "application pixels" while the workarea ones are in "device
pixels" so when the scaling is > 1, the margins are not properly setted.

We need to scale-down the workarea geometries to "application pixels".

https://bugzilla.gnome.org/show_bug.cgi?id=769302

Mario Sanchez Prada authored May 05, 2016 and Carlos Soriano Sánchez committed Jul 29, 2016

The to_delete GList* gets initialized in trash_files() and is supposed
to be filled by trash_file() so that we know which files we want to
delete directly when the call to g_file_trash() fails for some reason.

However, this GList* gets modified in place by calls to g_list_prepend()
and so those changes will only be seen by the to_delete argument inside
trash_file(), but not by the local variable defined in trash_files(), which
will continue to point to NULL regardless of those changes.

So, we simply need to pass a reference to the GList* so that any change done
to the structure of the GList* inside trash_file() is seen in trash_files().

https://bugzilla.gnome.org/show_bug.cgi?id=766030

Ernestas Kulik authored May 12, 2016 and Carlos Soriano Sánchez committed Jul 29, 2016

When renaming a file from the popover, the code checks if there is an
existing file with the name entered and the name entered does not match
the name of the file being renamed. That has a side effect of allowing
the original filename to be entered without reporting an error.

Some problems arise when the model includes files from different
directories (e.g. when searching or expanding directories in the list
view).
When searching, the code will not allow a rename if there are files
with the entered name, despite being in separate directories.
When renaming a file in an expanded directory, the code will ignore
files inside it and only check the currently opened one. This also
applies when creating new folders.

This commit fixes that by checking for duplicate names inside the parent
directory when renaming and checking the directory at
nautilus_file_view_get_backing_uri() when creating new folders.

https://bugzilla.gnome.org/show_bug.cgi?id=757385

The custom icon selection GtkFileChooserDialog is unresponsive when
opened. This is caused by the properties dialog window being modal,
since it is up to the window manager how to process input in such
situations.

One of the ways to ensure that the child dialog receives and processes
user input is by making it modal. This commit makes it such.

https://bugzilla.gnome.org/show_bug.cgi?id=753394

Razvan Chitu authored May 05, 2016 and Carlos Soriano Sánchez committed Jul 28, 2016

When copying, moving or linking files, original sources and their destinations
are stored in an information structure used for undoing the operation. The
sources and destinations were appended at the end of a list. Due to append
taking linear time, these file operations would have a resulting quadratic
complexity depending on the number of files. When operating on thousands of
files, this would lead to a significant decrease in speed. In order to fix
this, the sources and destinations are stored in a queue that allows appending
in constant time.

https://bugzilla.gnome.org/show_bug.cgi?id=757747

We lost the recursivity on the shell search with the search rework.
We need to explicitly set recursivity on the simple provider now.

https://bugzilla.gnome.org/show_bug.cgi?id=766174

update_scripts_menu() and update_templates_menu() do not unref the
directories after calling nautilus_directory_get_by_uri(), which results
in leaks. This commit fixes that by adding calls to
nautilus_directory_unref().

https://bugzilla.gnome.org/show_bug.cgi?id=769182

window-slot binds with query-editor via a property, which results in
nautilus_query_editor_set_location() being called on construction and
location changes. That function in turn calls
update_information_label(), which takes a ref on the file, but does not
release it. This can result in a crash with remote bookmarks when
connecting/disconnecting or switching back and forth.

This commit fixes that by adding an unref to update_information_label().

g_file_is_native() should be enough to decide whether the file is local.
Checking if g_file_get_path() returns a native path lets us know if the
directory is possibly made available by use of FUSE and there is
nautilus_directory_is_local_or_fuse() for that.

https://bugzilla.gnome.org/show_bug.cgi?id=768733

Due to the floating bar being in an overlay, it can obscure the content
under it.

We were planning to remove it and use an action bar. But it's taking
long, so in the meantime we can improve this situations hiding the
floating bar when hovered.

On the way I improved the handling of the spinner, which was failing
to be shown on certain situations.

Patch based on Nelson Benitez, thanks!

https://bugzilla.gnome.org/show_bug.cgi?id=651293

nautilus_file_get_date_as_string() uses today's date and the GDateTime
constructed from the return value of nautilus_file_get_date(), which
also includes the time of day, thus making the calculation of the
day difference incorrect. To illustrate, files, modified two days ago
can appear to have been modified yesterday.

This commit fixes that by calculating the day difference of the dates
with the time value of 00:00:00.

https://bugzilla.gnome.org/show_bug.cgi?id=756402

nautilus_file_compare_display_name() is only used by
nautilus_directory_get_file_by_name() nowadays and it was written with
sorting in mind. As g_utf8_collate() and its locale dependence does not
work well with finding matching files by name, it makes sense to replace
the call to g_strcmp0(). That, however, makes the function less suitable
for sorting. This commit changes its purpose as described.

https://bugzilla.gnome.org/show_bug.cgi?id=768074

Don't write the zoom level to gsettings if the user has not made a
change from the system default. This allows an update to be installed
and then rolled back without a system default from the update having
been written to the user's configuration.

https://bugzilla.gnome.org/show_bug.cgi?id=767878

So that the menu doesn't show at random places under Wayland which
expects all subsurfaces to have a parent surface.

https://bugzilla.gnome.org/show_bug.cgi?id=767446

Johannes Oertel authored May 09, 2016 and Carlos Soriano Sánchez committed May 30, 2016

This fixes a problem where a double click on an item in Nautilus icon view did
not activate the moment when moving the pointer even slightly in between the two
clicks.

https://bugzilla.gnome.org/show_bug.cgi?id=748501