We might want to add more ignored types later on, but this is a simple
cleanup.

https://bugzilla.gnome.org/show_bug.cgi?id=783998

Lubomir Rintel authored Nov 02, 2016 and Bastien Nocera committed May 05, 2017

It looks a bit weird to define it and still use the numeric literal.

Lubomir Rintel authored Nov 02, 2016 and Bastien Nocera committed May 05, 2017

The empty string is not too useful as an SSID, an attempt to create a
hotspot fails:

  (gnome-control-center:19371): network-cc-panel-WARNING **:
    Failed to add new connection: (2)
    A 'wireless' setting with a valid SSID is required if no AP path was given.

Mohammed Sadiq authored May 05, 2017 and Bastien Nocera committed May 05, 2017

g_utf8_find_next_char() doesn't do checks whether the char
is '\0' or not. We have to take care of that ourself.

This commit fixes heap-buffer-overflow found by test-hostname

ERROR: AddressSanitizer: heap-buffer-overflow on address
READ of size 1 at 0x60200000cd76 thread T0
 #0 0x7f8b26920d08 in g_utf8_find_next_char glib/glib/gutf8.c:179
 #1 0x55c2b8eacaee in pretty_hostname_to_ssid gnome-control-center/shell/hostname-helper.c:199

https://bugzilla.gnome.org/show_bug.cgi?id=782216

Carlos Garnacho authored Jun 06, 2016 and Bastien Nocera committed Apr 27, 2017

So we can recognize pad devices.

Note:
  Cherry-picked from master commit 176dfca1 to fix
  https://bugzilla.gnome.org/show_bug.cgi?id=781846

This way we can safely interrupt an update without crashing
g-c-c.

https://bugzilla.gnome.org/show_bug.cgi?id=780299

Carlos Garnacho authored Nov 01, 2016 and Rui Matos committed Mar 23, 2017

We cater for the old(=Wacom) and new(=libinput) type/name schemes,
so we don't require a too recent gtk+ just for this.

From a Coverity scan:

panels/keyboard/cc-keyboard-manager.c:208: unreachable: Since the loop
increment "i++;" is unreachable, the loop body will never execute more
than once.

This seems like a logic thinko introduced in commit
3207fe97 . In practice it was unlikely
to be a problem since we don't have repeated shortcut gsettings key
names in all our KeyListEntries files.

https://bugzilla.gnome.org/show_bug.cgi?id=780312

This regression has been introduced by commit 52da4daf. The
info panel crashes if prettify_info() returns NULL. This happens
if Renderer property from SessionManager is empty.

https://bugzilla.gnome.org/show_bug.cgi?id=774240

Ting-Wei Lan authored Nov 10, 2016 and Bastien Nocera committed Mar 14, 2017

https://bugzilla.gnome.org/show_bug.cgi?id=774324

This ensures that:
- the AP list shown on startup when the Hotspot is disabled on
  startup, or when disabling it at run-time
- the hotspot page is shown on startup when the Hotspot is enabled,
  or when it gets enabled at runtime

https://bugzilla.gnome.org/show_bug.cgi?id=705546

Commit e8248689 was supposed to do this, but needed to write the changes
out to disk before activating the hotspot.

https://bugzilla.gnome.org/show_bug.cgi?id=705546

https://bugzilla.gnome.org/show_bug.cgi?id=705546

Wrong variables are used to store timeout id, consequently, the sources
are not properly removed in all cases. Then the dialog may crash in certain
cases if it is closed before the source functions are called.

https://bugzilla.gnome.org/show_bug.cgi?id=778595

When adding a custom shortcut, the header mode was set to be
only "Cancel". Per mockups, the "Add" button should also be
visible but insensitive.

Fix that by correctly setting the header mode on creation mode.

https://bugzilla.gnome.org/show_bug.cgi?id=777824

When creating a new shortcut, we currently assume the entries are
sensitive and just show the dialog. This, however, may not be, for
example after previously canceling the editing of a custom shortcut,
leading to a state where the name and command entries are insensitive.

Fix that by always making sure the entries are sensitive when
setting the dialog to creation mode.

https://bugzilla.gnome.org/show_bug.cgi?id=777824

When canceling the editing of a custom shortcut, the "Edit" button
keeps pressed, causing inconsistencies when editing future custom
events.

To reproduce that:
 - Open a custom shortcut and click "Edit"
 - Start typing the new shortcut; the "Cancel" button will appear
 - *Before* completing the new shortcut, click "Cancel"; the dialog will hide
 - Open a custom shortcut again; the "Edit" button is still toggled

Fix that by properly untoggling the Edit button when cancelling
the editing.

https://bugzilla.gnome.org/show_bug.cgi?id=777824

With gtk+ >= 3.22 trackpoints are classified separately from mice so
we need to handle them here. Also, remove the default case so that we
get a compilation warning in case this happens again.

In the future we might want to expose this further if we start adding
trackpoint specific UI.

https://bugzilla.gnome.org/show_bug.cgi?id=776660

The NetDeviceEthernet's title is not set until after the UI is created,
so we have to listen for changes to the title.

https://bugzilla.gnome.org/show_bug.cgi?id=776369

So that running with debug is enough to know why a search provider was
ignored.

Since we don't support "Screen Sharing" under Wayland yet.

https://bugzilla.gnome.org/show_bug.cgi?id=774553

As seen in attachment 339587

https://bugzilla.gnome.org/show_bug.cgi?id=774240