The Tracker plugin is enabled by default, and will replace the
MediaExport plugin is enabled. This means that instead of sharing files
listed in the paths set in the UI, we'd be sharing the user's files as
configured in the Search panel. Not what we want to do if this contains
private files.

Fall out from abb05928

https://bugzilla.gnome.org/show_bug.cgi?id=758417

https://bugzilla.gnome.org/show_bug.cgi?id=757189

https://bugzilla.gnome.org/show_bug.cgi?id=757189

This fixes:
==5944== 64,392 bytes in 4,223 blocks are definitely lost in loss record 16,020 of 16,045
==5944==    at 0x4C28C50: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==5944==    by 0x1445EFCC: g_malloc (gmem.c:94)
==5944==    by 0x1445F2AE: g_malloc_n (gmem.c:330)
==5944==    by 0x144981DC: g_variant_get_strv (gvariant.c:1572)
==5944==    by 0x48FA45: settings_get_binding (cc-keyboard-item.c:369)
==5944==    by 0x48FA9D: binding_changed (cc-keyboard-item.c:384)
==5944==    by 0x141C3E2F: g_cclosure_marshal_VOID__STRINGv (gmarshal.c:1794)
==5944==    by 0x141BFBE3: _g_closure_invoke_va (gclosure.c:864)
==5944==    by 0x141DA3E7: g_signal_emit_valist (gsignal.c:3292)
==5944==    by 0x141DB55F: g_signal_emit (gsignal.c:3439)
==5944==    by 0x13EDC81D: g_settings_real_change_event (gsettings.c:386)

https://bugzilla.gnome.org/show_bug.cgi?id=756762

This fixes:
==5944== 2,304 bytes in 5 blocks are definitely lost in loss record 15,724 of 16,045
==5944==    at 0x4C2AB9D: realloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==5944==    by 0x1445F0B8: g_realloc (gmem.c:159)
==5944==    by 0x144217CF: g_array_maybe_expand (garray.c:779)
==5944==    by 0x14420C9F: g_array_append_vals (garray.c:418)
==5944==    by 0x48ACFA: append_sections_from_file (keyboard-shortcuts.c:558)
==5944==    by 0x48B4EE: reload_sections (keyboard-shortcuts.c:737)
==5944==    by 0x48EA22: keyboard_shortcuts_init (keyboard-shortcuts.c:2109)
==5944==    by 0x489236: cc_keyboard_panel_constructor (cc-keyboard-panel.c:133)
==5944==    by 0x141C7C3F: g_object_new_with_custom_constructor (gobject.c:1697)
==5944==    by 0x141C7E71: g_object_new_internal (gobject.c:1777)
==5944==    by 0x141C8ADA: g_object_new_valist (gobject.c:2038)
==5944==    by 0x141C7A85: g_object_new (gobject.c:1622)
==5944==    by 0x4547DF: cc_panel_loader_load_by_name (cc-panel-loader.c:213)
==5944==    by 0x44DFCB: activate_panel (cc-window.c:157)
==5944==    by 0x4504D6: cc_window_set_active_panel_from_id (cc-window.c:1036)
==5944==    by 0x44E6A6: item_activated_cb (cc-window.c:280)

https://bugzilla.gnome.org/show_bug.cgi?id=756762

==5944== 90 (16 direct, 74 indirect) bytes in 1 blocks are definitely lost in loss record 11,855 of 16,045
==5944==    at 0x4C28C50: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==5944==    by 0x1445EFCC: g_malloc (gmem.c:94)
==5944==    by 0x1445F2AE: g_malloc_n (gmem.c:330)
==5944==    by 0x144982EC: g_variant_dup_strv (gvariant.c:1621)
==5944==    by 0x13EDF251: g_settings_get_strv (gsettings.c:2070)
==5944==    by 0x48D56E: find_free_settings_path (keyboard-shortcuts.c:1651)
==5944==    by 0x48D663: add_custom_shortcut (keyboard-shortcuts.c:1682)
==5944==    by 0x48DB04: add_button_clicked (keyboard-shortcuts.c:1788)

https://bugzilla.gnome.org/show_bug.cgi?id=756762

It contains a strdup'ed string, but it's overwritten without being freed
first from cc_keyboard_item_load_from_gsettings_path() and
cc_keyboard_item_load_from_gsettings().

This fixes:
==5944== 976 bytes in 64 blocks are definitely lost in loss record 15,439 of 16,045
==5944==    at 0x4C28C50: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==5944==    by 0x1445EFCC: g_malloc (gmem.c:94)
==5944==    by 0x1445F2AE: g_malloc_n (gmem.c:330)
==5944==    by 0x144981DC: g_variant_get_strv (gvariant.c:1572)
==5944==    by 0x48FA45: settings_get_binding (cc-keyboard-item.c:369)
==5944==    by 0x48FDDD: cc_keyboard_item_load_from_gsettings (cc-keyboard-item.c:438)
==5944==    by 0x489EB7: append_section (keyboard-shortcuts.c:249)
==5944==    by 0x48ADF6: append_sections_from_file (keyboard-shortcuts.c:578)
==5944==    by 0x48B4EE: reload_sections (keyboard-shortcuts.c:737)
==5944==    by 0x48EA22: keyboard_shortcuts_init (keyboard-shortcuts.c:2109)
==5944==    by 0x489236: cc_keyboard_panel_constructor (cc-keyboard-panel.c:133)
==5944==    by 0x141C7C3F: g_object_new_with_custom_constructor (gobject.c:1697)
==5944==    by 0x141C7E71: g_object_new_internal (gobject.c:1777)
==5944==    by 0x141C8ADA: g_object_new_valist (gobject.c:2038)
==5944==    by 0x141C7A85: g_object_new (gobject.c:1622)
==5944==    by 0x4547DF: cc_panel_loader_load_by_name (cc-panel-loader.c:213)
==5944==    by 0x44DFCB: activate_panel (cc-window.c:157)
==5944==    by 0x4504D6: cc_window_set_active_panel_from_id (cc-window.c:1036)

https://bugzilla.gnome.org/show_bug.cgi?id=756762

==11430== 48 (24 direct, 24 indirect) bytes in 1 blocks are definitely lost in loss record 10,663 of 18,7
==11430==    at 0x4A06C50: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==11430==    by 0x7F260AC: g_malloc (gmem.c:97)
==11430==    by 0x7F3F0F7: g_slice_alloc (gslice.c:1007)
==11430==    by 0x7F19BE5: g_list_prepend (glist.c:311)
==11430==    by 0x684843B: accum_cells (gtkcellarea.c:1563)
==11430==    by 0x6850989: gtk_cell_area_box_foreach (gtkcellareabox.c:1145)
==11430==    by 0x6848AAA: gtk_cell_area_foreach (gtkcellarea.c:1730)
==11430==    by 0x6848490: gtk_cell_area_get_cells (gtkcellarea.c:1573)
==11430==    by 0x6857339: gtk_cell_layout_get_cells (gtkcelllayout.c:592)
==11430==    by 0x685668F: gtk_cell_layout_default_get_cells (gtkcelllayout.c:342)
==11430==    by 0x6857339: gtk_cell_layout_get_cells (gtkcelllayout.c:592)
==11430==    by 0x45242B: cc_shell_item_view_update_cells (cc-shell-item-view.c:116)
==11430==   ...

This fixes this leak:

==21491== 384 (40 direct, 344 indirect) bytes in 1 blocks are definitely lost in loss record 18,518 of 19,643
==21491==    at 0x8792D3A: g_type_create_instance (gtype.c:1848)
==21491==    by 0x8779AC5: g_object_new_internal (gobject.c:1774)
==21491==    by 0x8779FD4: g_object_newv (gobject.c:1921)
==21491==    by 0x8779676: g_object_new (gobject.c:1614)
==21491==    by 0x747DFFC: gtk_list_store_new (gtkliststore.c:424)
==21491==    by 0x49C781: goa_panel_add_account_dialog_init (cc-online-accounts-add-account-dialog.c:300)
==21491==    by 0x8792E7D: g_type_create_instance (gtype.c:1870)
==21491==    by 0x8779AC5: g_object_new_internal (gobject.c:1774)
==21491==    by 0x877A71A: g_object_new_valist (gobject.c:2033)
==21491==    by 0x87796C5: g_object_new (gobject.c:1617)
==21491==    by 0x49CC26: goa_panel_add_account_dialog_new (cc-online-accounts-add-account-dialog.c:380)
==21491==    by 0x49B162: get_all_providers_cb (cc-online-accounts-panel.c:701)
==21491==    by 0x8426107: g_simple_async_result_complete (gsimpleasyncresult.c:801)
==21491==    by 0x8426153: complete_in_idle_cb (gsimpleasyncresult.c:813)
==21491==    by 0x8A0C470: g_idle_dispatch (gmain.c:5397)
==21491==    by 0x8A09AB8: g_main_dispatch (gmain.c:3122)
==21491==    by 0x8A0A8FC: g_main_context_dispatch (gmain.c:3737)
==21491==    by 0x8A0AAE0: g_main_context_iterate (gmain.c:3808)
==21491==    by 0x8A0ABA4: g_main_context_iteration (gmain.c:3869)
==21491==    by 0x846EE55: g_application_run (gapplication.c:2311)
==21491==    by 0x44CA4B: main (main.c:57)

https://bugzilla.gnome.org/show_bug.cgi?id=756762

The idiot that did the 3.16.3 release (me) didn't push the commit
that bumped the version and updated the NEWS file.

That's now done, even if that means that the 3.16.3 release is now
orphan of an upstream tag and commit.

Sigh.

Since the dialog considers just  the hostname part from the URL,
unespacing the url avoids a backend crash.

https://bugzilla.gnome.org/show_bug.cgi?id=754248

For newly created user accounts, AccountsService won't have the
language property set. Instead of defaulting to en_US in that case,
let's fallback to the current locale.

https://bugzilla.gnome.org/show_bug.cgi?id=753828

Frederic Peters authored Aug 18, 2015 and Kalev Lember committed Aug 24, 2015

https://bugzilla.gnome.org/show_bug.cgi?id=753643

pp-new-printer-dialog.c:673:18: warning: 'device' may be used uninitialized
in this function [-Wmaybe-uninitialized]

Check whether given application child is at least 1 character
long to avoid crash which can happen as a result of creating
of GDesktopAppInfo with NULL desktop file id.
To reproduce this run "gnome-control-center notifications" and
"gsettings set org.gnome.desktop.notifications application-children "['']"".

https://bugzilla.gnome.org/show_bug.cgi?id=752525

https://bugzilla.gnome.org/show_bug.cgi?id=752609

Commit 3e6b741a introduced check for NULL on um_realm_object_get_common.
Unfortunatelly one check is wrong and breaks the login permitting.
The patch fixes the wrong check.

https://bugzilla.gnome.org/show_bug.cgi?id=752405

Just ellipsize them instead.

https://bugzilla.gnome.org/show_bug.cgi?id=752383

When we're finalizing, the remote settings instance might already be
gone and thus we can't list connections. In particular this happens at
panel finalization resulting in the following warning:

libnm-glib-CRITICAL **: nm_remote_settings_list_connections: assertion
'NM_IS_REMOTE_SETTINGS (settings)' failed

because cc_network_panel_dispose() unrefs the remote settings object
before all the NetDevice instances are finalized.

Since we only need to list connections on finalize to disconnect a
signal we can instead use g_signal_connect_object() and keep the
connections that we're keeping track of in a hash table instead of
g_object_set_data().

https://bugzilla.gnome.org/show_bug.cgi?id=749850

Pass all discovered devices to 'GroupPhysicalDevices' instead of just
the devices already present in the list and the newly discovered ones.
Replace an existing device in the list if there is a better device
(e.g. replace 'usb:' by 'hp:' device).

https://bugzilla.gnome.org/show_bug.cgi?id=693186

Check whether we've been able to find a usable name of given device
to avoid dereference of NULL in canonicalize_device_name().

https://bugzilla.gnome.org/show_bug.cgi?id=749896