- Oct 12, 2016
-
-
- Apr 12, 2012
-
-
OKANO Takayoshi authored
-
- Apr 10, 2012
-
-
Will Thompson authored
When presented with an array of empty arrays of 8-byte-aligned types, GDBus would incorrectly apply the 8-byte alignment when reading back. https://bugzilla.gnome.org/show_bug.cgi?id=673612 Signed-off-by:
David Zeuthen <davidz@redhat.com>
-
Will Thompson authored
D-Bus arrays are serialized as follows: 1. align to a 4-byte boundary (for the length) 2. uint32: the length of the serialized body in bytes 3. padding for the alignment of the body type (not included in the length) 4. the body. Note that 3. is a no-op unless the body type is an 8-byte aligned type (uint64, int64, double, struct, dict_entry), since you are always on a 4-byte boundary from aligning and writing the length. So, an empty aax (that is, an array containing zero arrays of int64) is serialized as follows: 1. align to a 4-byte boundary 2. length of the contents of this (empty) array, in bytes (0) 3. align to a 4-byte boundary (the child array's alignment requirement) 4. there is no body. But previously, GDBus would recurse in step three to align not just for the type of the child array, but for the nonexistent child array's contents. This only affects the algorithm when the grandchild type has 8-byte alignment and the reader happened to not already be on an 8-byte boundary, in which case 4 bytes were spuriously skipped. https://bugzilla.gnome.org/show_bug.cgi?id=673612 Signed-off-by:
-
Will Thompson authored
Signed-off-by:
-
- Mar 27, 2012
-
-
Rajesh Ranjan authored
-
- Mar 12, 2012
-
-
Matthias Clasen authored -
Matthias Clasen authored
-
Matthias Clasen authored
-
- Mar 11, 2012
-
-
Matthias Clasen authored
Another Fedora UsrMove victim !
-
Matthias Clasen authored
This problem was pointed out in bug 639873. The patch here is based on Matt Barnes patch, I've added a testcase as well.
-
When complaining about ill defined GOptionEntries include the name of the option group and entry in the warning.
-
-
Transforming a GValue holding flags from a GFlagsValue set that includes the 0 value (no flag bits set) into a string would loop until exhausting all the available memory. https://bugzilla.gnome.org/show_bug.cgi?id=670557
-
If an async line read fails, it returns NULL. In that case, we must return NULL before validating the line, or we segfault. https://bugzilla.gnome.org/show_bug.cgi?id=658484
-
When G_DISABLE_ASSERT is not defined, g_hash_table_foreach and g_hash_table_find dereferences the hash table argument before checking if it's NULL. This causes a crash when one of this function is mistakenly called with a NULL argument instead of returning with a warning through g_return_if_fail.
-
When set to represent a zoneinfo file, TZ may start with :, therefore glib needs to check it and ignore the first char when building the resulting filename, or it won't be found. Also, the path could be absolute, in which case it is wrong to append /usr/share/timezone https://bugzilla.gnome.org/show_bug.cgi?id=664237
-
-
-
To clarify our statements about being robust against outside attackers degrading the performance of your hashtable.
-
Matthias Clasen authored
-
In non-UTF-8 locales, the translations and nl_langinfo() return values must be converted to UTF-8 before being returned to the caller. Likewise, when making a recursive call to expand a format like '%x', the format string must first be converted to UTF-8. https://bugzilla.gnome.org/show_bug.cgi?id=668250
-
When cross-compiling with linaro toolchain 4.6.2, I got several linking errors about missing symbols because a couple libraries are not linked. This patch adds to the LDADD flags the missed libraries. This patch applies above the glib-2-30 branch. Signed-off-by:
Víctor Manuel Jáquez Leal <vjaquez@igalia.com> https://bugzilla.gnome.org/show_bug.cgi?id=671711
-
- Mar 01, 2012
-
-
Krishnababu Krothapalli authored
-
- Feb 25, 2012
-
-
John Ralls authored
-
- Feb 19, 2012
-
-
gdb by default will only print strings up to 200 characters. After that it abbreviates them. This affects the run-assert-msg-test.sh script if the path to the glib installation is too long (in our case it was 133 characters, 132 would still have worked...) By having gdb execute "set print elements 0" before printing the assert string, the limit on maximum number of characters to print is set to unlimited. Signed-off-by:
Peter Kjellerstedt <pkj@axis.com> https://bugzilla.gnome.org/show_bug.cgi?id=670218
-
- Feb 07, 2012
-
-
Javier Jardón authored
-
- Feb 06, 2012
-
-
Swecha Localization Team authored
-
- Jan 16, 2012
-
-
Simon McVittie authoredfoo_free is conceptually "worth" one unref; not decrementing the refcount here means the GArray or GPtrArray wrapper (but not its contents) would leak in the following call sequence: p = g_ptr_array_new (); g_ptr_array_ref (p); g_ptr_array_free (p, TRUE); g_ptr_array_unref (p); Signed-off-by:Simon McVittie <simon.mcvittie@collabora.co.uk> Bug: https://bugzilla.gnome.org/show_bug.cgi?id=666113 Reviewed-by:
Emmanuele Bassi <ebassi@linux.intel.com>
-
Simon McVittie authored
Depending how the array is freed, we may want to free the underlying array (the "segment"), the struct wrapper or both. Signed-off-by:
-
Simon McVittie authored
Signed-off-by:
-
Simon McVittie authored
Removing the last thing in a dataset frees the dataset, and if the datalist was in a dataset, we can't safely unlock it after the dataset has been freed. Unlock it sooner. Signed-off-by:
Matthias Clasen <mclasen@redhat.com>
-
Simon McVittie authored
Calling this function with a NULL argument is considered to be invalid, but one of the regression tests does it anyway (to watch it crash), which seems a good indication that it's expected to be somewhat common. Let's check it rather than segfaulting. Signed-off-by:
-
Simon McVittie authored
These were leaked. Valgrind was sad. Signed-off-by:
-
Simon McVittie authored
Also document why we're not actually using the buffer for anything. Signed-off-by:
-
Simon McVittie authored
In practice, the uninitialized refcount will typically mean that the copy is never freed, and leaks. Signed-off-by:
-
- Dec 12, 2011
-
-
Alexandre Franke authoreddélai épuisé has been replaced with délai dépassé
-
- Dec 09, 2011
-
-
- Dec 05, 2011
-
-
Simon McVittie authored
Previously, this would fail the assertion "connection->initialization_error != NULL" after the label "out". Bug: https://bugzilla.gnome.org/show_bug.cgi?id=665067 Signed-off-by:
-
- Nov 23, 2011
-
-
Simon McVittie authored
This was a regression in commits f41178c6 and d0d04c09: flush_async_data wasn't necessarily NULL in the "don't flush" case. Also move initialization of these variables up so that it's unconditional, since that's easier to verify than checking that each branch gets it right. Bug: https://bugzilla.gnome.org/show_bug.cgi?id=664617 Signed-off-by:
-
