Ken VanDine authored Feb 06, 2019 and Jeremy Bicha committed Feb 06, 2019

This is needed to fix Launchpad's git import

It looks like adwaita now has a border on entry tags, but we do not
want it here.

When loading a file from the selector with
a filter, next recent files list in selector keeps
this filter, even if you reset it.

We get some crashes due to the fetching of the recent list
in a thread like other lists of the store.

GtkRecentManager can't be use in a thread other
than the main one.

https://bugzilla.gnome.org/show_bug.cgi?id=744611

Instead of manually removing a class, use save and restore.
This is more efficient with newer gtk since gtk can tell
that the context was unaffected.

When a user types a filename into the search popover, gedit tries
to find matches from recently used documents.  It does this by
returning all recently used documents that have what the user typed
as a substring of the document uri.

GtkRecentInfo provides two different apis for returning the associated
uri: gtk_recent_info_get_uri() and gtk_recent_info_get_uri_display().
The former returns the uri in a canonical representation with non-ascii
characters escaped using url escaping rules.  The latter returns the
uri with non-ascii characters unescaped.  GeditRecent uses the
canonicalized, escaping function, so its substring search fails
on non-ascii filenames.

This commit changes the code over to use the other variant.

https://bugzilla.gnome.org/show_bug.cgi?id=753481

The .desktop files were not generated since there were two rules for the
same targets. So the last rule was executed, which is the mkdir command.

To be sure that the mkdir command is executed before any target is
built, we can use $(shell ...). See:
http://stackoverflow.com/questions/2122602/force-makefile-to-execute-script-before-building-targets

25mm is too much for the top margin.

GTK+'s default margins are too small. It was not possible to use a hole
punch, and with some printers the text was truncated on the right.

Add gsettings to configure margins, with better defaults (25mm on each
side). The unit chosen is the millimeter, because it's the international
standard.

https://bugzilla.gnome.org/show_bug.cgi?id=572741

remove_attribute() removes the attribute from the FileInfo, so when
calling g_file_set_attributes_from_info(), the attribute value is kept
as-is, it was not unset.

To unset the file attribute, we must set the attribute to an invalid
type (it seems there is no nicer way to do it).

https://bugzilla.gnome.org/show_bug.cgi?id=741853

See the comment in the code.

With one document, the bug was easy to reproduce:
1. open document <file> in gedit
2. activate the auto spell -> metadata set to 1
3. close gedit
4. $ gedit <file> -> spell checking disabled, but should be enabled

https://bugzilla.gnome.org/show_bug.cgi?id=741853

The gedit_metadata_manager_* functions are anyway not used in the spell
plugin.