- Feb 19, 2013
-
-
Alexandre Franke authored
-
- Jan 21, 2013
-
-
Ray Strode authored
Right now any time any session conversation is started, we run its setup call if autologin is enabled. We should only do this for autologin sessions, otherwise, we may repeat work done by the greeter. https://bugzilla.gnome.org/show_bug.cgi?id=682467 (cherry picked from commit 47c73024)
-
- Jan 09, 2013
-
-
Fabio Tomat authored
-
- Jan 04, 2013
-
-
Gheyret Kenji authored
Signed-off-by: Gheyret Kenji <gheyret@gmail.com>
-
Gheyret Kenji authored
Signed-off-by: Gheyret Kenji <gheyret@gmail.com>
-
- Dec 02, 2012
-
-
Daniel Mustieles García authored
-
- Dec 01, 2012
-
-
Matthias Clasen authored
sd_seat_get_sessions is documented as 'may return an empty array or NULL', so we should be careful to not crash if it _does_ return NULL. Coverity complained about this. https://bugzilla.gnome.org/show_bug.cgi?id=689376
-
FamilyLocal is really fragile to hostname changes, so avoid using it when creating the initial auth cookie for establishing access to the X server for the slave. This commit changes the Xauthority entry to use FamilyWild which makes the address of the entry unimportant. https://bugzilla.gnome.org/show_bug.cgi?id=689370
-
If the slave gets stopped right before we start the user's session, then we'll have a queued start session in flight, and variable set to the session name to be started duplicated. This gunks up the stopping logic and leads to infinite recursion. This commit cancels the start session operation to correct the bug. https://bugzilla.gnome.org/show_bug.cgi?id=689367
-
- Nov 27, 2012
-
-
Ani Peter authored
-
- Nov 22, 2012
-
-
wouter bolsterlee authored
-
- Nov 20, 2012
-
-
ManojKumar Giri authored
-
- Nov 14, 2012
-
-
Ray Strode authored
-
Ray Strode authored
-
Ray Strode authored
We currently allow the slave access to its X server via two mechanisms: 1) we set XAUTHORITY to point to the X servers Xauthority file 2) we call XSetAuthorization with the cookie from the Xauthority file 1) may fail if the user's hostname changes at the wrong moment, and a bug in the code meant that 2 would fail if NULs are encoded in the auth cookie. This commit fixes 2) to work with embedded NUL bytes. https://bugzilla.gnome.org/show_bug.cgi?id=687691 (cherry picked from commit eaabecd7)
-
Ray Strode authored
On Linux dbus server sockets are world readable and world writable since they're abstract. Access control is handled at client connection time. On platforms that don't support abstract sockets, dbus server sockets are owned by the user that creates them. This disparity in behavior means that GDM greeters can't connect to GDM on platforms that doesn't support abstract sockets (e.g. OpenBSD). This commit changes GDM to perform heuristics to detect the socket address for the non-abstract case and open up its permissions. https://bugzilla.gnome.org/show_bug.cgi?id=685935 (cherry picked from commit 0b5e1015)
-
Ray Strode authored
XAddHosts fails if any of the entries in the list fails. The gdm-initial-setup user isn't available on most systems, so XAddHosts fails on most systems. Upshot is, since commit 189cd818 most people have been relying on xauth cookies for X authorization. xauth cookies aren't nearly as robust across hostname changes, so that's not ideal. This commit calls XAddHost() 3 times instead of one XAddHosts call to work around the problem. Ideally, we'd only add gdm-initial-setup when we need it instead of all the time. That will have to come later. https://bugzilla.gnome.org/show_bug.cgi?id=686186 (cherry picked from commit 2bd38e81)
-
- Oct 22, 2012
-
-
- Oct 16, 2012
-
-
Ray Strode authored
We currently decide whether or not to skip autologin by a first_login state variable in the static display object. These days we can have multiple static display objects, so storing the state variable doesn't make much sense. We could make the variable static, but instead this commit switches to using a marker file in /var/run/gdm. https://bugzilla.gnome.org/show_bug.cgi?id=682467 (cherry picked from commit 11d4b97b)
-
Ray Strode authored
-
Ray Strode authored
-
Sjoerd Simons authored
https://bugzilla.gnome.org/show_bug.cgi?id=686108 (cherry picked from commit 7cafff03)
-
Ray Strode authored
getpwnam returns a structure filled in by nsswitch modules. Those modules aren't always bug free, and can sometimes return e.g. an empty user's shell. When that happens the failure is pretty catastrophic and hard to debug. This commit does a quick sanity check of the user's home directory and shell to make sure they're not empty. If they are empty it picks defaults that are likely to at least sort of work. A better fix would probably be to fail earlier and post a message to the user explaining why login won't work, but this is good enough for now. https://bugzilla.gnome.org/show_bug.cgi?id=685423 (cherry picked from commit c10f6c45)
-
Ray Strode authored
There were two places in the code that run close() on fd's that failed to get opened. This commit fixes those two places. (cherry picked from commit 84a330a1)
-
Matthias Clasen authored
It is more convenient to have the schema default be true, and let administrators opt out in custom.conf. (cherry picked from commit 91b182bb)
-
Ray Strode authored
After GDM successfully reauthenticates a user it runs gdm_slave_switch_to_user_session to jump to the user's VT and unlock it. Of course, if the user is reauthenticating from an unlock screen instead of a user switched login screen, then they'll already be on the right VT. gdm_slave_switch_to_user_session fails if the user is already switched to the session specified. This failing behavior is used at login time to decide start a user's session (versus switching to a user's already running session). This commit changes gdm_slave_switch_to_user_session to take an additional parameter to decide whether or not switching to an already active session should fail, or merely skip to the unlocking step. https://bugzilla.gnome.org/show_bug.cgi?id=685988 (cherry picked from commit 99c4f960)
-
Tim Lunn authored
Partial revert of 920b38e2 to reinstroduce gdmflexiserver since gnome-screensaver depends on it. https://bugzilla.gnome.org/show_bug.cgi?id=685622 (cherry picked from commit 1b418226)
-
Ray Strode authored
launch-environment sessions and autologin sessions don't have a greeter associated with them to ask the user questions, or to display PAM messages. It's assumed the PAM stack will be set up in such a way that no conversing will be required. This assumption isn't always correct, if the system pam configuration includes something like pam_lastlog. This commit makes us discard info messages silently rather than fail. (cherry picked from commit 51b03d45)
-
Colin Walters authored
(cherry picked from commit eeca4e74)
-
- Oct 13, 2012
-
-
- Oct 03, 2012
-
-
Ray Strode authored
gnome-initial-setup knows whether or not to run by looking for the existence of a trigger filed called /var/lib/gdm/run-initial-setup This commit ensures that file gets cleaned up after the initial setup process completes.
-
- Oct 01, 2012
-
-
Ray Strode authored
-
Ray Strode authored
Ideally, we would only grant access to the initial-setup user when launching initial-setup, but this should be okay for now.
-
Ray Strode authored
The log file goes to a root owned directory so should be opened by root.
-
Ray Strode authored
-
- Sep 30, 2012
-
-
Žygimantas Beručka authored
-
- Sep 29, 2012
-
-
Matthias Clasen authored
These go in /usr/share/polkit-1/rules.d/.
-
Matthias Clasen authored
It doesn't work. In particular, unreffing NULL is bad news.
-
Matthias Clasen authored
There is a code path where we forgot to clear an error before reusing it. And the code that was reusing it was using a mis-constructed file path, guaranteeing a pile-on.
-