This needs to be ref. Fixes vala/#1544 and is a work-around until
vala/!355 lands

Signed-off-by: Dhanuka Warusadura <dhanuka@gnome.org>

Daiki Ueno authored Apr 10, 2024 and Daiki Ueno committed Apr 11, 2024

With this version, all required features are usable, including the
RIPEMD160 hash algorithm and the legacy PBES1-DES-SHA1 scheme:
https://gitlab.com/gnutls/gnutls/-/merge_requests/1824



Signed-off-by: Daiki Ueno <dueno@src.gnome.org>

Niels De Graef authored Dec 21, 2023 and Daiki Ueno committed Apr 11, 2024

Clients might be interested in retrieving which X.509 version is used
for the certificate for several reasons, or just for showing it in the
UI of an app.

Signed-off-by: Daiki Ueno <dueno@src.gnome.org>

This turns the `-Dgcrypt` build time option into a combo option, which
enables user to choose which cryptographic library to link with.  It
currently supports libgcrypt (`libgcrypt`) and GnuTLS (`gnutls`); for
the latter, a couple of legacy algorithms are disabled, namely
RIPEMD160 and PBES1-DES-SHA1 though it will be added in GnuTLS 3.8.5
for compatibility.

Signed-off-by: Daiki Ueno <dueno@src.gnome.org>

Signed-off-by: Daiki Ueno <dueno@src.gnome.org>

It is known that "ninja coverage-html" fails at the genhtml
invocation, with:

  genhtml: ERROR: duplicate merge record gck

As we also run "ninja coverage-xml", which produces cobertura output,
let's just omit the HTML generation.

Signed-off-by: Daiki Ueno <dueno@src.gnome.org>

Daiki Ueno authored Mar 22, 2024 and Niels De Graef committed Mar 22, 2024

When shifting an unsigned char, the operand first promoted to a signed
integer (int), and afterwards it may cause overflow depending on the
shift width.  This applies a type cast to uint32_t before shifting.

Spotted by UndefinedBehaviorSanitizer.

Signed-off-by: Daiki Ueno <dueno@src.gnome.org>

Daiki Ueno authored Mar 22, 2024 and Niels De Graef committed Mar 22, 2024

There were a couple of places where signed integer is wrapped around
when overflow, though unlike unsigned integer, it is undefined
behavior:
https://www.gnu.org/software/autoconf/manual/autoconf-2.63/html_node/Integer-Overflow-Basics.html#Integer-Overflow-Basics



Spotted by UndefinedBehaviorSanitizer.

Signed-off-by: Daiki Ueno <dueno@src.gnome.org>

Signed-off-by: Dhanuka Warusadura <dhanuka@gnome.org>

Dhanuka Warusadura authored Mar 01, 2024 and Niels De Graef committed Mar 02, 2024

If the ssh-agent process we launch dies before it becomes ready to take
input, self->pid will be set to 0 by on_child_watch().  If that happens,
there's no point in continuing to wait for the process to become ready.
This should avoid an unnecessary five-second wait in cases like [1] or
[2].

[1] https://bugzilla.gnome.org/show_bug.cgi?id=794848
[2] https://bugzilla.redhat.com/show_bug.cgi?id=1841855 (migrated to
https://issues.redhat.com/browse/RHEL-9302)

Original author: Steven Luo

Dhanuka Warusadura authored Mar 01, 2024 and Niels De Graef committed Mar 02, 2024

gkd_ssh_agent_process_connect() waits for the ssh-agent process to
become ready to accept input by entering the main loop while holding
self->lock.  However, if the ssh-agent process dies before becoming
ready, the main loop will call on_child_watch(), which needs to take
self->lock, causing a deadlock.  Fix this by releasing the lock before
entering the main loop.

This should prevent a busyloop that's been reported multiple times [1]
[2] from lasting forever.

[1] https://bugzilla.gnome.org/show_bug.cgi?id=794848
[2] https://bugzilla.redhat.com/show_bug.cgi?id=1841855 (migrated to
https://issues.redhat.com/browse/RHEL-9302)

Original author: Steven Luo

Aleksandr Mezin authored Feb 19, 2024 and Dhanuka Warusadura committed Mar 02, 2024

Like in `dbus.socket`:

https://gitlab.freedesktop.org/dbus/dbus/-/blob/master/bus/systemd-user/dbus.socket.in

Fixes: #55



Signed-off-by: Aleksandr Mezin <mezin.alexander@gmail.com>

Calling `meson $builddir` is deprecated in favor of the more explicit
`meson setup $builddir` and generates a warning.
Update this in both our CI and README.md

Signed-off-by: Dhanuka Warusadura <dhanuka@gnome.org>

As it now constructs the command-line arguments dynamically, they
should be freed after use.

Signed-off-by: Daiki Ueno <dueno@src.gnome.org>

Signed-off-by: Daiki Ueno <dueno@src.gnome.org>

This change ports the original fix introduce in gnome-keyring: ssh-agent
to gcr: ssh-agent.

See: gnome-keyring!47

Fixes: #109



Signed-off-by: Dhanuka Warusadura <dhanuka@gnome.org>

This change ports the original fix introduce in gnome-keyring: ssh-agent
to gcr: ssh-agent.

See: gnome-keyring!45

Fixes: #109



Signed-off-by: Dhanuka Warusadura <dhanuka@gnome.org>

This change updates ExecStart parameter to reflect the changes made
in "add ssh-agent command line options parsing to gcr-ssh-agent".

Signed-off-by: Dhanuka Warusadura <dhanuka@gnome.org>

With this change in place, gcr-ssh-agent can now accept hand over command
line options to ssh-agent.

Fixes: #112



Signed-off-by: Dhanuka Warusadura <dhanuka@gnome.org>