- Mar 27, 2024
- Mar 26, 2024
-
-
Michael Catanzaro authored
I forgot to return early on the error paths. Oops. This restores the original behavior. Fixes !1462
-
Michael Catanzaro authored
I described the ownership incorrectly.
-
In f9e74d51 I added an assertion that causes Epiphany to crash on exit if the EphyShell global object has been leaked. This assertion is being triggered whenever Firefox Sync tab synchronization is enabled. It happens due to a circular reference. Break it. This bug has existed since the Firefox Sync support was added. The assertion proves its value once again. A better solution might be to make the EphyTabsCatalog a separate object instead of an interface implemented by EphyEmbedShell. I might or might not explore that in a follow-up commit, because EphyOpenTabsManager shouldn't have to know about implementation details of the EphyTabsCatalog. Part-of: <!1463>
-
- Mar 25, 2024
-
-
Michael Catanzaro authored
secret_password_search_finish() returns a list of SecretRetrievable objects. We incorrectly assume it returns a list of SecretItems. SecretItem seems to be the only public implementation of SecretRetrievable, but clearly it's not the only implementation. We get to the same end result -- a SecretValue object -- either way, but SecretRetrievable has an async interface, so the code is a bit more complicated now. It's surely for the better. Fixes #1361 (probably) (hopefully :) Part-of: <!1462>
-
We lost this option in the transition from info bars to the popover-based UI. If you don't want to make any decision on whether or not to save the password, then your only option is to click outside the popover, which causes the password save request to stick around indefinitely. Permission requests have the same problem, but I think I'm OK with that as they occur less-frequently, and it's easy to change permissions later if desired, and it's usually easy to decide whether to allow or deny a permission request. But for passwords, you want to click "Not Now" frequently, e.g. whenever creating an account for a new service (since passwords are associated with form elements, and you surely want to save the password for the login page, not the account creation page). Since this is a relatively frequent workflow, we should make it easier. Fixes #2291 Part-of: <!1461>
-
- Mar 24, 2024
-
-
- Mar 23, 2024
-
-
(cherry picked from commit c158a4d5)
-
- Mar 22, 2024
-
-
The window size is stored in two places: * The session state, for every saved window * GSettings, as a fallback It has to be stored in GSettings because the user might not save any session state at all, or might close the final tab causing there to be no windows stored in the session state file. The existing code reads the window size from GSettings properly, but at some point long ago the code to write the window size got broken. This was reported more than 5 years ago but I didn't investigate it until now.... Fixes #525 Part-of: <!1459>
-
Michael Catanzaro authored
Part-of: <!1458>
-
- Mar 21, 2024
-
-
This is not expected and is worth warning about. Part-of: <!1454>
-
This just means the user decided not to install the web app. It's not a bug and not worth printing a warning over. Part-of: <!1454>
-
In !1400 we removed the code that caused the web app icon to be downloaded to a temporary location. That was important. We don't want them showing up in the user's downloads directory. To make this work, we'll need to stop using the URL of the icon as the filename, since it's expected to contain directory separator characters. Fixes #2118 Fixes #2297 Part-of: <!1454>
-
- Mar 20, 2024
-
-
-
Since the wiki will be decommissioned, we should stop linking to it. Part-of: <!1457>
-
- Mar 19, 2024
-
-
Philippe Normand authored
Disable the internal WebKit audio mixer because in some cases it triggers audio glitches. The GStreamer va plugin no longer need to be upranked because the WebKit SDK ships GStreamer 1.24 which already promoted this plugin for auto-plugging. Part-of: <!1456>
-
- Mar 18, 2024
-
-
(cherry picked from commit 399e1e31)
-
- Mar 17, 2024
- Mar 16, 2024
-
-
-
(cherry picked from commit d99c7b1f)
-
- Mar 15, 2024
-
-
Show clear button in location entry once it is focused and hide reader mode icon as well. Part-of: <!1446>
-
Michael Catanzaro authored
- Mar 14, 2024
-
-
Michael Catanzaro authored
We missed a spot in !1451 and introduced a spam of critical warnings. The send-via-email action is now no longer part of the window action group.
-
- Mar 13, 2024
-
-
Part-of: <!1450>
-
- Mar 11, 2024
- Mar 10, 2024
-
-
-
Piotr Drąg authored
-
-
- Mar 08, 2024
-
-
Michael Catanzaro authored
-
-
-